* [PATCH] ALSA: oxygen: use true,false for bool variables
@ 2020-04-22 7:16 Jason Yan
2020-04-22 9:41 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Jason Yan @ 2020-04-22 7:16 UTC (permalink / raw)
To: clemens, perex, tiwai, tglx, alsa-devel, linux-kernel; +Cc: Jason Yan
Fix the following coccicheck warning:
sound/pci/oxygen/xonar_pcm179x.c:463:1-17: WARNING: Assignment of 0/1 to
bool variable
sound/pci/oxygen/xonar_pcm179x.c:505:1-17: WARNING: Assignment of 0/1 to
bool variable
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
sound/pci/oxygen/xonar_pcm179x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/oxygen/xonar_pcm179x.c b/sound/pci/oxygen/xonar_pcm179x.c
index 6a0520c4fb5a..cf801a235df9 100644
--- a/sound/pci/oxygen/xonar_pcm179x.c
+++ b/sound/pci/oxygen/xonar_pcm179x.c
@@ -460,7 +460,7 @@ static void xonar_st_init(struct oxygen *chip)
data->generic.anti_pop_delay = 100;
data->h6 = chip->model.dac_channels_mixer > 2;
- data->has_cs2000 = 1;
+ data->has_cs2000 = true;
data->cs2000_regs[CS2000_FUN_CFG_1] = CS2000_REF_CLK_DIV_1;
data->broken_i2c = true;
@@ -502,7 +502,7 @@ static void xonar_xense_init(struct oxygen *chip)
xonar_init_ext_power(chip);
data->generic.anti_pop_delay = 100;
- data->has_cs2000 = 1;
+ data->has_cs2000 = true;
data->cs2000_regs[CS2000_FUN_CFG_1] = CS2000_REF_CLK_DIV_1;
oxygen_write16(chip, OXYGEN_I2S_A_FORMAT,
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: oxygen: use true,false for bool variables
2020-04-22 7:16 [PATCH] ALSA: oxygen: use true,false for bool variables Jason Yan
@ 2020-04-22 9:41 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2020-04-22 9:41 UTC (permalink / raw)
To: Jason Yan; +Cc: clemens, perex, tiwai, tglx, alsa-devel, linux-kernel
On Wed, 22 Apr 2020 09:16:46 +0200,
Jason Yan wrote:
>
> Fix the following coccicheck warning:
>
> sound/pci/oxygen/xonar_pcm179x.c:463:1-17: WARNING: Assignment of 0/1 to
> bool variable
> sound/pci/oxygen/xonar_pcm179x.c:505:1-17: WARNING: Assignment of 0/1 to
> bool variable
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: oxygen: use true,false for bool variables
@ 2020-04-22 9:41 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2020-04-22 9:41 UTC (permalink / raw)
To: Jason Yan; +Cc: alsa-devel, clemens, linux-kernel, tiwai, tglx
On Wed, 22 Apr 2020 09:16:46 +0200,
Jason Yan wrote:
>
> Fix the following coccicheck warning:
>
> sound/pci/oxygen/xonar_pcm179x.c:463:1-17: WARNING: Assignment of 0/1 to
> bool variable
> sound/pci/oxygen/xonar_pcm179x.c:505:1-17: WARNING: Assignment of 0/1 to
> bool variable
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-22 9:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 7:16 [PATCH] ALSA: oxygen: use true,false for bool variables Jason Yan
2020-04-22 9:41 ` Takashi Iwai
2020-04-22 9:41 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.