All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] package/iwd: fix build with glibc < 2.24
Date: Wed, 22 Apr 2020 10:16:28 +0200	[thread overview]
Message-ID: <20200422081628.4181172-1-fontaine.fabrice@gmail.com> (raw)

Fixes:
 - http://autobuild.buildroot.org/results/63f983aa22ca5303a55bc55e004f05a94e5f7259

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Thomas Petazzoni):
 - Fix commit title and message: issue is due to glibc, not gcc

 ...ame-xchg.c-fix-build-with-glibc-2.24.patch | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 package/iwd/0001-frame-xchg.c-fix-build-with-glibc-2.24.patch

diff --git a/package/iwd/0001-frame-xchg.c-fix-build-with-glibc-2.24.patch b/package/iwd/0001-frame-xchg.c-fix-build-with-glibc-2.24.patch
new file mode 100644
index 0000000000..cd0bae4835
--- /dev/null
+++ b/package/iwd/0001-frame-xchg.c-fix-build-with-glibc-2.24.patch
@@ -0,0 +1,46 @@
+From 44cd3719eb94c8d5776b37c73993eea0617902f7 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Sat, 11 Apr 2020 23:21:42 +0200
+Subject: [PATCH] frame-xchg.c: fix build with glibc < 2.24
+
+SOL_NETLINK is used since commit
+87a198111af1ea67053895f7435fb99e3cdd2159 resulting in the following
+build failure with glibc < 2.24:
+
+src/frame-xchg.c: In function 'frame_watch_group_io_read':
+src/frame-xchg.c:328:27: error: 'SOL_NETLINK' undeclared (first use in this function)
+   if (cmsg->cmsg_level != SOL_NETLINK)
+                           ^
+
+This failure is due to glibc that doesn't support SOL_NETLINK before
+version 2.24 and
+https://github.com/bminor/glibc/commit/f9b437d5efce93800b51ad2a437c8b1c9616bf80
+
+Fixes:
+ - http://autobuild.buildroot.org/results/3485088b84111c271bbcfaf025aa4103c6452072
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status:
+https://lists.01.org/hyperkitty/list/iwd at lists.01.org/thread/ZRN25CA5I7PGUTFIRJLLXN7VHWGDAZDN]
+---
+ src/frame-xchg.c | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/src/frame-xchg.c b/src/frame-xchg.c
+index 50351615..4c950fd3 100644
+--- a/src/frame-xchg.c
++++ b/src/frame-xchg.c
+@@ -42,6 +42,10 @@
+ #include "src/netdev.h"
+ #include "src/frame-xchg.h"
+ 
++#ifndef SOL_NETLINK
++#define SOL_NETLINK 270
++#endif
++
+ struct watch_group {
+ 	/*
+ 	 * Group IDs, except 0, are per wdev for user's convenience.
+-- 
+2.25.1
+
-- 
2.25.1

             reply	other threads:[~2020-04-22  8:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  8:16 Fabrice Fontaine [this message]
2020-04-23 21:26 ` [Buildroot] [PATCH v2, 1/1] package/iwd: fix build with glibc < 2.24 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200422081628.4181172-1-fontaine.fabrice@gmail.com \
    --to=fontaine.fabrice@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.