From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 180B1C5518A for ; Wed, 22 Apr 2020 09:18:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 017E1206D9 for ; Wed, 22 Apr 2020 09:18:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726147AbgDVJS5 (ORCPT ); Wed, 22 Apr 2020 05:18:57 -0400 Received: from inva021.nxp.com ([92.121.34.21]:43116 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbgDVJS5 (ORCPT ); Wed, 22 Apr 2020 05:18:57 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 60C65201036; Wed, 22 Apr 2020 11:18:54 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 53E5620101B; Wed, 22 Apr 2020 11:18:54 +0200 (CEST) Received: from localhost (fsr-ub1664-175.ea.freescale.net [10.171.82.40]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 3E942202AF; Wed, 22 Apr 2020 11:18:54 +0200 (CEST) Date: Wed, 22 Apr 2020 12:18:54 +0300 From: Abel Vesa To: Lee Jones Cc: Shawn Guo , Peng Fan , Philipp Zabel , Stephen Boyd , Sascha Hauer , Anson Huang , Leonard Crestez , Jacky Bai , NXP Linux Team , Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 01/13] mfd: Add i.MX generic mix support Message-ID: <20200422091854.rhtkcfrdptwofngs@fsr-ub1664-175> References: <1586937773-5836-1-git-send-email-abel.vesa@nxp.com> <1586937773-5836-2-git-send-email-abel.vesa@nxp.com> <20200417080747.GE2167633@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200417080747.GE2167633@dell> User-Agent: NeoMutt/20180622 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-04-17 09:07:47, Lee Jones wrote: > On Wed, 15 Apr 2020, Abel Vesa wrote: > > > Some of the i.MX SoCs have a IP for interfacing the dedicated IPs with > > clocks, resets and interrupts, plus some other specific control registers. > > To allow the functionality to be split between drivers, this MFD driver is > > added that has only two purposes: register the devices and map the entire > > register addresses. Everything else is left to the dedicated drivers that > > will bind to the registered devices. > > > > Signed-off-by: Abel Vesa > > --- > > drivers/mfd/Kconfig | 11 +++++++++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/imx-mix.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 60 insertions(+) > > create mode 100644 drivers/mfd/imx-mix.c > > For completeness - Arnd's reply to this patch: > > https://www.spinics.net/lists/linux-clk/msg47703.html I'm replying here to Arnd's reply. I'm trying to give here a whole picture of the entire problem while the documentation for i.MX8MP is _not yet_ public. Historically, each IP would have its own enclosure for all the related GPRs. Starting with i.MX8MP some GPRs (and some subparts) from the IP were placed inside these mixes. Audiomix for example, has multiple SAIs, a PLL, and some reset bits for EARC and some GPRs for AudioDSP. This means that i.MX8MP has 7 SAIs, 1 EARC and 1 AudioDSP. Future platforms might have different numbers of SAIs, EARCs or AudioDSPs. The PLL can't be placed in one of those SAIs and it was placed in audiomix. The i.MX8MP has at least 4 of these mixes. Now, the commonalities between all mixes are: - have their own power domains - driven by dedicated clock slice - contain clocks and resets - some very subsystem specific GPRs Knowing that each mix has its own power domain, AFAICT, it needs to be registered as a single device. Considering that it can have clocks (audiomix has gates, muxes and plls), I believe that needs a clock driver, even more so since the muxes need their parents from the platform clock driver. Same principle applies to reset bits. The subsystem specific GPRs can be registered as syscon devices and taken care of by its counterpart IP (e.g. the AudioDSP specific regs would be taken care of by the DSP driver, if there is one). Now based on all of the above, by using MFD we take care of the power domain control for the entire mix, plus, the MFD doesn't have any kind of functionality by its own, relying on its children devices that are populated based on what is in the mix MFD devicetree node. > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB04C55189 for ; Wed, 22 Apr 2020 09:19:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9947E20735 for ; Wed, 22 Apr 2020 09:19:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dEciOKZC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9947E20735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MnoV54AuLwrFEoPJEZHUiUAl+Em0EoTcxSqDW1rBl2I=; b=dEciOKZCg7psTJ 4MBOBne6iNNzDyFGpbxff4gdrzKozYVPOIxqmzb/J7KSrjiICznAjERg76IqEorPdrU+zyJlA2KxJ PwGJAHCei7GQJ/J51e2Jq4Vqh4wCRZ4CVeolN1sQIjhiLfDbP8sDQxw7KmvMV7fknFUeYLSqAKq3U o8SGPl34PcJZsSnZp+m5Dvdm6JPLRWu86+htT/ua+IPZN1RVyk81Emq73d/wYDv0a5f6GmVnZNpU0 ETvX9Kvt3moLQH3ntHmw1nCabV14vTQN13gvx0BEMwrYg+2pn9Debm7weLRTVrq8dViInyArAAU1E 7aANIxlA1/ijGiveLntQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRBX3-0002p9-2T; Wed, 22 Apr 2020 09:19:01 +0000 Received: from inva021.nxp.com ([92.121.34.21]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRBX0-0002nV-Fj for linux-arm-kernel@lists.infradead.org; Wed, 22 Apr 2020 09:19:00 +0000 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 60C65201036; Wed, 22 Apr 2020 11:18:54 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 53E5620101B; Wed, 22 Apr 2020 11:18:54 +0200 (CEST) Received: from localhost (fsr-ub1664-175.ea.freescale.net [10.171.82.40]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 3E942202AF; Wed, 22 Apr 2020 11:18:54 +0200 (CEST) Date: Wed, 22 Apr 2020 12:18:54 +0300 From: Abel Vesa To: Lee Jones Subject: Re: [PATCH v3 01/13] mfd: Add i.MX generic mix support Message-ID: <20200422091854.rhtkcfrdptwofngs@fsr-ub1664-175> References: <1586937773-5836-1-git-send-email-abel.vesa@nxp.com> <1586937773-5836-2-git-send-email-abel.vesa@nxp.com> <20200417080747.GE2167633@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200417080747.GE2167633@dell> User-Agent: NeoMutt/20180622 X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200422_021858_796212_44EB3A95 X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Peng Fan , Philipp Zabel , Anson Huang , Stephen Boyd , Linux Kernel Mailing List , NXP Linux Team , Sascha Hauer , Leonard Crestez , Shawn Guo , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jacky Bai Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAtMDQtMTcgMDk6MDc6NDcsIExlZSBKb25lcyB3cm90ZToKPiBPbiBXZWQsIDE1IEFwciAy MDIwLCBBYmVsIFZlc2Egd3JvdGU6Cj4KPiA+IFNvbWUgb2YgdGhlIGkuTVggU29DcyBoYXZlIGEg SVAgZm9yIGludGVyZmFjaW5nIHRoZSBkZWRpY2F0ZWQgSVBzIHdpdGgKPiA+IGNsb2NrcywgcmVz ZXRzIGFuZCBpbnRlcnJ1cHRzLCBwbHVzIHNvbWUgb3RoZXIgc3BlY2lmaWMgY29udHJvbCByZWdp c3RlcnMuCj4gPiBUbyBhbGxvdyB0aGUgZnVuY3Rpb25hbGl0eSB0byBiZSBzcGxpdCBiZXR3ZWVu IGRyaXZlcnMsIHRoaXMgTUZEIGRyaXZlciBpcwo+ID4gYWRkZWQgdGhhdCBoYXMgb25seSB0d28g cHVycG9zZXM6IHJlZ2lzdGVyIHRoZSBkZXZpY2VzIGFuZCBtYXAgdGhlIGVudGlyZQo+ID4gcmVn aXN0ZXIgYWRkcmVzc2VzLiBFdmVyeXRoaW5nIGVsc2UgaXMgbGVmdCB0byB0aGUgZGVkaWNhdGVk IGRyaXZlcnMgdGhhdAo+ID4gd2lsbCBiaW5kIHRvIHRoZSByZWdpc3RlcmVkIGRldmljZXMuCj4g Pgo+ID4gU2lnbmVkLW9mZi1ieTogQWJlbCBWZXNhIDxhYmVsLnZlc2FAbnhwLmNvbT4KPiA+IC0t LQo+ID4gIGRyaXZlcnMvbWZkL0tjb25maWcgICB8IDExICsrKysrKysrKysrCj4gPiAgZHJpdmVy cy9tZmQvTWFrZWZpbGUgIHwgIDEgKwo+ID4gIGRyaXZlcnMvbWZkL2lteC1taXguYyB8IDQ4ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDMgZmls ZXMgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygrKQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2 ZXJzL21mZC9pbXgtbWl4LmMKPgo+IEZvciBjb21wbGV0ZW5lc3MgLSBBcm5kJ3MgcmVwbHkgdG8g dGhpcyBwYXRjaDoKPgo+ICBodHRwczovL3d3dy5zcGluaWNzLm5ldC9saXN0cy9saW51eC1jbGsv bXNnNDc3MDMuaHRtbAoKSSdtIHJlcGx5aW5nIGhlcmUgdG8gQXJuZCdzIHJlcGx5LgoKSSdtIHRy eWluZyB0byBnaXZlIGhlcmUgYSB3aG9sZSBwaWN0dXJlIG9mIHRoZSBlbnRpcmUgcHJvYmxlbSB3 aGlsZSB0aGUKZG9jdW1lbnRhdGlvbiBmb3IgaS5NWDhNUCBpcyBfbm90IHlldF8gcHVibGljLgoK SGlzdG9yaWNhbGx5LCBlYWNoIElQIHdvdWxkIGhhdmUgaXRzIG93biBlbmNsb3N1cmUgZm9yIGFs bCB0aGUgcmVsYXRlZCBHUFJzLgpTdGFydGluZyB3aXRoIGkuTVg4TVAgc29tZSBHUFJzIChhbmQg c29tZSBzdWJwYXJ0cykgZnJvbSB0aGUgSVAgd2VyZSBwbGFjZWQKaW5zaWRlIHRoZXNlIG1peGVz LgoKQXVkaW9taXggZm9yIGV4YW1wbGUsIGhhcyBtdWx0aXBsZSBTQUlzLCBhIFBMTCwgYW5kIHNv bWUgcmVzZXQgYml0cyBmb3IgRUFSQyBhbmQKc29tZSBHUFJzIGZvciBBdWRpb0RTUC4gVGhpcyBt ZWFucyB0aGF0IGkuTVg4TVAgaGFzIDcgU0FJcywgMSBFQVJDIGFuZCAxIEF1ZGlvRFNQLgpGdXR1 cmUgcGxhdGZvcm1zIG1pZ2h0IGhhdmUgZGlmZmVyZW50IG51bWJlcnMgb2YgU0FJcywgRUFSQ3Mg b3IgQXVkaW9EU1BzLiBUaGUgUExMCmNhbid0IGJlIHBsYWNlZCBpbiBvbmUgb2YgdGhvc2UgU0FJ cyBhbmQgaXQgd2FzIHBsYWNlZCBpbiBhdWRpb21peC4KVGhlIGkuTVg4TVAgaGFzIGF0IGxlYXN0 IDQgb2YgdGhlc2UgbWl4ZXMuCgpOb3csIHRoZSBjb21tb25hbGl0aWVzIGJldHdlZW4gYWxsIG1p eGVzIGFyZToKIC0gaGF2ZSB0aGVpciBvd24gcG93ZXIgZG9tYWlucwogLSBkcml2ZW4gYnkgZGVk aWNhdGVkIGNsb2NrIHNsaWNlCiAtIGNvbnRhaW4gY2xvY2tzIGFuZCByZXNldHMKIC0gc29tZSB2 ZXJ5IHN1YnN5c3RlbSBzcGVjaWZpYyBHUFJzCgpLbm93aW5nIHRoYXQgZWFjaCBtaXggaGFzIGl0 cyBvd24gcG93ZXIgZG9tYWluLCBBRkFJQ1QsIGl0IG5lZWRzIHRvIGJlIHJlZ2lzdGVyZWQKYXMg YSBzaW5nbGUgZGV2aWNlLiBDb25zaWRlcmluZyB0aGF0IGl0IGNhbiBoYXZlIGNsb2NrcyAoYXVk aW9taXggaGFzIGdhdGVzLAptdXhlcyBhbmQgcGxscyksIEkgYmVsaWV2ZSB0aGF0IG5lZWRzIGEg Y2xvY2sgZHJpdmVyLCBldmVuIG1vcmUgc28gc2luY2UgdGhlCm11eGVzIG5lZWQgdGhlaXIgcGFy ZW50cyBmcm9tIHRoZSBwbGF0Zm9ybSBjbG9jayBkcml2ZXIuIFNhbWUgcHJpbmNpcGxlIGFwcGxp ZXMKdG8gcmVzZXQgYml0cy4gVGhlIHN1YnN5c3RlbSBzcGVjaWZpYyBHUFJzIGNhbiBiZSByZWdp c3RlcmVkIGFzIHN5c2NvbiBkZXZpY2VzCmFuZCB0YWtlbiBjYXJlIG9mIGJ5IGl0cyBjb3VudGVy cGFydCBJUCAoZS5nLiB0aGUgQXVkaW9EU1Agc3BlY2lmaWMgcmVncyB3b3VsZApiZSB0YWtlbiBj YXJlIG9mIGJ5IHRoZSBEU1AgZHJpdmVyLCBpZiB0aGVyZSBpcyBvbmUpLgoKTm93IGJhc2VkIG9u IGFsbCBvZiB0aGUgYWJvdmUsIGJ5IHVzaW5nIE1GRCB3ZSB0YWtlIGNhcmUgb2YgdGhlIHBvd2Vy IGRvbWFpbgpjb250cm9sIGZvciB0aGUgZW50aXJlIG1peCwgcGx1cywgdGhlIE1GRCBkb2Vzbid0 IGhhdmUgYW55IGtpbmQgb2YKZnVuY3Rpb25hbGl0eSBieSBpdHMgb3duLCByZWx5aW5nIG9uIGl0 cyBjaGlsZHJlbiBkZXZpY2VzIHRoYXQgYXJlIHBvcHVsYXRlZApiYXNlZCBvbiB3aGF0IGlzIGlu IHRoZSBtaXggTUZEIGRldmljZXRyZWUgbm9kZS4KCj4gLS0KPiBMZWUgSm9uZXMgW+adjueQvOaW r10KPiBMaW5hcm8gU2VydmljZXMgVGVjaG5pY2FsIExlYWQKPiBMaW5hcm8ub3JnIOKUgiBPcGVu IHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKPiBGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8 IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==