From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94595C55186 for ; Wed, 22 Apr 2020 10:23:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68C5B2084D for ; Wed, 22 Apr 2020 10:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587551037; bh=iXMXhubN516VSHJjbodtOZrbU9W45/hHHrxQFuVpNxU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=InO52d0TGuB5znBJT/7u9FDJSpwruSLZlHpITiQlJbOYN+w3aLxRsdfAhw/gd2LWG GjrDBRi3Ah21ypitvorbzyP9K1FppfH+c1PpjvrMZbzOVqJDZmc7wNYB9BFkjApUR9 osvab3gTkSlN1PQ4RI8s9Zd2JqsXL0V0UXSEnVtg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730382AbgDVKXv (ORCPT ); Wed, 22 Apr 2020 06:23:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:59828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730327AbgDVKXW (ORCPT ); Wed, 22 Apr 2020 06:23:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F41342076B; Wed, 22 Apr 2020 10:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587551002; bh=iXMXhubN516VSHJjbodtOZrbU9W45/hHHrxQFuVpNxU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zpM2kXltrfRT2ZvWUaeUB+LtBhsZF9peA41BDUObe1ROVrSFMy1RqpLYkwsjQXghj A9mBHVk7zECrupVdQ+ALNxHrllj+dvggaYMu93P+RWv0+igO4KuItj2nhhDEtauVX+ C75ZAVlpKhHU4HNQj194Od6XBwGJB3KUa0t/Ydz4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Erhard F." , Frank Rowand , Rob Herring Subject: [PATCH 5.6 024/166] of: overlay: kmemleak in dup_and_fixup_symbol_prop() Date: Wed, 22 Apr 2020 11:55:51 +0200 Message-Id: <20200422095051.167628110@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095047.669225321@linuxfoundation.org> References: <20200422095047.669225321@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand commit 478ff649b1c8eb2409b1a54fb75eb46f7c29f140 upstream. kmemleak reports several memory leaks from devicetree unittest. This is the fix for problem 4 of 5. target_path was not freed in the non-error path. Fixes: e0a58f3e08d4 ("of: overlay: remove a dependency on device node full_name") Reported-by: Erhard F. Signed-off-by: Frank Rowand Signed-off-by: Rob Herring Signed-off-by: Greg Kroah-Hartman --- drivers/of/overlay.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -261,6 +261,8 @@ static struct property *dup_and_fixup_sy of_property_set_flag(new_prop, OF_DYNAMIC); + kfree(target_path); + return new_prop; err_free_new_prop: