From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C9BC2BA19 for ; Thu, 23 Apr 2020 06:03:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBCAC20781 for ; Thu, 23 Apr 2020 06:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726108AbgDWGDB (ORCPT ); Thu, 23 Apr 2020 02:03:01 -0400 Received: from verein.lst.de ([213.95.11.211]:56082 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgDWGDB (ORCPT ); Thu, 23 Apr 2020 02:03:01 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9CD39227A8A; Thu, 23 Apr 2020 08:02:57 +0200 (CEST) Date: Thu, 23 Apr 2020 08:02:57 +0200 From: Christoph Hellwig To: Ming Lei Cc: James Bottomley , linux-scsi@vger.kernel.org, "Martin K . Petersen" , Bart Van Assche , Christoph Hellwig , John Garry Subject: Re: [PATCH V2] scsi: put hot fields of scsi_host_template into one cacheline Message-ID: <20200423060256.GA9537@lst.de> References: <20200422095425.319674-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422095425.319674-1-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Looks good, although you might want to throw in a blurb on the actually measured benefits: Reviewed-by: Christoph Hellwig