All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Garima Singh <garimasigit@gmail.com>
Cc: Jeff King <peff@peff.net>,
	git@vger.kernel.org, Garima Singh <garima.singh@microsoft.com>,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 0/2] minor fixups for gs/commit-graph-path-filter
Date: Fri, 24 Apr 2020 10:58:05 -0600	[thread overview]
Message-ID: <20200424165805.GC58621@syl.local> (raw)
In-Reply-To: <dde036bb-303c-a9d1-6bf2-880428cfb7c0@gmail.com>

On Thu, Apr 23, 2020 at 06:14:36PM -0400, Garima Singh wrote:
>
> On 4/23/2020 4:58 PM, Jeff King wrote:
> > These are just a few bits I noticed in the test-tool helper when the
> > topic hit next (my -Wunused-parameter patch complained that we never
> > looked at argc).
> >
> >   [1/2]: test-bloom: fix some whitespace issues
> >   [2/2]: test-bloom: check that we have expected arguments
> >
> >  t/helper/test-bloom.c | 28 ++++++++++++++++++++--------
> >  1 file changed, 20 insertions(+), 8 deletions(-)
> >
> > -Peff
> >
>
> Thank you for doing this!
> Both patches look good to me.
> I also don't care about the brace/no-brace thing that
> Taylor brought up for 1/2.

To be clear, I don't care about them either ;). Maybe it's time that we
relax that rule (if it seems that a good number of us don't mind it
either way)..?

> Cheers!
> Garima Singh

Thanks,
Taylor

  reply	other threads:[~2020-04-24 16:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 20:58 [PATCH 0/2] minor fixups for gs/commit-graph-path-filter Jeff King
2020-04-23 20:59 ` [PATCH 1/2] test-bloom: fix some whitespace issues Jeff King
2020-04-23 21:01   ` Taylor Blau
2020-04-23 21:04     ` Jeff King
2020-04-23 20:59 ` [PATCH 2/2] test-bloom: check that we have expected arguments Jeff King
2020-04-23 21:02   ` Taylor Blau
2020-04-23 22:14 ` [PATCH 0/2] minor fixups for gs/commit-graph-path-filter Garima Singh
2020-04-24 16:58   ` Taylor Blau [this message]
2020-04-24 20:00     ` Junio C Hamano
2020-04-24  1:00 ` Danh Doan
2020-04-24  5:25   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200424165805.GC58621@syl.local \
    --to=me@ttaylorr.com \
    --cc=dstolee@microsoft.com \
    --cc=garima.singh@microsoft.com \
    --cc=garimasigit@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.