From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08AE0C55186 for ; Fri, 24 Apr 2020 19:54:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA7CF2166E for ; Fri, 24 Apr 2020 19:54:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="jOkapKtX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729280AbgDXTy2 (ORCPT ); Fri, 24 Apr 2020 15:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727059AbgDXTy2 (ORCPT ); Fri, 24 Apr 2020 15:54:28 -0400 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13EA1C09B049 for ; Fri, 24 Apr 2020 12:54:28 -0700 (PDT) Received: by mail-qv1-xf41.google.com with SMTP id di6so5298783qvb.10 for ; Fri, 24 Apr 2020 12:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VRWGw+Ids2J/IVS8Zfm76j7+TTZ3bwJIR/se+BO3dNs=; b=jOkapKtXRrSVdQIX+HKmfTfebHFdL6/rZHzHufL4crJNiVgRl3vuGoCk1k7PYleJTN Y9QPA8fFaUnyScF4/gjS6AHcXqS7oQzh8cpQG//Dw+lV1L/7QozlIGx29bUMFXi2zOV/ Pz+W6NopTcbp+G7mQhJJjbVDXhahbBLhO9D+DofekdIS+rPS1Y9Ye4Z8zassoE23uc4l WmDmS1xyw7n9FK9Nh3iKym6l+heBY8VQoVcJ0dQVEcar5Ucl0vytM9nmAkeHDm5mMjjQ c4zK603mpXhtDf1bHx2+mMIbeT94YYyQHcGm1fbZN+ZGIzWvEb3fwbr06Qtt/RKZWut7 O2IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VRWGw+Ids2J/IVS8Zfm76j7+TTZ3bwJIR/se+BO3dNs=; b=QpanFZU+E9IlPXajep7jdJPeqg//qnCLpWepGvSM2Lsyppqsf6q6rzIVFnvyUE+T1L B5+9JRt3JkdHkhuAP90BsuIy64EAYcrneM9psuRGa6vNX3UPg7T5ijJyQG9xKiO8TCec fUuqSbktDNLvfDH0Vb8l6CEf0CJGgjTOYET6J11YHhjote75JywVegHrinGjiDE+cwcD XYntEIUd1Y9wJOGWoQlctENniWXSjYBalFpU9T6hjInDeofwXTS76d1yZ1EN+weCUWKb FbSdmpH+zz8+O5Mvfz6zWrvdlTjX6EbmfUIGRH6YDHVkTyEoRifoOr87WgWlq4WBE6WI LueQ== X-Gm-Message-State: AGi0PuYb4I3eixvyjD1oevkp+UZPDbdzQIayaBoszGWdj+jrNQnA0AA1 9Nmhd7VeJ0GPI9agWf7vntyNdw== X-Google-Smtp-Source: APiQypLWXS5Rfvw4pDLkSd1Bcle5kpvUQdgBT2nx0m2i2bXnCx0BVS6MOSW8pZFqkWdYjJN4WKf/hg== X-Received: by 2002:ad4:45ec:: with SMTP id q12mr11067687qvu.157.1587758067042; Fri, 24 Apr 2020 12:54:27 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id o94sm4612480qtd.34.2020.04.24.12.54.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Apr 2020 12:54:26 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jS4P4-0007b4-1S; Fri, 24 Apr 2020 16:54:26 -0300 Date: Fri, 24 Apr 2020 16:54:26 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , Leon Romanovsky , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Maor Gottlieb Subject: Re: [PATCH rdma-next 00/18] Refactor mlx5_ib_create_qp (Part I) Message-ID: <20200424195426.GA29169@ziepe.ca> References: <20200420151105.282848-1-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200420151105.282848-1-leon@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Apr 20, 2020 at 06:10:47PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This is first part of series which tries to return some sanity > to mlx5_ib_create_qp() function. Such refactoring is required > to make extension of that function with less worries of breaking > driver. > > Extra goal of such refactoring is to ensure that QP is allocated > at the beginning of function and released at the end. It will allow > us to move QP allocation to be under IB/core responsibility. > > It is based on previously sent [1] "[PATCH mlx5-next 00/24] Mass > conversion to light mlx5 command interface" > > Thanks > > [1] https://lore.kernel.org/linux-rdma/20200420114136.264924-1-leon@kernel.org > > Leon Romanovsky (18): > RDMA/mlx5: Organize QP types checks in one place > RDMA/mlx5: Delete impossible GSI port check > RDMA/mlx5: Perform check if QP creation flow is valid > RDMA/mlx5: Prepare QP allocation for future removal > RDMA/mlx5: Avoid setting redundant NULL for XRC QPs > RDMA/mlx5: Set QP subtype immediately when it is known > RDMA/mlx5: Separate create QP flows to be based on type > RDMA/mlx5: Split scatter CQE configuration for DCT QP > RDMA/mlx5: Update all DRIVER QP places to use QP subtype > RDMA/mlx5: Move DRIVER QP flags check into separate function > RDMA/mlx5: Remove second copy from user for non RSS RAW QPs > RDMA/mlx5: Initial separation of RAW_PACKET QP from common flow > RDMA/mlx5: Delete create QP flags obfuscation > RDMA/mlx5: Process create QP flags in one place > RDMA/mlx5: Use flags_en mechanism to mark QP created with WQE > signature > RDMA/mlx5: Change scatter CQE flag to be set like other vendor flags > RDMA/mlx5: Return all configured create flags through query QP > RDMA/mlx5: Process all vendor flags in one place This seems reasonable, can you send it so it applies without other series? Jason