All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dima Stepanov <dimastep@yandex-team.ru>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	Raphael Norwitz <raphael.norwitz@nutanix.com>
Subject: Re: [RFC PATCH v1 1/7] contrib/vhost-user-blk: add option to simulate disconnect on init
Date: Sat, 25 Apr 2020 12:30:40 +0300	[thread overview]
Message-ID: <20200425093030.GA28992@dimastep-nix> (raw)
In-Reply-To: <CAMxuvaxaOTO3gmCfNjFRDk-MXfcK20d2aaN+zUHUhtRFN=pPsw@mail.gmail.com>

On Fri, Apr 24, 2020 at 12:17:54PM +0200, Marc-André Lureau wrote:
> Hi
> 
> On Fri, Apr 24, 2020 at 4:32 AM Raphael Norwitz
> <raphael.norwitz@nutanix.com> wrote:
> >
> > I’m not opposed to adding this kind of debugging functionality to the
> > vhost-user-blk sample. It could be helpful to easily test these cases
> > in the future.
> >
> > That said, I'm not sure how others will feel about adding these kind
> > of debugging capabilities to libvhost-user. Marc-Andre, thoughts?
> 
> Maybe we should only enable this code if LIBVHOST_USER_DEBUG is set?
> 
> And to make logging silent by default, we shouldn't print them unless
> VHOST_USER_DEBUG env is set?
Yes, it is a good idea to move this code under LIBVHOST_USER_DEBUG.
Agree. Will update it in version 2, but need more feedback on other
patches first.

> 
> >
> > If we go this route I would prefer to add the debugging options to the
> > vhost-user-blk sample in a separate patch.
> >
> > On Thu, Apr 23, 2020 at 09:39:32PM +0300, Dima Stepanov wrote:
> > >
> > > Add "--simulate-disconnect-stage" option for the testing purposes.
> > > This option can be used to test the vhost-user reconnect functionality:
> > >   ./vhost-user-blk ... --simulate-disconnect-stage=<CASENUM>
> > > In this case the daemon will "crash" in the middle of the VHOST comands
> > > communication. Case nums are as follows:
> > >   1 - make assert in the handler of the SET_VRING_CALL command
> > >   2 - make assert in the handler of the SET_VRING_NUM command
> > > Main purpose is to test QEMU reconnect functionality. Such fail
> > > injection should not lead to QEMU crash and should be handled
> > > successfully.
> > > Also update the "GOptionEntry entries" definition with the final NULL
> > > item according to API.
> > >
> > > Signed-off-by: Dima Stepanov <dimastep@yandex-team.ru>
> > > ---
> > >  contrib/libvhost-user/libvhost-user.c   | 30 ++++++++++++++++++++++++++++++
> > >  contrib/libvhost-user/libvhost-user.h   | 13 +++++++++++++
> > >  contrib/vhost-user-blk/vhost-user-blk.c | 14 +++++++++++++-
> > >  3 files changed, 56 insertions(+), 1 deletion(-)
> >
> 


  reply	other threads:[~2020-04-25  9:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 18:39 [RFC PATCH v1 0/7] vhost-user reconnect issues during vhost initialization Dima Stepanov
2020-04-23 18:39 ` [RFC PATCH v1 1/7] contrib/vhost-user-blk: add option to simulate disconnect on init Dima Stepanov
     [not found]   ` <20200422160206.GA30919@localhost.localdomain>
2020-04-24 10:17     ` Marc-André Lureau
2020-04-25  9:30       ` Dima Stepanov [this message]
2020-04-23 18:39 ` [RFC PATCH v1 2/7] char-socket: return -1 in case of disconnect during tcp_chr_write Dima Stepanov
2020-04-23 20:10   ` Marc-André Lureau
     [not found]   ` <ca921f6f56104bcbb664424f97558ec3@HE1PR08MB2650.eurprd08.prod.outlook.com>
2020-04-24  9:55     ` Anton Nefedov
2020-04-23 18:39 ` [RFC PATCH v1 3/7] char-socket: initialize reconnect timer only if close is emitted Dima Stepanov
2020-04-23 19:16   ` Marc-André Lureau
2020-04-26  7:26     ` Li Feng
2020-04-27  9:38       ` Dima Stepanov
2020-04-23 18:39 ` [RFC PATCH v1 4/7] vhost: introduce wrappers to set guest notifiers for virtio device Dima Stepanov
2020-04-23 18:39 ` [RFC PATCH v1 5/7] vhost-user-blk: add mechanism to track the guest notifiers init state Dima Stepanov
     [not found]   ` <20200422161750.GC31091@localhost.localdomain>
2020-04-24  9:17     ` Dima Stepanov
2020-04-23 18:39 ` [RFC PATCH v1 6/7] vhost: check vring address before calling unmap Dima Stepanov
2020-04-23 18:39 ` [RFC PATCH v1 7/7] vhost: add device started check in migration set log Dima Stepanov
2020-04-24  2:44 [RFC PATCH v1 1/7] contrib/vhost-user-blk: add option to simulate disconnect on init Raphael Norwitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425093030.GA28992@dimastep-nix \
    --to=dimastep@yandex-team.ru \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=raphael.norwitz@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.