From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A671DC55194 for ; Sun, 26 Apr 2020 22:21:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EE882070A for ; Sun, 26 Apr 2020 22:21:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726349AbgDZWU7 (ORCPT ); Sun, 26 Apr 2020 18:20:59 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:47482 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbgDZWU6 (ORCPT ); Sun, 26 Apr 2020 18:20:58 -0400 Received: from dread.disaster.area (pa49-195-157-175.pa.nsw.optusnet.com.au [49.195.157.175]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 3F5B8821542; Mon, 27 Apr 2020 08:20:54 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jSpdu-0008Lc-3Y; Mon, 27 Apr 2020 08:20:54 +1000 Date: Mon, 27 Apr 2020 08:20:54 +1000 From: Dave Chinner To: Guoqing Jiang Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, willy@infradead.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Subject: Re: [RFC PATCH 3/9] btrfs: use set/clear_fs_page_private Message-ID: <20200426222054.GA2005@dread.disaster.area> References: <20200426214925.10970-1-guoqing.jiang@cloud.ionos.com> <20200426214925.10970-4-guoqing.jiang@cloud.ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200426214925.10970-4-guoqing.jiang@cloud.ionos.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=QIgWuTDL c=1 sm=1 tr=0 a=ONQRW0k9raierNYdzxQi9Q==:117 a=ONQRW0k9raierNYdzxQi9Q==:17 a=kj9zAlcOel0A:10 a=cl8xLZFz6L8A:10 a=FOH2dFAWAAAA:8 a=maIFttP_AAAA:8 a=iox4zFpeAAAA:8 a=VwQbUJbxAAAA:8 a=UgJECxHJAAAA:8 a=7-415B0cAAAA:8 a=MCBEIW9Q5ncSm9xiMmgA:9 a=CjuIK1q_8ugA:10 a=i3VuKzQdj-NEYjvDI-p3:22 a=qR24C9TJY6iBuJVj_x8Y:22 a=WzC6qhA0u3u7Ye7llzcV:22 a=AjGcO6oz07-iQ99wixmX:22 a=-El7cUbtino8hM1DCn8D:22 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sun, Apr 26, 2020 at 11:49:19PM +0200, Guoqing Jiang wrote: > Since the new pair function is introduced, we can call them to clean the > code in btrfs. > > Cc: Chris Mason > Cc: Josef Bacik > Cc: David Sterba > Cc: linux-btrfs@vger.kernel.org > Signed-off-by: Guoqing Jiang .... > void set_page_extent_mapped(struct page *page) > { > - if (!PagePrivate(page)) { > - SetPagePrivate(page); > - get_page(page); > - set_page_private(page, EXTENT_PAGE_PRIVATE); > - } > + if (!PagePrivate(page)) > + set_fs_page_private(page, (void *)EXTENT_PAGE_PRIVATE); Change the definition of EXTENT_PAGE_PRIVATE so the cast is not needed? Nothing ever reads EXTENT_PAGE_PRIVATE; it's only there to set the private flag for other code to check and release the extent mapping reference to the page... > @@ -8331,11 +8328,9 @@ static int btrfs_migratepage(struct address_space *mapping, > > if (page_has_private(page)) { > ClearPagePrivate(page); > - get_page(newpage); > - set_page_private(newpage, page_private(page)); > + set_fs_page_private(newpage, (void *)page_private(page)); > set_page_private(page, 0); > put_page(page); > - SetPagePrivate(newpage); > } This is just: set_fs_page_private(newpage, clear_fs_page_private(page)); Cheers, Dave. -- Dave Chinner david@fromorbit.com