From: Dave Chinner <david@fromorbit.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
hch@infradead.org, Mike Marshall <hubcap@omnibond.com>,
Martin Brandenburg <martin@omnibond.com>,
devel@lists.orangefs.org
Subject: Re: [RFC PATCH 8/9] orangefs: use set/clear_fs_page_private
Date: Mon, 27 Apr 2020 12:27:09 +1000 [thread overview]
Message-ID: <20200427022709.GC2005@dread.disaster.area> (raw)
In-Reply-To: <20200427001234.GB29705@bombadil.infradead.org>
On Sun, Apr 26, 2020 at 05:12:34PM -0700, Matthew Wilcox wrote:
> On Mon, Apr 27, 2020 at 08:24:55AM +1000, Dave Chinner wrote:
> > > @@ -460,17 +456,13 @@ static void orangefs_invalidatepage(struct page *page,
> > >
> > > if (offset == 0 && length == PAGE_SIZE) {
> > > kfree((struct orangefs_write_range *)page_private(page));
> > > - set_page_private(page, 0);
> > > - ClearPagePrivate(page);
> > > - put_page(page);
> > > + clear_fs_page_private(page);
> >
> > Ditto:
> > wr = clear_fs_page_private(page);
> > kfree(wr);
>
> You don't want to be as succinct as the btrfs change you suggested?
>
> kfree(clear_fs_page_private(page));
That could be done, yes. I was really just trying to point out the
use after free that was occurring here rather than write compact
code...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-04-27 2:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 21:49 [RFC PATCH 0/9] Introduce set/clear_fs_page_private to cleanup code Guoqing Jiang
2020-04-26 21:49 ` [RFC PATCH 1/9] include/linux/pagemap.h: introduce set/clear_fs_page_private Guoqing Jiang
2020-04-27 5:52 ` Christoph Hellwig
2020-04-27 8:10 ` Guoqing Jiang
2020-04-26 21:49 ` [RFC PATCH 2/9] md: remove __clear_page_buffers and use set/clear_fs_page_private Guoqing Jiang
2020-04-26 21:49 ` [RFC PATCH 3/9] btrfs: " Guoqing Jiang
2020-04-26 22:20 ` Dave Chinner
2020-04-27 5:54 ` Christoph Hellwig
2020-04-27 12:27 ` David Sterba
2020-04-27 8:14 ` Guoqing Jiang
2020-04-26 21:49 ` [RFC PATCH 4/9] fs/buffer.c: " Guoqing Jiang
2020-04-26 21:49 ` [RFC PATCH 5/9] f2fs: " Guoqing Jiang
2020-04-26 21:49 ` [f2fs-dev] " Guoqing Jiang
2020-04-27 2:22 ` Chao Yu
2020-04-27 2:22 ` [f2fs-dev] " Chao Yu
2020-04-27 8:10 ` Guoqing Jiang
2020-04-27 8:10 ` [f2fs-dev] " Guoqing Jiang
2020-04-26 21:49 ` [RFC PATCH 6/9] iomap: " Guoqing Jiang
2020-04-27 0:26 ` Matthew Wilcox
2020-04-27 5:55 ` Christoph Hellwig
2020-04-27 8:15 ` Guoqing Jiang
2020-04-27 8:15 ` Guoqing Jiang
2020-04-27 5:57 ` Christoph Hellwig
2020-04-27 8:12 ` Guoqing Jiang
2020-04-26 21:49 ` [RFC PATCH 7/9] ntfs: replace attach_page_buffers with set_fs_page_private Guoqing Jiang
2020-04-26 21:49 ` [RFC PATCH 8/9] orangefs: use set/clear_fs_page_private Guoqing Jiang
2020-04-26 22:24 ` Dave Chinner
2020-04-27 0:12 ` Matthew Wilcox
2020-04-27 2:27 ` Dave Chinner [this message]
2020-04-27 8:18 ` Guoqing Jiang
2020-04-27 2:58 ` Gao Xiang
2020-04-27 3:27 ` Gao Xiang
2020-04-26 21:49 ` [RFC PATCH 9/9] buffer_head.h: remove attach_page_buffers Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427022709.GC2005@dread.disaster.area \
--to=david@fromorbit.com \
--cc=devel@lists.orangefs.org \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=hch@infradead.org \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.