From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66160C54EEB for ; Mon, 27 Apr 2020 17:44:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4314D21655 for ; Mon, 27 Apr 2020 17:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588009474; bh=ZaQ6rn/s8Kxlhe/QZALln6lZXSTb4k8n2GRkZCZBmgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qe94TuPbrxAf8g/p2UQdePdEZILaz65tv8qriug0ot843h5DymqZLkMplGLOuC+iO SPo95HKURmBQ8YKBjkStwD1QlDC1uwreM5WLxpvxJgpw1ui7Xhf5zp8wltt1NYf30G qRf/PyS1VKRLkzcs2ltdbVna6N7WY2aJKJaLA0FQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbgD0Roa (ORCPT ); Mon, 27 Apr 2020 13:44:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:53032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbgD0Roa (ORCPT ); Mon, 27 Apr 2020 13:44:30 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E43321556; Mon, 27 Apr 2020 17:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588009470; bh=ZaQ6rn/s8Kxlhe/QZALln6lZXSTb4k8n2GRkZCZBmgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jMFO2+XnqLry1pIniBTURC2gvN/tKbjFoUkcjrP4kTyckpzL63R1QvPw+LlJzAsjM w9RmIa3QOhKcAnm8ydbtxKubMmPAJjc6+x8mIKbBK7Ys5H3bbIXR5BhxaixwpfZg0m RK1NeLYmU2ZSqu0FlSlslEJG3G0I0IOuMbScRvwg= Date: Mon, 27 Apr 2020 18:44:27 +0100 From: Mark Brown To: Michael Walle Cc: Thomas Gleixner , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Jason Cooper , Marc Zyngier , Greg Kroah-Hartman Subject: Re: [PATCH v3 06/16] irqchip: add sl28cpld interrupt controller support Message-ID: <20200427174427.GE4383@sirena.org.uk> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-7-michael@walle.cc> <87pnbtqhr1.fsf@nanos.tec.linutronix.de> <87f141bce0a4fda04b550647306be296@walle.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nHwqXXcoX0o6fKCv" Content-Disposition: inline In-Reply-To: <87f141bce0a4fda04b550647306be296@walle.cc> X-Cookie: If your bread is stale, make toast. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org --nHwqXXcoX0o6fKCv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 27, 2020 at 07:40:11PM +0200, Michael Walle wrote: > IRQF_ONESHOT, because its is a threaded interrupt with no primary > handler. But I just noticed, that regmap-irq will also set the > IRQF_ONESHOT. But that the commit 09cadf6e088b ("regmap-irq: > set IRQF_ONESHOT flag to ensure IRQ request") reads like it is > just there to be sure. So I don't know if it should also be set > here. Looking at the changelog there the "we can't be sure" bit is that coccinelle couldn't follow the flags through from the caller to make sure that IRQF_ONESHOT is set so we're just oring it in unconditionally. --nHwqXXcoX0o6fKCv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6nGfoACgkQJNaLcl1U h9Bhuwf+MMHsfmI2RDYY6qZJmxPEgyN6UpeiPwIpozVnZsA0/TQuDxAvV7Iu9PfO +h9DTbgF3GzRsw9kiWlFgxriyJsdUwvxpYGjS3Rdr2HEWv275fEurdRRXceeeSHZ w5PoR+ALv2rs+6UVVekmkK3Ht9/eJlVGJyLEYOfddcXTjTs/eezYWZrFNKaLfETD fP1XXLYorJDv1ovH/P6R6zK+3aunlvBdBHIoQCSh5GoHkAAyNNhayWdKZX1BsIqA 2bc5gQ2WCk83As3jtjwuDiPJRhETrcQT3y/1F7KDxn+SqRE5V51fQiwvbpLtGHsc XKfax9UH35Ornk7702asjugdC5kd9g== =+BYw -----END PGP SIGNATURE----- --nHwqXXcoX0o6fKCv-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v3 06/16] irqchip: add sl28cpld interrupt controller support Date: Mon, 27 Apr 2020 18:44:27 +0100 Message-ID: <20200427174427.GE4383@sirena.org.uk> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-7-michael@walle.cc> <87pnbtqhr1.fsf@nanos.tec.linutronix.de> <87f141bce0a4fda04b550647306be296@walle.cc> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nHwqXXcoX0o6fKCv" Return-path: Content-Disposition: inline In-Reply-To: <87f141bce0a4fda04b550647306be296-QKn5cuLxLXY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michael Walle Cc: Thomas Gleixner , Andy Shevchenko , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Jason List-Id: linux-pwm@vger.kernel.org --nHwqXXcoX0o6fKCv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 27, 2020 at 07:40:11PM +0200, Michael Walle wrote: > IRQF_ONESHOT, because its is a threaded interrupt with no primary > handler. But I just noticed, that regmap-irq will also set the > IRQF_ONESHOT. But that the commit 09cadf6e088b ("regmap-irq: > set IRQF_ONESHOT flag to ensure IRQ request") reads like it is > just there to be sure. So I don't know if it should also be set > here. Looking at the changelog there the "we can't be sure" bit is that coccinelle couldn't follow the flags through from the caller to make sure that IRQF_ONESHOT is set so we're just oring it in unconditionally. --nHwqXXcoX0o6fKCv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6nGfoACgkQJNaLcl1U h9Bhuwf+MMHsfmI2RDYY6qZJmxPEgyN6UpeiPwIpozVnZsA0/TQuDxAvV7Iu9PfO +h9DTbgF3GzRsw9kiWlFgxriyJsdUwvxpYGjS3Rdr2HEWv275fEurdRRXceeeSHZ w5PoR+ALv2rs+6UVVekmkK3Ht9/eJlVGJyLEYOfddcXTjTs/eezYWZrFNKaLfETD fP1XXLYorJDv1ovH/P6R6zK+3aunlvBdBHIoQCSh5GoHkAAyNNhayWdKZX1BsIqA 2bc5gQ2WCk83As3jtjwuDiPJRhETrcQT3y/1F7KDxn+SqRE5V51fQiwvbpLtGHsc XKfax9UH35Ornk7702asjugdC5kd9g== =+BYw -----END PGP SIGNATURE----- --nHwqXXcoX0o6fKCv-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37143C4CECC for ; Mon, 27 Apr 2020 17:44:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0532B21655 for ; Mon, 27 Apr 2020 17:44:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q6mOx089"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jMFO2+Xn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0532B21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7oJjCc++XhZGu67QBmk5jnnzjqaE1xQ/ElZ1To72giQ=; b=Q6mOx089MOeiIm08FZSn9RQHb f4OW22zN7Qab4+46NiPmnEU+U8LvbxY19krVCVamTTiZ/dSwzjWw29dkQilu4NFcU6Zeo8Dx/rj/d G7vvGUjsq/IYRPjiWKMUcNKHBG+BO8bzI5f8E5GMxvqAyb3bV8MsrmETR3ygbIljgK7JLUPUtNJ8E m8R8S78evKelUROYpSl7Sx0+ZWAdwe5VW101Rvo1uwtAtLgrfYbzFEQl0MvmHZ3XHZ8BVItqIN0GJ FBcBORiWjIVKWfRKxvFKNzhL9uNjt0NmyCa4dHsLFbeZDVBRROYoJQidl56m/noavMEvKJxWiCJ0x KTEVqx6CQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT7o1-0001vS-FI; Mon, 27 Apr 2020 17:44:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT7ny-0001uQ-DU for linux-arm-kernel@lists.infradead.org; Mon, 27 Apr 2020 17:44:31 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E43321556; Mon, 27 Apr 2020 17:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588009470; bh=ZaQ6rn/s8Kxlhe/QZALln6lZXSTb4k8n2GRkZCZBmgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jMFO2+XnqLry1pIniBTURC2gvN/tKbjFoUkcjrP4kTyckpzL63R1QvPw+LlJzAsjM w9RmIa3QOhKcAnm8ydbtxKubMmPAJjc6+x8mIKbBK7Ys5H3bbIXR5BhxaixwpfZg0m RK1NeLYmU2ZSqu0FlSlslEJG3G0I0IOuMbScRvwg= Date: Mon, 27 Apr 2020 18:44:27 +0100 From: Mark Brown To: Michael Walle Subject: Re: [PATCH v3 06/16] irqchip: add sl28cpld interrupt controller support Message-ID: <20200427174427.GE4383@sirena.org.uk> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-7-michael@walle.cc> <87pnbtqhr1.fsf@nanos.tec.linutronix.de> <87f141bce0a4fda04b550647306be296@walle.cc> MIME-Version: 1.0 In-Reply-To: <87f141bce0a4fda04b550647306be296@walle.cc> X-Cookie: If your bread is stale, make toast. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_104430_486288_547A75BA X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , Lee Jones , Jason Cooper , Andy Shevchenko , Marc Zyngier , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Guenter Roeck , devicetree@vger.kernel.org, Jean Delvare , linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org, Rob Herring , Thomas Gleixner , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Li Yang , Shawn Guo Content-Type: multipart/mixed; boundary="===============0844617833613048829==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0844617833613048829== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nHwqXXcoX0o6fKCv" Content-Disposition: inline --nHwqXXcoX0o6fKCv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 27, 2020 at 07:40:11PM +0200, Michael Walle wrote: > IRQF_ONESHOT, because its is a threaded interrupt with no primary > handler. But I just noticed, that regmap-irq will also set the > IRQF_ONESHOT. But that the commit 09cadf6e088b ("regmap-irq: > set IRQF_ONESHOT flag to ensure IRQ request") reads like it is > just there to be sure. So I don't know if it should also be set > here. Looking at the changelog there the "we can't be sure" bit is that coccinelle couldn't follow the flags through from the caller to make sure that IRQF_ONESHOT is set so we're just oring it in unconditionally. --nHwqXXcoX0o6fKCv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6nGfoACgkQJNaLcl1U h9Bhuwf+MMHsfmI2RDYY6qZJmxPEgyN6UpeiPwIpozVnZsA0/TQuDxAvV7Iu9PfO +h9DTbgF3GzRsw9kiWlFgxriyJsdUwvxpYGjS3Rdr2HEWv275fEurdRRXceeeSHZ w5PoR+ALv2rs+6UVVekmkK3Ht9/eJlVGJyLEYOfddcXTjTs/eezYWZrFNKaLfETD fP1XXLYorJDv1ovH/P6R6zK+3aunlvBdBHIoQCSh5GoHkAAyNNhayWdKZX1BsIqA 2bc5gQ2WCk83As3jtjwuDiPJRhETrcQT3y/1F7KDxn+SqRE5V51fQiwvbpLtGHsc XKfax9UH35Ornk7702asjugdC5kd9g== =+BYw -----END PGP SIGNATURE----- --nHwqXXcoX0o6fKCv-- --===============0844617833613048829== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0844617833613048829==--