From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Makefile: Only build dtc if needed
Date: Mon, 27 Apr 2020 14:59:54 -0400 [thread overview]
Message-ID: <20200427185954.GC4555@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ3hVq4-E7Kg2UD42brO1Tt=nVSuUzQ8eDsVSRNHWnhXmA@mail.gmail.com>
On Sun, Apr 26, 2020 at 06:34:48PM -0600, Simon Glass wrote:
> Hi Tom,
>
> On Sat, 26 Jan 2019 at 20:51, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Nov 13, 2018 at 03:43:07PM -0700, Simon Glass wrote:
> >
> > > At present U-Boot always builds dtc if CONFIG_OF_CONTROL is defined. This
> > > is wasteful when the system already has a suitable version available.
> > >
> > > Update the Makefile logic to build dtc only if the version available is
> > > too old.
> > >
> > > This saves about 3 seconds of CPU time on a clean build for me.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> >
> > In the case of new enough host dtc this then fails on sandbox_spl,
> > chromebook_minnie and others where we need to build
> > spl/dts/dt-platdata.c with a python import error over lacking _libfdt.
>
> I'm not sure if it has been long enough, but have the packages been
> updated to include pylibfdt?
>
> I'm sending a new version of this patch that checks for that.
I honestly don't know how far behind distributions lag here and then in
turn how old something is before we say "sorry, you can't build there
easily".
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200427/6137c54f/attachment.sig>
next prev parent reply other threads:[~2020-04-27 18:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 22:43 [U-Boot] [PATCH] Makefile: Only build dtc if needed Simon Glass
2018-11-13 22:50 ` Marek Vasut
2019-01-22 0:31 ` Simon Glass
2019-01-27 3:51 ` [U-Boot] " Tom Rini
2020-04-27 0:34 ` Simon Glass
2020-04-27 18:59 ` Tom Rini [this message]
2020-04-27 22:25 ` Simon Glass
2020-04-28 14:49 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427185954.GC4555@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.