From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EF7C4CECC for ; Mon, 27 Apr 2020 19:51:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5300206B8 for ; Mon, 27 Apr 2020 19:51:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5300206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=etezian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FE8289B27; Mon, 27 Apr 2020 19:51:20 +0000 (UTC) X-Greylist: delayed 69559 seconds by postgrey-1.36 at gabe; Mon, 27 Apr 2020 19:51:19 UTC Received: from 4.mo68.mail-out.ovh.net (4.mo68.mail-out.ovh.net [46.105.59.63]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40AB289B27 for ; Mon, 27 Apr 2020 19:51:19 +0000 (UTC) Received: from player735.ha.ovh.net (unknown [10.108.42.102]) by mo68.mail-out.ovh.net (Postfix) with ESMTP id 92B6D163D2C for ; Mon, 27 Apr 2020 21:51:16 +0200 (CEST) Received: from etezian.org (213-243-141-64.bb.dnainternet.fi [213.243.141.64]) (Authenticated sender: andi@etezian.org) by player735.ha.ovh.net (Postfix) with ESMTPSA id EECF511983FA2; Mon, 27 Apr 2020 19:51:13 +0000 (UTC) Date: Mon, 27 Apr 2020 22:51:12 +0300 From: Andi Shyti To: Chris Wilson Message-ID: <20200427195112.GA3168@jack.zhora.eu> References: <20200427085408.13879-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200427085408.13879-1-chris@chris-wilson.co.uk> X-Ovh-Tracer-Id: 4013551695345140233 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedrheelgddufeelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhguihcuufhhhihtihcuoegrnhguihesvghtvgiiihgrnhdrohhrgheqnecukfhppedtrddtrddtrddtpddvudefrddvgeefrddugedurdeigeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejfeehrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprghnughisegvthgviihirghnrdhorhhgpdhrtghpthhtohepihhnthgvlhdqghhfgieslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrgh Subject: Re: [Intel-gfx] [PATCH 1/9] drm/i915/gt: Sanitize GT first X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Chris, > We see that if the HW doesn't actually sleep, the HW may eat the poison > we set in its write-only HWSP during sanitize: > > intel_gt_resume.part.8: 0000:00:02.0 > __gt_unpark: 0000:00:02.0 > gt_sanitize: 0000:00:02.0 force:yes > process_csb: 0000:00:02.0 vcs0: cs-irq head=5, tail=90 > process_csb: 0000:00:02.0 vcs0: csb[0]: status=0x5a5a5a5a:0x5a5a5a5a > assert_pending_valid: Nothing pending for promotion! > > The CS TAIL pointer should have been reset by reset_csb_pointers(), so > in this case it is likely that we have read back from the CPU cache and > so we must clflush our control over that page. In doing so, push the > sanitisation to the start of the GT sequence so that our poisoning is > assuredly before we start talking to the HW. > > Signed-off-by: Chris Wilson Reviewed-by: Andi Shyti Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx