From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F59EC4CECC for ; Mon, 27 Apr 2020 20:09:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED0DD206D9 for ; Mon, 27 Apr 2020 20:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbgD0UJJ convert rfc822-to-8bit (ORCPT ); Mon, 27 Apr 2020 16:09:09 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:58663 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgD0UJI (ORCPT ); Mon, 27 Apr 2020 16:09:08 -0400 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 94DB5240002; Mon, 27 Apr 2020 20:09:04 +0000 (UTC) Date: Mon, 27 Apr 2020 22:09:03 +0200 From: Miquel Raynal To: "Gustavo A. R. Silva" Cc: linux-kernel@vger.kernel.org, Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Joe Perches Subject: Re: [PATCH v2 2/3] mtd: lpddr: Replace printk with pr_notice Message-ID: <20200427220903.5ad059d5@xps13> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, "Gustavo A. R. Silva" wrote on Mon, 27 Apr 2020 14:54:13 -0500: > pr_notice is preferred over printk. > > Also, coalesce formats as coalescing is part of coding-style: > "never break user-visible strings such as printk messages" > > Suggested-by: Joe Perches > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > - Coalesce formats and update changelog text, accordingly. > > include/linux/mtd/pfow.h | 27 +++++++++++---------------- > 1 file changed, 11 insertions(+), 16 deletions(-) > > diff --git a/include/linux/mtd/pfow.h b/include/linux/mtd/pfow.h > index c65d7a3be3c6..cd21c6768065 100644 > --- a/include/linux/mtd/pfow.h > +++ b/include/linux/mtd/pfow.h > @@ -127,31 +127,26 @@ static inline void print_drs_error(unsigned dsr) > int prog_status = (dsr & DSR_RPS) >> 8; > > if (!(dsr & DSR_AVAILABLE)) > - printk(KERN_NOTICE"DSR.15: (0) Device not Available\n"); > + pr_notice("DSR.15: (0) Device not Available\n"); > if ((prog_status & 0x03) == 0x03) > - printk(KERN_NOTICE"DSR.9,8: (11) Attempt to program invalid " > - "half with 41h command\n"); > + pr_notice("DSR.9,8: (11) Attempt to program invalid half with 41h command\n"); > else if (prog_status & 0x02) > - printk(KERN_NOTICE"DSR.9,8: (10) Object Mode Program attempt " > - "in region with Control Mode data\n"); > + pr_notice("DSR.9,8: (10) Object Mode Program attempt in region with Control Mode data\n"); > else if (prog_status & 0x01) > - printk(KERN_NOTICE"DSR.9,8: (01) Program attempt in region " > - "with Object Mode data\n"); > + pr_notice("DSR.9,8: (01) Program attempt in region with Object Mode data\n"); > if (!(dsr & DSR_READY_STATUS)) > - printk(KERN_NOTICE"DSR.7: (0) Device is Busy\n"); > + pr_notice("DSR.7: (0) Device is Busy\n"); > if (dsr & DSR_ESS) > - printk(KERN_NOTICE"DSR.6: (1) Erase Suspended\n"); > + pr_notice("DSR.6: (1) Erase Suspended\n"); > if (dsr & DSR_ERASE_STATUS) > - printk(KERN_NOTICE"DSR.5: (1) Erase/Blank check error\n"); > + pr_notice("DSR.5: (1) Erase/Blank check error\n"); > if (dsr & DSR_PROGRAM_STATUS) > - printk(KERN_NOTICE"DSR.4: (1) Program Error\n"); > + pr_notice("DSR.4: (1) Program Error\n"); > if (dsr & DSR_VPPS) > - printk(KERN_NOTICE"DSR.3: (1) Vpp low detect, operation " > - "aborted\n"); > + pr_notice("DSR.3: (1) Vpp low detect, operation aborted\n"); > if (dsr & DSR_PSS) > - printk(KERN_NOTICE"DSR.2: (1) Program suspended\n"); > + pr_notice("DSR.2: (1) Program suspended\n"); > if (dsr & DSR_DPS) > - printk(KERN_NOTICE"DSR.1: (1) Aborted Erase/Program attempt " > - "on locked block\n"); > + pr_notice("DSR.1: (1) Aborted Erase/Program attempt on locked block\n"); > } > #endif /* __LINUX_MTD_PFOW_H */ Reviewed-by: Miquel Raynal Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F3F0C54EEB for ; Mon, 27 Apr 2020 20:09:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BE9C206D9 for ; Mon, 27 Apr 2020 20:09:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WTHdiY6w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BE9C206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ihdwepWtMul7rwobo6kBdRfAF+TAsQbNs02VJpSMNI=; b=WTHdiY6wDh4WCu xmONVoEXE9B+lj5+43cw+DgzMMvrVLKxtjyaaQ3MSw/y/GbxqgqPb7HLLVTc1YaCOOSVJs/YUd/HY IYTOA7+9LnuKdtd/emEzni9yygnJr+R/9j/xqg3H+c/FshQHVZtL/aPKPRU2Qi8w2IYn9j2rL6H6l Uh3R+obIcbzk3TVgdaACRCifdsGRtFEgu82iZ9782uFhNTuNU8BwnhUt8FuEjvsByTLipNVnX2Trr ZItoE965RSo8BcyRQ+rofttUlyjfJCz67H2MHhKBsOoOQ3uHhtDHu5rH4BBFi+MNPqHd7BINv88bG mBs4dMQBGpkKCA9WCbxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTA3y-00020V-VY; Mon, 27 Apr 2020 20:09:10 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTA3w-0001zX-1D for linux-mtd@lists.infradead.org; Mon, 27 Apr 2020 20:09:09 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 94DB5240002; Mon, 27 Apr 2020 20:09:04 +0000 (UTC) Date: Mon, 27 Apr 2020 22:09:03 +0200 From: Miquel Raynal To: "Gustavo A. R. Silva" Subject: Re: [PATCH v2 2/3] mtd: lpddr: Replace printk with pr_notice Message-ID: <20200427220903.5ad059d5@xps13> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_130908_204769_6B635E72 X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joe Perches , Richard Weinberger , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Vignesh Raghavendra Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgR3VzdGF2bywKCiJHdXN0YXZvIEEuIFIuIFNpbHZhIiA8Z3VzdGF2b0BlbWJlZGRlZG9yLmNv bT4gd3JvdGUgb24gTW9uLCAyNyBBcHIKMjAyMCAxNDo1NDoxMyAtMDUwMDoKCj4gcHJfbm90aWNl IGlzIHByZWZlcnJlZCBvdmVyIHByaW50ay4KPiAKPiBBbHNvLCBjb2FsZXNjZSBmb3JtYXRzIGFz IGNvYWxlc2NpbmcgaXMgcGFydCBvZiBjb2Rpbmctc3R5bGU6Cj4gIm5ldmVyIGJyZWFrIHVzZXIt dmlzaWJsZSBzdHJpbmdzIHN1Y2ggYXMgcHJpbnRrIG1lc3NhZ2VzIgo+IAo+IFN1Z2dlc3RlZC1i eTogSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZv IEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgo+IC0tLQo+IENoYW5nZXMgaW4g djI6Cj4gIC0gQ29hbGVzY2UgZm9ybWF0cyBhbmQgdXBkYXRlIGNoYW5nZWxvZyB0ZXh0LCBhY2Nv cmRpbmdseS4KPiAKPiAgaW5jbHVkZS9saW51eC9tdGQvcGZvdy5oIHwgMjcgKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxNiBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9tdGQvcGZvdy5oIGIv aW5jbHVkZS9saW51eC9tdGQvcGZvdy5oCj4gaW5kZXggYzY1ZDdhM2JlM2M2Li5jZDIxYzY3Njgw NjUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9tdGQvcGZvdy5oCj4gKysrIGIvaW5jbHVk ZS9saW51eC9tdGQvcGZvdy5oCj4gQEAgLTEyNywzMSArMTI3LDI2IEBAIHN0YXRpYyBpbmxpbmUg dm9pZCBwcmludF9kcnNfZXJyb3IodW5zaWduZWQgZHNyKQo+ICAJaW50IHByb2dfc3RhdHVzID0g KGRzciAmIERTUl9SUFMpID4+IDg7Cj4gIAo+ICAJaWYgKCEoZHNyICYgRFNSX0FWQUlMQUJMRSkp Cj4gLQkJcHJpbnRrKEtFUk5fTk9USUNFIkRTUi4xNTogKDApIERldmljZSBub3QgQXZhaWxhYmxl XG4iKTsKPiArCQlwcl9ub3RpY2UoIkRTUi4xNTogKDApIERldmljZSBub3QgQXZhaWxhYmxlXG4i KTsKPiAgCWlmICgocHJvZ19zdGF0dXMgJiAweDAzKSA9PSAweDAzKQo+IC0JCXByaW50ayhLRVJO X05PVElDRSJEU1IuOSw4OiAoMTEpIEF0dGVtcHQgdG8gcHJvZ3JhbSBpbnZhbGlkICIKPiAtCQkJ CQkJImhhbGYgd2l0aCA0MWggY29tbWFuZFxuIik7Cj4gKwkJcHJfbm90aWNlKCJEU1IuOSw4OiAo MTEpIEF0dGVtcHQgdG8gcHJvZ3JhbSBpbnZhbGlkIGhhbGYgd2l0aCA0MWggY29tbWFuZFxuIik7 Cj4gIAllbHNlIGlmIChwcm9nX3N0YXR1cyAmIDB4MDIpCj4gLQkJcHJpbnRrKEtFUk5fTk9USUNF IkRTUi45LDg6ICgxMCkgT2JqZWN0IE1vZGUgUHJvZ3JhbSBhdHRlbXB0ICIKPiAtCQkJCQkiaW4g cmVnaW9uIHdpdGggQ29udHJvbCBNb2RlIGRhdGFcbiIpOwo+ICsJCXByX25vdGljZSgiRFNSLjks ODogKDEwKSBPYmplY3QgTW9kZSBQcm9ncmFtIGF0dGVtcHQgaW4gcmVnaW9uIHdpdGggQ29udHJv bCBNb2RlIGRhdGFcbiIpOwo+ICAJZWxzZSBpZiAocHJvZ19zdGF0dXMgJiAgMHgwMSkKPiAtCQlw cmludGsoS0VSTl9OT1RJQ0UiRFNSLjksODogKDAxKSBQcm9ncmFtIGF0dGVtcHQgaW4gcmVnaW9u ICIKPiAtCQkJCQkJIndpdGggT2JqZWN0IE1vZGUgZGF0YVxuIik7Cj4gKwkJcHJfbm90aWNlKCJE U1IuOSw4OiAoMDEpIFByb2dyYW0gYXR0ZW1wdCBpbiByZWdpb24gd2l0aCBPYmplY3QgTW9kZSBk YXRhXG4iKTsKPiAgCWlmICghKGRzciAmIERTUl9SRUFEWV9TVEFUVVMpKQo+IC0JCXByaW50ayhL RVJOX05PVElDRSJEU1IuNzogKDApIERldmljZSBpcyBCdXN5XG4iKTsKPiArCQlwcl9ub3RpY2Uo IkRTUi43OiAoMCkgRGV2aWNlIGlzIEJ1c3lcbiIpOwo+ICAJaWYgKGRzciAmIERTUl9FU1MpCj4g LQkJcHJpbnRrKEtFUk5fTk9USUNFIkRTUi42OiAoMSkgRXJhc2UgU3VzcGVuZGVkXG4iKTsKPiAr CQlwcl9ub3RpY2UoIkRTUi42OiAoMSkgRXJhc2UgU3VzcGVuZGVkXG4iKTsKPiAgCWlmIChkc3Ig JiBEU1JfRVJBU0VfU1RBVFVTKQo+IC0JCXByaW50ayhLRVJOX05PVElDRSJEU1IuNTogKDEpIEVy YXNlL0JsYW5rIGNoZWNrIGVycm9yXG4iKTsKPiArCQlwcl9ub3RpY2UoIkRTUi41OiAoMSkgRXJh c2UvQmxhbmsgY2hlY2sgZXJyb3JcbiIpOwo+ICAJaWYgKGRzciAmIERTUl9QUk9HUkFNX1NUQVRV UykKPiAtCQlwcmludGsoS0VSTl9OT1RJQ0UiRFNSLjQ6ICgxKSBQcm9ncmFtIEVycm9yXG4iKTsK PiArCQlwcl9ub3RpY2UoIkRTUi40OiAoMSkgUHJvZ3JhbSBFcnJvclxuIik7Cj4gIAlpZiAoZHNy ICYgRFNSX1ZQUFMpCj4gLQkJcHJpbnRrKEtFUk5fTk9USUNFIkRTUi4zOiAoMSkgVnBwIGxvdyBk ZXRlY3QsIG9wZXJhdGlvbiAiCj4gLQkJCQkJImFib3J0ZWRcbiIpOwo+ICsJCXByX25vdGljZSgi RFNSLjM6ICgxKSBWcHAgbG93IGRldGVjdCwgb3BlcmF0aW9uIGFib3J0ZWRcbiIpOwo+ICAJaWYg KGRzciAmIERTUl9QU1MpCj4gLQkJcHJpbnRrKEtFUk5fTk9USUNFIkRTUi4yOiAoMSkgUHJvZ3Jh bSBzdXNwZW5kZWRcbiIpOwo+ICsJCXByX25vdGljZSgiRFNSLjI6ICgxKSBQcm9ncmFtIHN1c3Bl bmRlZFxuIik7Cj4gIAlpZiAoZHNyICYgRFNSX0RQUykKPiAtCQlwcmludGsoS0VSTl9OT1RJQ0Ui RFNSLjE6ICgxKSBBYm9ydGVkIEVyYXNlL1Byb2dyYW0gYXR0ZW1wdCAiCj4gLQkJCQkJIm9uIGxv Y2tlZCBibG9ja1xuIik7Cj4gKwkJcHJfbm90aWNlKCJEU1IuMTogKDEpIEFib3J0ZWQgRXJhc2Uv UHJvZ3JhbSBhdHRlbXB0IG9uIGxvY2tlZCBibG9ja1xuIik7Cj4gIH0KPiAgI2VuZGlmIC8qIF9f TElOVVhfTVREX1BGT1dfSCAqLwoKClJldmlld2VkLWJ5OiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwu cmF5bmFsQGJvb3RsaW4uY29tPgoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9u IG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LW10ZC8K