From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 27 Apr 2020 22:49:30 +0200 Subject: [Buildroot] [PATCH] package/tzdata: do extract to get the license file In-Reply-To: <20200427203608.17609-1-yann.morin.1998@free.fr> References: <20200427203608.17609-1-yann.morin.1998@free.fr> Message-ID: <20200427224930.7bfcbf13@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Mon, 27 Apr 2020 22:36:08 +0200 "Yann E. MORIN" wrote: > Back in 2014, about 6 years ago now, in my inifinite wisdom, I > decided that extracting the tzdata source was not nwcessary for > the target variant, because we would be installing the files > generated by the host variant, in commit 7aad5daa5d (package/tzdata: > only compile the zoneinfo once). > > However, that did not account for the fact that we would eventually > like to have the licensing information for tzdata, later added in > 2019, in commit 60889ccdf0 (package/tzdata: bump to version 2019b). > > However, that last comit only added the license file to the host > variant, without explanations why that was so. It turns out that the > reason it was not added to the target variant is, probably, that he > source code for the target variant is not extracted, and thus saving > the license file fails. > > But we really want the license file for what goes on into the target. > > So, do extract the source code for the target variant, even if only to > get the license file. > > Signed-off-by: Yann E. MORIN > Cc: Richard Braun > Cc: Martin Bark > Cc: Christopher McCrory > --- > package/tzdata/tzdata.mk | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com