All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Poirier <bpoirier@cumulusnetworks.com>
To: netdev@vger.kernel.org
Subject: [PATCH iproute2 1/7] bridge: Use the same flag names in input and output
Date: Tue, 28 Apr 2020 08:50:45 +0900	[thread overview]
Message-ID: <20200427235051.250058-2-bpoirier@cumulusnetworks.com> (raw)
In-Reply-To: <20200427235051.250058-1-bpoirier@cumulusnetworks.com>

Output the same names for vlan flags as the ones accepted in command input.

Signed-off-by: Benjamin Poirier <bpoirier@cumulusnetworks.com>
---
 bridge/vlan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bridge/vlan.c b/bridge/vlan.c
index 205851e4..08b19897 100644
--- a/bridge/vlan.c
+++ b/bridge/vlan.c
@@ -398,10 +398,10 @@ static void print_vlan_flags(__u16 flags)
 
 	open_json_array(PRINT_JSON, "flags");
 	if (flags & BRIDGE_VLAN_INFO_PVID)
-		print_string(PRINT_ANY, NULL, " %s", "PVID");
+		print_string(PRINT_ANY, NULL, " %s", "pvid");
 
 	if (flags & BRIDGE_VLAN_INFO_UNTAGGED)
-		print_string(PRINT_ANY, NULL, " %s", "Egress Untagged");
+		print_string(PRINT_ANY, NULL, " %s", "untagged");
 	close_json_array(PRINT_JSON, NULL);
 }
 
-- 
2.26.0


  reply	other threads:[~2020-04-27 23:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 23:50 [PATCH iproute2 0/7] bridge vlan output fixes Benjamin Poirier
2020-04-27 23:50 ` Benjamin Poirier [this message]
2020-04-29 15:12   ` [PATCH iproute2 1/7] bridge: Use the same flag names in input and output Roopa Prabhu
2020-04-30  0:22     ` Benjamin Poirier
2020-04-30  0:58       ` Nikolay Aleksandrov
2020-04-27 23:50 ` [PATCH iproute2 2/7] bridge: Use consistent column names in vlan output Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 3/7] bridge: Fix typo Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 4/7] bridge: Fix output with empty vlan lists Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 5/7] json_print: Return number of characters printed Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 6/7] bridge: Align output columns Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 7/7] Replace open-coded instances of print_nl() Benjamin Poirier
2020-04-30  5:35 ` [PATCH iproute2 0/7] bridge vlan output fixes Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427235051.250058-2-bpoirier@cumulusnetworks.com \
    --to=bpoirier@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.