From: Kejia Hu <kejia.hu@codethink.co.uk>
To: agross@kernel.org, bjorn.andersson@linaro.org, sre@kernel.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: Kejia Hu <kejia.hu@codethink.co.uk>
Subject: [PATCH] power: reset: qcom-pon: reg write mask depends on pon generation
Date: Tue, 28 Apr 2020 08:04:37 +0100 [thread overview]
Message-ID: <20200428070437.14016-1-kejia.hu@codethink.co.uk> (raw)
Instead of hardcode the mask, it should be depends
on which generation of pon it was.
Signed-off-by: Kejia Hu <kejia.hu@codethink.co.uk>
---
drivers/power/reset/qcom-pon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
index 22a743a0bf28..4a688741a88a 100644
--- a/drivers/power/reset/qcom-pon.c
+++ b/drivers/power/reset/qcom-pon.c
@@ -34,7 +34,8 @@ static int pm8916_reboot_mode_write(struct reboot_mode_driver *reboot,
ret = regmap_update_bits(pon->regmap,
pon->baseaddr + PON_SOFT_RB_SPARE,
- 0xfc, magic << pon->reason_shift);
+ GENMASK(7, pon->reason_shift),
+ magic << pon->reason_shift);
if (ret < 0)
dev_err(pon->dev, "update reboot mode bits failed\n");
--
2.11.0
next reply other threads:[~2020-04-28 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 7:04 Kejia Hu [this message]
2020-04-28 19:18 ` [PATCH] power: reset: qcom-pon: reg write mask depends on pon generation Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428070437.14016-1-kejia.hu@codethink.co.uk \
--to=kejia.hu@codethink.co.uk \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.