From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E00C83000 for ; Tue, 28 Apr 2020 14:03:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB33A206C0 for ; Tue, 28 Apr 2020 14:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727918AbgD1ODB (ORCPT ); Tue, 28 Apr 2020 10:03:01 -0400 Received: from verein.lst.de ([213.95.11.211]:56414 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726868AbgD1ODA (ORCPT ); Tue, 28 Apr 2020 10:03:00 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 7569968CEC; Tue, 28 Apr 2020 16:02:57 +0200 (CEST) Date: Tue, 28 Apr 2020 16:02:57 +0200 From: Christoph Hellwig To: Marek Szyprowski Cc: dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Robin Murphy , Bartlomiej Zolnierkiewicz , Sumit Semwal , Benjamin Gaignard , intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, David Airlie , Daniel Vetter Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200428140257.GA3433@lst.de> References: <20200428132005.21424-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > a proper sg_table entries and call respective DMA-mapping functions > and adapt current code to it That sounds reasonable to me. Those could be pretty trivial wrappers. > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > which one refers to which part of the scatterlist; I'm open for > other names for those entries nr_cpu_ents and nr_dma_ents might be better names, but it still would be a whole lot of churn for little gain. I think just good wrappers like suggested above might be more helpful. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 518B2C83001 for ; Tue, 28 Apr 2020 14:03:07 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21865206C0 for ; Tue, 28 Apr 2020 14:03:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21865206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id EEDD6881BB; Tue, 28 Apr 2020 14:03:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OxbQb1tJeZwn; Tue, 28 Apr 2020 14:03:06 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 36B228817D; Tue, 28 Apr 2020 14:03:06 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1D381C0863; Tue, 28 Apr 2020 14:03:06 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id EE3C0C0172 for ; Tue, 28 Apr 2020 14:03:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E49C486366 for ; Tue, 28 Apr 2020 14:03:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id irLj1HjDWDPV for ; Tue, 28 Apr 2020 14:03:02 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 81BC286365 for ; Tue, 28 Apr 2020 14:03:02 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 7569968CEC; Tue, 28 Apr 2020 16:02:57 +0200 (CEST) Date: Tue, 28 Apr 2020 16:02:57 +0200 From: Christoph Hellwig To: Marek Szyprowski Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200428140257.GA3433@lst.de> References: <20200428132005.21424-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Daniel Vetter , Bartlomiej Zolnierkiewicz , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sumit Semwal , linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, Benjamin Gaignard , Robin Murphy , Christoph Hellwig , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > a proper sg_table entries and call respective DMA-mapping functions > and adapt current code to it That sounds reasonable to me. Those could be pretty trivial wrappers. > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > which one refers to which part of the scatterlist; I'm open for > other names for those entries nr_cpu_ents and nr_dma_ents might be better names, but it still would be a whole lot of churn for little gain. I think just good wrappers like suggested above might be more helpful. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECBCAC83000 for ; Tue, 28 Apr 2020 14:03:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3CB4206C0 for ; Tue, 28 Apr 2020 14:03:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bl2BuUJn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3CB4206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WQqf3guOfxy0mztWsJLYPQssxCCmTDBvwNfzZfIIBTU=; b=bl2BuUJnM65JXw 5E5znqHdvOUVt/eEwI4TqltXt60mVZpvXR1Lv0kITct32/RA+n8/ENfGWGsJQnJZ3Sc2WH/udGjNU gdtOqX3n/YNvzUUUk2TBP8spMvBUNeuG7w68GdJw+Jf3sw6BLWp8cNwjvoK1+gnv3ooO5R4yth2sv lGfm177jxoIgkyzsEHvdxxvElxXFnyUZSAe0lycx72fUC0KaVoFYR3A/GOI30wOZcfL0BtMklKryp UqAE4+lVUwpci27dhbhSKaCknE6Ev7HFsD3URgkZIfm8t2fM/FrpEcf+6TijUUebcCtpJE8ECUA0q YFolrO9HF1TSQOuSf2DA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTQpE-0006cP-Cn; Tue, 28 Apr 2020 14:03:04 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTQpB-0006bT-IE for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2020 14:03:03 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 7569968CEC; Tue, 28 Apr 2020 16:02:57 +0200 (CEST) Date: Tue, 28 Apr 2020 16:02:57 +0200 From: Christoph Hellwig To: Marek Szyprowski Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200428140257.GA3433@lst.de> References: <20200428132005.21424-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200428_070301_747023_CAA6BAF1 X-CRM114-Status: UNSURE ( 8.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Bartlomiej Zolnierkiewicz , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sumit Semwal , linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, Benjamin Gaignard , Robin Murphy , Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > a proper sg_table entries and call respective DMA-mapping functions > and adapt current code to it That sounds reasonable to me. Those could be pretty trivial wrappers. > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > which one refers to which part of the scatterlist; I'm open for > other names for those entries nr_cpu_ents and nr_dma_ents might be better names, but it still would be a whole lot of churn for little gain. I think just good wrappers like suggested above might be more helpful. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55869C83008 for ; Tue, 28 Apr 2020 14:03:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 304A4206C0 for ; Tue, 28 Apr 2020 14:03:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 304A4206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C91406E478; Tue, 28 Apr 2020 14:03:02 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA9066E443; Tue, 28 Apr 2020 14:03:00 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 7569968CEC; Tue, 28 Apr 2020 16:02:57 +0200 (CEST) Date: Tue, 28 Apr 2020 16:02:57 +0200 From: Christoph Hellwig To: Marek Szyprowski Message-ID: <20200428140257.GA3433@lst.de> References: <20200428132005.21424-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Intel-gfx] [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sumit Semwal , linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, Benjamin Gaignard , Robin Murphy , Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > a proper sg_table entries and call respective DMA-mapping functions > and adapt current code to it That sounds reasonable to me. Those could be pretty trivial wrappers. > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > which one refers to which part of the scatterlist; I'm open for > other names for those entries nr_cpu_ents and nr_dma_ents might be better names, but it still would be a whole lot of churn for little gain. I think just good wrappers like suggested above might be more helpful. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC041C83008 for ; Tue, 28 Apr 2020 14:10:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBE88206C0 for ; Tue, 28 Apr 2020 14:10:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBE88206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 36BBA6E4D0; Tue, 28 Apr 2020 14:10:12 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA9066E443; Tue, 28 Apr 2020 14:03:00 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 7569968CEC; Tue, 28 Apr 2020 16:02:57 +0200 (CEST) Date: Tue, 28 Apr 2020 16:02:57 +0200 From: Christoph Hellwig To: Marek Szyprowski Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200428140257.GA3433@lst.de> References: <20200428132005.21424-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Tue, 28 Apr 2020 14:10:10 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Bartlomiej Zolnierkiewicz , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sumit Semwal , linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, Benjamin Gaignard , Robin Murphy , Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > a proper sg_table entries and call respective DMA-mapping functions > and adapt current code to it That sounds reasonable to me. Those could be pretty trivial wrappers. > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > which one refers to which part of the scatterlist; I'm open for > other names for those entries nr_cpu_ents and nr_dma_ents might be better names, but it still would be a whole lot of churn for little gain. I think just good wrappers like suggested above might be more helpful. _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx