From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacopo Mondi Date: Tue, 28 Apr 2020 14:38:28 +0000 Subject: Re: [PATCH -next] drm/rcar-du: Fix return value check in rcar_du_cmm_init() Message-Id: <20200428143828.j7y57ll5drvs2rer@uno.localdomain> List-Id: References: <20200428141716.87958-1-weiyongjun1@huawei.com> In-Reply-To: <20200428141716.87958-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Jacopo Mondi , Laurent Pinchart Hello Wei, On Tue, Apr 28, 2020 at 02:17:16PM +0000, Wei Yongjun wrote: > In case of error, the function of_parse_phandle()/of_find_device_by_node() > returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test > > Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") > Signed-off-by: Wei Yongjun Correct indeed! Also -ENODEV seems appropriate to me as return value. Thanks! Acked-by: Jacopo Mondi > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 482329102f19..0da711d9b2f8 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -650,10 +650,10 @@ static int rcar_du_cmm_init(struct rcar_du_device *rcdu) > int ret; > > cmm = of_parse_phandle(np, "renesas,cmms", i); > - if (IS_ERR(cmm)) { > + if (!cmm) { > dev_err(rcdu->dev, > "Failed to parse 'renesas,cmms' property\n"); > - return PTR_ERR(cmm); > + return -ENODEV; > } > > if (!of_device_is_available(cmm)) { > @@ -663,10 +663,10 @@ static int rcar_du_cmm_init(struct rcar_du_device *rcdu) > } > > pdev = of_find_device_by_node(cmm); > - if (IS_ERR(pdev)) { > + if (!pdev) { > dev_err(rcdu->dev, "No device found for CMM%u\n", i); > of_node_put(cmm); > - return PTR_ERR(pdev); > + return -ENODEV; > } > > of_node_put(cmm); > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D89C83000 for ; Tue, 28 Apr 2020 14:35:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 294E1206C0 for ; Tue, 28 Apr 2020 14:35:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727122AbgD1OfY (ORCPT ); Tue, 28 Apr 2020 10:35:24 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:40365 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726868AbgD1OfY (ORCPT ); Tue, 28 Apr 2020 10:35:24 -0400 Received: from uno.localdomain (a-ur1-85.tin.it [212.216.150.148]) (Authenticated sender: jacopo@jmondi.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 7E94710001C; Tue, 28 Apr 2020 14:35:17 +0000 (UTC) Date: Tue, 28 Apr 2020 16:38:28 +0200 From: Jacopo Mondi To: Wei Yongjun Cc: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Jacopo Mondi , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] drm/rcar-du: Fix return value check in rcar_du_cmm_init() Message-ID: <20200428143828.j7y57ll5drvs2rer@uno.localdomain> References: <20200428141716.87958-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200428141716.87958-1-weiyongjun1@huawei.com> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello Wei, On Tue, Apr 28, 2020 at 02:17:16PM +0000, Wei Yongjun wrote: > In case of error, the function of_parse_phandle()/of_find_device_by_node() > returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test > > Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") > Signed-off-by: Wei Yongjun Correct indeed! Also -ENODEV seems appropriate to me as return value. Thanks! Acked-by: Jacopo Mondi > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 482329102f19..0da711d9b2f8 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -650,10 +650,10 @@ static int rcar_du_cmm_init(struct rcar_du_device *rcdu) > int ret; > > cmm = of_parse_phandle(np, "renesas,cmms", i); > - if (IS_ERR(cmm)) { > + if (!cmm) { > dev_err(rcdu->dev, > "Failed to parse 'renesas,cmms' property\n"); > - return PTR_ERR(cmm); > + return -ENODEV; > } > > if (!of_device_is_available(cmm)) { > @@ -663,10 +663,10 @@ static int rcar_du_cmm_init(struct rcar_du_device *rcdu) > } > > pdev = of_find_device_by_node(cmm); > - if (IS_ERR(pdev)) { > + if (!pdev) { > dev_err(rcdu->dev, "No device found for CMM%u\n", i); > of_node_put(cmm); > - return PTR_ERR(pdev); > + return -ENODEV; > } > > of_node_put(cmm); > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E43B8C83008 for ; Tue, 28 Apr 2020 14:53:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE1A5206B9 for ; Tue, 28 Apr 2020 14:53:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE1A5206B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jmondi.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14D156E7FA; Tue, 28 Apr 2020 14:53:24 +0000 (UTC) Received: from mslow2.mail.gandi.net (mslow2.mail.gandi.net [217.70.178.242]) by gabe.freedesktop.org (Postfix) with ESMTPS id B519B6E804 for ; Tue, 28 Apr 2020 14:53:22 +0000 (UTC) Received: from relay11.mail.gandi.net (unknown [217.70.178.231]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 64BD73B00A8 for ; Tue, 28 Apr 2020 14:35:45 +0000 (UTC) Received: from uno.localdomain (a-ur1-85.tin.it [212.216.150.148]) (Authenticated sender: jacopo@jmondi.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 7E94710001C; Tue, 28 Apr 2020 14:35:17 +0000 (UTC) Date: Tue, 28 Apr 2020 16:38:28 +0200 From: Jacopo Mondi To: Wei Yongjun Subject: Re: [PATCH -next] drm/rcar-du: Fix return value check in rcar_du_cmm_init() Message-ID: <20200428143828.j7y57ll5drvs2rer@uno.localdomain> References: <20200428141716.87958-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428141716.87958-1-weiyongjun1@huawei.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Jacopo Mondi , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Wei, On Tue, Apr 28, 2020 at 02:17:16PM +0000, Wei Yongjun wrote: > In case of error, the function of_parse_phandle()/of_find_device_by_node() > returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test > > Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") > Signed-off-by: Wei Yongjun Correct indeed! Also -ENODEV seems appropriate to me as return value. Thanks! Acked-by: Jacopo Mondi > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 482329102f19..0da711d9b2f8 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -650,10 +650,10 @@ static int rcar_du_cmm_init(struct rcar_du_device *rcdu) > int ret; > > cmm = of_parse_phandle(np, "renesas,cmms", i); > - if (IS_ERR(cmm)) { > + if (!cmm) { > dev_err(rcdu->dev, > "Failed to parse 'renesas,cmms' property\n"); > - return PTR_ERR(cmm); > + return -ENODEV; > } > > if (!of_device_is_available(cmm)) { > @@ -663,10 +663,10 @@ static int rcar_du_cmm_init(struct rcar_du_device *rcdu) > } > > pdev = of_find_device_by_node(cmm); > - if (IS_ERR(pdev)) { > + if (!pdev) { > dev_err(rcdu->dev, "No device found for CMM%u\n", i); > of_node_put(cmm); > - return PTR_ERR(pdev); > + return -ENODEV; > } > > of_node_put(cmm); > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel