From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B28A9C83001 for ; Tue, 28 Apr 2020 15:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E38E20757 for ; Tue, 28 Apr 2020 15:32:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="JnahAMhE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728477AbgD1PcH (ORCPT ); Tue, 28 Apr 2020 11:32:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727917AbgD1PcH (ORCPT ); Tue, 28 Apr 2020 11:32:07 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCFFCC03C1AB for ; Tue, 28 Apr 2020 08:32:06 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id u16so3339801wmc.5 for ; Tue, 28 Apr 2020 08:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=JnahAMhEEz80r2yHKCjybbTF6t6+SIYUFMUPAtQp+GL3mUUzkfUaqp5KTHLcTJv+bq P81fy3Eh2D06/VO0ChUgMzUqlCQznBNcz0ezSC/Grx8Mg9Ct3d9vHUd1Fi4rVLtYvIEe M0+tdFHnDzbT2poSNgYQX/Eonc2j0jEST5fYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=IYdand+CfEkLJqK+H11ftEpxAu1OtiuemXgu7QFgWWrovcgNfgdLFbbV8jobB0lORo oseINBfDWdnPmjgFJDl5tTVzFoxqDR7TRJ2FCRZzXwizELm3w1GXfUHYH4w4d4R4Vi3S Tm0YQ43A4117WqJeMW3K55NilUxqtcdAsiZXQEvIE9SR5+n4ZWk0vefuFhctF8Y4nZD4 bJp5pcBSQQ3SIF4LHE+p/LPWRE+0ypbJfJUKLhTgxhWgbSgJO6zUgZ62ZBx1H72sWPEf cv/DQp50jvRyN/Zrd9VfCTjl/AHj7AtOJOJnXMIwpsU36VSUrnT/d6dW6tUvIQpUtnBi HqSw== X-Gm-Message-State: AGi0PuYAJW1nkyP5bxnmaIilpj6ksQPYmNHaCJH+taR3wsCcIdp0464O 9+z8K6R48GoG8YuDFN9GBLTPMA== X-Google-Smtp-Source: APiQypK6liIbViG0xJy6SG6E2JLUCRqc/Rd4DEdt0buwtJigcJZRTqgPIaD55s8f3mCsTYZkcr3q5w== X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr5073523wma.24.1588087925505; Tue, 28 Apr 2020 08:32:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p7sm27283944wrf.31.2020.04.28.08.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 08:32:04 -0700 (PDT) Date: Tue, 28 Apr 2020 17:32:02 +0200 From: Daniel Vetter To: Christoph Hellwig Cc: Marek Szyprowski , dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Robin Murphy , Bartlomiej Zolnierkiewicz , Sumit Semwal , Benjamin Gaignard , intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, David Airlie , Daniel Vetter Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200428153202.GY3456981@phenom.ffwll.local> Mail-Followup-To: Christoph Hellwig , Marek Szyprowski , dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Robin Murphy , Bartlomiej Zolnierkiewicz , Sumit Semwal , Benjamin Gaignard , intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, David Airlie References: <20200428132005.21424-1-m.szyprowski@samsung.com> <20200428140257.GA3433@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428140257.GA3433@lst.de> X-Operating-System: Linux phenom 5.3.0-3-amd64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: > On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > > a proper sg_table entries and call respective DMA-mapping functions > > and adapt current code to it > > That sounds reasonable to me. Those could be pretty trivial wrappers. > > > > > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > > which one refers to which part of the scatterlist; I'm open for > > other names for those entries > > nr_cpu_ents and nr_dma_ents might be better names, but it still would be > a whole lot of churn for little gain. I think just good wrappers like > suggested above might be more helpful. I guess long-term we could aim for both? I.e. roll out better wrappers first, once that's soaked through the tree, rename the last offenders. Personally I like nr_cpu_ents and nr_dma_ents, that's about as clear as it gets. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F038C8300A for ; Tue, 28 Apr 2020 15:32:11 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEAB620757 for ; Tue, 28 Apr 2020 15:32:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="JnahAMhE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEAB620757 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4E9282286C; Tue, 28 Apr 2020 15:32:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e0c7xUvOj4hk; Tue, 28 Apr 2020 15:32:09 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 1500722889; Tue, 28 Apr 2020 15:32:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D4B07C0863; Tue, 28 Apr 2020 15:32:08 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id EF83BC0172 for ; Tue, 28 Apr 2020 15:32:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D95B387D80 for ; Tue, 28 Apr 2020 15:32:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kzpxS3Wajjf4 for ; Tue, 28 Apr 2020 15:32:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by hemlock.osuosl.org (Postfix) with ESMTPS id 08876882F3 for ; Tue, 28 Apr 2020 15:32:07 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id u16so3339800wmc.5 for ; Tue, 28 Apr 2020 08:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=JnahAMhEEz80r2yHKCjybbTF6t6+SIYUFMUPAtQp+GL3mUUzkfUaqp5KTHLcTJv+bq P81fy3Eh2D06/VO0ChUgMzUqlCQznBNcz0ezSC/Grx8Mg9Ct3d9vHUd1Fi4rVLtYvIEe M0+tdFHnDzbT2poSNgYQX/Eonc2j0jEST5fYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=nLSu+UIYbjUM2OQkO1N1MHt+eVrxWr37TatSABVpdgoFqlQ6hy5t4uAQvsNXwv/Um9 fGC+GNNkpJ7RwClPwqt0GN7bUNOHyJ9+il8HxzmCP5xbvbCQynE4sxAuhSYRZQHjMkI3 yMJ5/n2AfZ4cEkwJmpfj54DTLtK5ZvcoJf9GR7NdtPz2SOCSKwRGnp6vJTKglcSh0Mrg ODX2XdtBXi5fYUySZ6vEDbhB9Skk6/GukkFEyAN6NFhUMGmT8ouLIH8x+/ECwMbZ8H72 TjKYTCdH0yPaS98DBD1wZJhrkTkofOZKbiBVGRqMa8RsLcagFpR2YanYVZ1/kr21duah zmDw== X-Gm-Message-State: AGi0PuZSQihXH+qapHXl7QBlgbNhR+HNhoCMWwYPyB7+hXK6Fzuie/J0 201iRsoNO6RFvRMPIHE/8dy75Q== X-Google-Smtp-Source: APiQypK6liIbViG0xJy6SG6E2JLUCRqc/Rd4DEdt0buwtJigcJZRTqgPIaD55s8f3mCsTYZkcr3q5w== X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr5073523wma.24.1588087925505; Tue, 28 Apr 2020 08:32:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p7sm27283944wrf.31.2020.04.28.08.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 08:32:04 -0700 (PDT) Date: Tue, 28 Apr 2020 17:32:02 +0200 From: Daniel Vetter To: Christoph Hellwig Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200428153202.GY3456981@phenom.ffwll.local> Mail-Followup-To: Christoph Hellwig , Marek Szyprowski , dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Robin Murphy , Bartlomiej Zolnierkiewicz , Sumit Semwal , Benjamin Gaignard , intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, David Airlie References: <20200428132005.21424-1-m.szyprowski@samsung.com> <20200428140257.GA3433@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428140257.GA3433@lst.de> X-Operating-System: Linux phenom 5.3.0-3-amd64 Cc: Daniel Vetter , Bartlomiej Zolnierkiewicz , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, Benjamin Gaignard , Robin Murphy , Sumit Semwal , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: > On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > > a proper sg_table entries and call respective DMA-mapping functions > > and adapt current code to it > > That sounds reasonable to me. Those could be pretty trivial wrappers. > > > > > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > > which one refers to which part of the scatterlist; I'm open for > > other names for those entries > > nr_cpu_ents and nr_dma_ents might be better names, but it still would be > a whole lot of churn for little gain. I think just good wrappers like > suggested above might be more helpful. I guess long-term we could aim for both? I.e. roll out better wrappers first, once that's soaked through the tree, rename the last offenders. Personally I like nr_cpu_ents and nr_dma_ents, that's about as clear as it gets. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7325C83000 for ; Tue, 28 Apr 2020 15:32:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B28A20746 for ; Tue, 28 Apr 2020 15:32:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="inWCP8X4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="JnahAMhE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B28A20746 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5sF2bk4yFgT8IfPtWZ2KobvRqLNOhMDv8ZFJ2ij1+mI=; b=inWCP8X4L6cpnT 4ckDEUzvwri9cK9w0TmdJnK9MJYmpolDoV98xBCUjAHD8pcDC9cDyeFBbB0ZpPsln+XeypRM+SwKF NXaEWaWD3V7G4BYTZFFIwIiqnaAgypf/GQ809m1JF+8MjTNR9ogr75sMgXKfExSOhx5bjLvKce5S0 tLyFcxPpMvY2EtomNcceCDi3zaNkJ9LLqh5eGpROamC6QxfKzeMs9pquWXm2F9AVHgGbeIGG8rJwq hbwmvSkDKIe+EsXs+JuO0Q7UJc4Qt0xICBVCT2vai1vpO0VrdhiGY9EBHG9BbjMuGxfyFbcJo6594 ih6/b83UyQ3dxDqgtowA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTSDW-0003kS-Hc; Tue, 28 Apr 2020 15:32:14 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTSDP-0003fM-4m for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2020 15:32:09 +0000 Received: by mail-wm1-x332.google.com with SMTP id x25so3289554wmc.0 for ; Tue, 28 Apr 2020 08:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=JnahAMhEEz80r2yHKCjybbTF6t6+SIYUFMUPAtQp+GL3mUUzkfUaqp5KTHLcTJv+bq P81fy3Eh2D06/VO0ChUgMzUqlCQznBNcz0ezSC/Grx8Mg9Ct3d9vHUd1Fi4rVLtYvIEe M0+tdFHnDzbT2poSNgYQX/Eonc2j0jEST5fYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=hyaQb4BFUCVd7vuhXINGhtKfzw3xVb1CmsZky9seni+CqOlYOrqA8itOIN/A/+3Pj9 psX0GugWQtoVG40qPh1ScIEWJMa6OK1LoFO0jljnPqO6/0bM1/bVG5T2VWNwjnJ/xEm4 i3BOFNdNNAO1tY7m1SMMAAuKMPrarYSle6vlJG6IlYcv4RMUaG+Dc76rF8HO0kuPQ0rV hZ5lAWna8ZBiIL2210nLhfGxbhfSCOpw4CrNO6RPCZ5JBrdT7RIiLkR0llqoaKpCFOTZ GAdWfdpFcPX7lwG1IbC2lom8vbrZZJ8kIUjoZsMkZRUdybwU8MCabi5vdBAXxNOSt87P /LBg== X-Gm-Message-State: AGi0PuaJOyKGU/kGsFVTznrkT+8kAjpYrhGnoUkqs+clQ2RxtFXjGTjG OpsRc9ExWepr2FJvS9tNIlsczQ== X-Google-Smtp-Source: APiQypK6liIbViG0xJy6SG6E2JLUCRqc/Rd4DEdt0buwtJigcJZRTqgPIaD55s8f3mCsTYZkcr3q5w== X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr5073523wma.24.1588087925505; Tue, 28 Apr 2020 08:32:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p7sm27283944wrf.31.2020.04.28.08.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 08:32:04 -0700 (PDT) Date: Tue, 28 Apr 2020 17:32:02 +0200 From: Daniel Vetter To: Christoph Hellwig Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200428153202.GY3456981@phenom.ffwll.local> Mail-Followup-To: Christoph Hellwig , Marek Szyprowski , dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Robin Murphy , Bartlomiej Zolnierkiewicz , Sumit Semwal , Benjamin Gaignard , intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, David Airlie References: <20200428132005.21424-1-m.szyprowski@samsung.com> <20200428140257.GA3433@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428140257.GA3433@lst.de> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200428_083207_202227_7748995C X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Bartlomiej Zolnierkiewicz , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, Benjamin Gaignard , Robin Murphy , Sumit Semwal , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: > On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > > a proper sg_table entries and call respective DMA-mapping functions > > and adapt current code to it > > That sounds reasonable to me. Those could be pretty trivial wrappers. > > > > > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > > which one refers to which part of the scatterlist; I'm open for > > other names for those entries > > nr_cpu_ents and nr_dma_ents might be better names, but it still would be > a whole lot of churn for little gain. I think just good wrappers like > suggested above might be more helpful. I guess long-term we could aim for both? I.e. roll out better wrappers first, once that's soaked through the tree, rename the last offenders. Personally I like nr_cpu_ents and nr_dma_ents, that's about as clear as it gets. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F023CC83000 for ; Tue, 28 Apr 2020 15:32:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C518C20746 for ; Tue, 28 Apr 2020 15:32:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="JnahAMhE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C518C20746 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CD526E83D; Tue, 28 Apr 2020 15:32:08 +0000 (UTC) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC1A56E838 for ; Tue, 28 Apr 2020 15:32:06 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id k12so3275274wmj.3 for ; Tue, 28 Apr 2020 08:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=JnahAMhEEz80r2yHKCjybbTF6t6+SIYUFMUPAtQp+GL3mUUzkfUaqp5KTHLcTJv+bq P81fy3Eh2D06/VO0ChUgMzUqlCQznBNcz0ezSC/Grx8Mg9Ct3d9vHUd1Fi4rVLtYvIEe M0+tdFHnDzbT2poSNgYQX/Eonc2j0jEST5fYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=dNWlRwE6coLaiMW4+yXhPoQ13wwlanj0KwXYr1vuqduB4ho3iI176sHB+vCBeD+bdi GCC06ezOEtA8gbI761lTNZGS27H0SBhdHXE8ip8YcwyuwznF9pz3RGP9TabkbpNLvza/ kX27TQNAN1PpJfwg/EJ48UPdhfRuhuqO/B4O6YRI+cGawB16wqWWi38UXYj2UPErB28i 8g4QIh4XACqDSgo8gWNKIa7G1udayVkDeT0FKubce3cMtxEfZP2SmwdxdOYHCX7glooB Z9proglyCf+JdWIGVpr4jT8DO3SPxaGOoRV1pbxvzn9p0BWCZr6pL1AB3EGd/n3M/EoE j8mg== X-Gm-Message-State: AGi0PuYgcZsZ6S7GOJcTT6hJEPxF5T5xquLlJl46nKlZvtsaILvd80iy bCDKVNuo8B9mZcViXIdJtj/6Fw== X-Google-Smtp-Source: APiQypK6liIbViG0xJy6SG6E2JLUCRqc/Rd4DEdt0buwtJigcJZRTqgPIaD55s8f3mCsTYZkcr3q5w== X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr5073523wma.24.1588087925505; Tue, 28 Apr 2020 08:32:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p7sm27283944wrf.31.2020.04.28.08.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 08:32:04 -0700 (PDT) Date: Tue, 28 Apr 2020 17:32:02 +0200 From: Daniel Vetter To: Christoph Hellwig Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200428153202.GY3456981@phenom.ffwll.local> Mail-Followup-To: Christoph Hellwig , Marek Szyprowski , dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Robin Murphy , Bartlomiej Zolnierkiewicz , Sumit Semwal , Benjamin Gaignard , intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, David Airlie References: <20200428132005.21424-1-m.szyprowski@samsung.com> <20200428140257.GA3433@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428140257.GA3433@lst.de> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, Robin Murphy , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: > On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > > a proper sg_table entries and call respective DMA-mapping functions > > and adapt current code to it > > That sounds reasonable to me. Those could be pretty trivial wrappers. > > > > > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > > which one refers to which part of the scatterlist; I'm open for > > other names for those entries > > nr_cpu_ents and nr_dma_ents might be better names, but it still would be > a whole lot of churn for little gain. I think just good wrappers like > suggested above might be more helpful. I guess long-term we could aim for both? I.e. roll out better wrappers first, once that's soaked through the tree, rename the last offenders. Personally I like nr_cpu_ents and nr_dma_ents, that's about as clear as it gets. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269A2C83009 for ; Tue, 28 Apr 2020 15:32:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0A1020746 for ; Tue, 28 Apr 2020 15:32:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="JnahAMhE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0A1020746 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22E6F6E820; Tue, 28 Apr 2020 15:32:08 +0000 (UTC) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB2AB6E820 for ; Tue, 28 Apr 2020 15:32:06 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id y24so3359931wma.4 for ; Tue, 28 Apr 2020 08:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=JnahAMhEEz80r2yHKCjybbTF6t6+SIYUFMUPAtQp+GL3mUUzkfUaqp5KTHLcTJv+bq P81fy3Eh2D06/VO0ChUgMzUqlCQznBNcz0ezSC/Grx8Mg9Ct3d9vHUd1Fi4rVLtYvIEe M0+tdFHnDzbT2poSNgYQX/Eonc2j0jEST5fYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=gB3xUJyIWFFWQ/hzgzN8qXO8soD1NiLlsG+TOiHH0D51VwA/3Te/gejEF7A2fOcz6J k+MUqCkLwkP5trVGOFhSiLqTBt18spxTQHUyKcFwqynU2m/XYGt6gCS05pllxdFuVqZU Y8U9hM2EGQiypYtpcuXYJFQkz/qzv3eidUfzIrVLSmYvHBy2tscCzLFI+xEK9wu42XsV ndOwOB3/8SZQ2TgYeefJY9AHFxHIIqFU+GYxyztaVvILFNXHvcAF2JopqkeLigk6X67w FVaAric21v20FKZjEeSqOdQ1jMXiMQvhj2WisoGfoi3AYfpOy/HCWHULnQ/NqCnwXJRR KO4w== X-Gm-Message-State: AGi0PuaD6kWgahYP5oGK6Nd89tIaLo1kc2ECSi4JuNbsKt9ksoXM8doo 6hJOZY5aFs0AibxakQ2P+G1BZUhkRp4= X-Google-Smtp-Source: APiQypK6liIbViG0xJy6SG6E2JLUCRqc/Rd4DEdt0buwtJigcJZRTqgPIaD55s8f3mCsTYZkcr3q5w== X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr5073523wma.24.1588087925505; Tue, 28 Apr 2020 08:32:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p7sm27283944wrf.31.2020.04.28.08.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 08:32:04 -0700 (PDT) Date: Tue, 28 Apr 2020 17:32:02 +0200 From: Daniel Vetter To: Christoph Hellwig Message-ID: <20200428153202.GY3456981@phenom.ffwll.local> Mail-Followup-To: Christoph Hellwig , Marek Szyprowski , dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Robin Murphy , Bartlomiej Zolnierkiewicz , Sumit Semwal , Benjamin Gaignard , intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, David Airlie References: <20200428132005.21424-1-m.szyprowski@samsung.com> <20200428140257.GA3433@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428140257.GA3433@lst.de> X-Operating-System: Linux phenom 5.3.0-3-amd64 Subject: Re: [Intel-gfx] [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, Benjamin Gaignard , Robin Murphy , Sumit Semwal , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: > On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > > a proper sg_table entries and call respective DMA-mapping functions > > and adapt current code to it > > That sounds reasonable to me. Those could be pretty trivial wrappers. > > > > > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > > which one refers to which part of the scatterlist; I'm open for > > other names for those entries > > nr_cpu_ents and nr_dma_ents might be better names, but it still would be > a whole lot of churn for little gain. I think just good wrappers like > suggested above might be more helpful. I guess long-term we could aim for both? I.e. roll out better wrappers first, once that's soaked through the tree, rename the last offenders. Personally I like nr_cpu_ents and nr_dma_ents, that's about as clear as it gets. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B28D9C83008 for ; Tue, 28 Apr 2020 15:32:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8351F20746 for ; Tue, 28 Apr 2020 15:32:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="JnahAMhE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8351F20746 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 34FEF6E838; Tue, 28 Apr 2020 15:32:08 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC5DA6E839 for ; Tue, 28 Apr 2020 15:32:06 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id z6so3365389wml.2 for ; Tue, 28 Apr 2020 08:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=JnahAMhEEz80r2yHKCjybbTF6t6+SIYUFMUPAtQp+GL3mUUzkfUaqp5KTHLcTJv+bq P81fy3Eh2D06/VO0ChUgMzUqlCQznBNcz0ezSC/Grx8Mg9Ct3d9vHUd1Fi4rVLtYvIEe M0+tdFHnDzbT2poSNgYQX/Eonc2j0jEST5fYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=fyTgxWA2/HoMwR8ETQ07Hg4eZzNMuWdW9xEgr0yJj2c=; b=kRrGAOxEoBfDO3/gu6gBFQ+HTKKeuh2mw7Y4jUggrCZhOnmsGEVrhPBSAihsVFXfdn E4mu4Bd8ZwxCEbmAZtOtK3okPx+Vz650q/D015raTtsrJt6AwVWyxituExwGLeslCF9X /V1w1H1Yvz24wlXA5OUsAKbHrRS3hd8lK0rNSezo4mrV6GW4mZXFEoUCCfwIpaWs8HZB 8OUoZDZI5opJxq7vT6HnrXL98MRIjy3rJ4cmX/u0tSoBFd1C0K3YOUH+YjRsZ/KTfJSO iAb5WAIlWrGyOYPbUqpHl6jAVVquxB57BJvurqa+KwSAkitNGaKyR5C4TruC/s2dHjCB PTLg== X-Gm-Message-State: AGi0PuZQ+MAqS0rIyH/NrDYHgkOVYE7PralhOezkrzK8EwdfZDBoIIXd bTFzA8rR/rm4gW5UidOwIrBqVg== X-Google-Smtp-Source: APiQypK6liIbViG0xJy6SG6E2JLUCRqc/Rd4DEdt0buwtJigcJZRTqgPIaD55s8f3mCsTYZkcr3q5w== X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr5073523wma.24.1588087925505; Tue, 28 Apr 2020 08:32:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p7sm27283944wrf.31.2020.04.28.08.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 08:32:04 -0700 (PDT) Date: Tue, 28 Apr 2020 17:32:02 +0200 From: Daniel Vetter To: Christoph Hellwig Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200428153202.GY3456981@phenom.ffwll.local> Mail-Followup-To: Christoph Hellwig , Marek Szyprowski , dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Robin Murphy , Bartlomiej Zolnierkiewicz , Sumit Semwal , Benjamin Gaignard , intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, David Airlie References: <20200428132005.21424-1-m.szyprowski@samsung.com> <20200428140257.GA3433@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428140257.GA3433@lst.de> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Bartlomiej Zolnierkiewicz , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, Benjamin Gaignard , Robin Murphy , Sumit Semwal , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: > On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > > a proper sg_table entries and call respective DMA-mapping functions > > and adapt current code to it > > That sounds reasonable to me. Those could be pretty trivial wrappers. > > > > > > > 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state > > which one refers to which part of the scatterlist; I'm open for > > other names for those entries > > nr_cpu_ents and nr_dma_ents might be better names, but it still would be > a whole lot of churn for little gain. I think just good wrappers like > suggested above might be more helpful. I guess long-term we could aim for both? I.e. roll out better wrappers first, once that's soaked through the tree, rename the last offenders. Personally I like nr_cpu_ents and nr_dma_ents, that's about as clear as it gets. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx