From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FD97C83001 for ; Tue, 28 Apr 2020 15:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39FF5205C9 for ; Tue, 28 Apr 2020 15:45:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728133AbgD1PpL (ORCPT ); Tue, 28 Apr 2020 11:45:11 -0400 Received: from mga09.intel.com ([134.134.136.24]:23143 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728035AbgD1PpL (ORCPT ); Tue, 28 Apr 2020 11:45:11 -0400 IronPort-SDR: FlK3USzNRZyzqpItFtpJNaSES7fWhuopKM6whHov3hHb/YX9AeTWwB/b0UNCH1vlG29RvwSe8y pAhpvbBT4yJA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 08:45:10 -0700 IronPort-SDR: Y2jjpeQRyMamyyeeqnfCuhoebJpgL2SUnnbusXiXSvRFa4VFWEOKkf6mvdtj8n9SuU5rKO1IT3 kYAuCADvdMlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="302740823" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 28 Apr 2020 08:45:05 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 28 Apr 2020 18:45:05 +0300 Date: Tue, 28 Apr 2020 18:45:05 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Michal Orzel , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, chris@chris-wilson.co.uk, jose.souza@intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] Remove drm_display_mode.hsync Message-ID: <20200428154505.GK6112@intel.com> References: <1587974717-14599-1-git-send-email-michalorzel.eng@gmail.com> <20200428151813.GW3456981@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200428151813.GW3456981@phenom.ffwll.local> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 05:18:13PM +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > > As suggested by the TODO list of DRM subsystem: > > -remove the member hsync of drm_display_mode > > -convert code using hsync member to use drm_mode_hsync() > > > > Signed-off-by: Michal Orzel > > I think Ville has a bunch of patches doing this, we might have some > overlap :-/ Adding Ville. > > Please sync with him and get either of these patches reviewed. Yeah, I have the same thing (+ making the function static). I think my series is sufficiently reviewed to get most of it pushed. Just need to get it past the ci... which apparently means I get to do another rebase. > > Thanks, Daniel > > > --- > > drivers/gpu/drm/drm_modes.c | 6 +----- > > drivers/gpu/drm/i915/display/intel_display.c | 1 - > > include/drm/drm_modes.h | 10 ---------- > > 3 files changed, 1 insertion(+), 16 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index d4d6451..0340079 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); > > * @mode: mode > > * > > * Returns: > > - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the > > - * value first if it is not yet set. > > + * @modes's hsync rate in kHz, rounded to the nearest integer. > > */ > > int drm_mode_hsync(const struct drm_display_mode *mode) > > { > > unsigned int calc_val; > > > > - if (mode->hsync) > > - return mode->hsync; > > - > > if (mode->htotal <= 0) > > return 0; > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > > index 3468466..ec7e943 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, > > > > mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; > > > > - mode->hsync = drm_mode_hsync(mode); > > mode->vrefresh = drm_mode_vrefresh(mode); > > drm_mode_set_name(mode); > > } > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > > index 99134d4..7dab7f1 100644 > > --- a/include/drm/drm_modes.h > > +++ b/include/drm/drm_modes.h > > @@ -391,16 +391,6 @@ struct drm_display_mode { > > int vrefresh; > > > > /** > > - * @hsync: > > - * > > - * Horizontal refresh rate, for debug output in human readable form. Not > > - * used in a functional way. > > - * > > - * This value is in kHz. > > - */ > > - int hsync; > > - > > - /** > > * @picture_aspect_ratio: > > * > > * Field for setting the HDMI picture aspect ratio of a mode. > > -- > > 2.7.4 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02342C83000 for ; Tue, 28 Apr 2020 15:45:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7E64205C9 for ; Tue, 28 Apr 2020 15:45:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7E64205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27C616E840; Tue, 28 Apr 2020 15:45:11 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D1106E840; Tue, 28 Apr 2020 15:45:10 +0000 (UTC) IronPort-SDR: J/QgJ4GZeo/6B37melZREH59U31kWu4mrosLaIh/00dCmbhgPwB+oi+/6YwFB0X9DOwcypcASb q+Qm/8e1JNfg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 08:45:10 -0700 IronPort-SDR: Y2jjpeQRyMamyyeeqnfCuhoebJpgL2SUnnbusXiXSvRFa4VFWEOKkf6mvdtj8n9SuU5rKO1IT3 kYAuCADvdMlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="302740823" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 28 Apr 2020 08:45:05 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 28 Apr 2020 18:45:05 +0300 Date: Tue, 28 Apr 2020 18:45:05 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Michal Orzel , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, chris@chris-wilson.co.uk, jose.souza@intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] Remove drm_display_mode.hsync Message-ID: <20200428154505.GK6112@intel.com> References: <1587974717-14599-1-git-send-email-michalorzel.eng@gmail.com> <20200428151813.GW3456981@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428151813.GW3456981@phenom.ffwll.local> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 28, 2020 at 05:18:13PM +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > > As suggested by the TODO list of DRM subsystem: > > -remove the member hsync of drm_display_mode > > -convert code using hsync member to use drm_mode_hsync() > > = > > Signed-off-by: Michal Orzel > = > I think Ville has a bunch of patches doing this, we might have some > overlap :-/ Adding Ville. > = > Please sync with him and get either of these patches reviewed. Yeah, I have the same thing (+ making the function static). I think my series is sufficiently reviewed to get most of it pushed. Just need to get it past the ci... which apparently means I get to do another rebase. > = > Thanks, Daniel > = > > --- > > drivers/gpu/drm/drm_modes.c | 6 +----- > > drivers/gpu/drm/i915/display/intel_display.c | 1 - > > include/drm/drm_modes.h | 10 ---------- > > 3 files changed, 1 insertion(+), 16 deletions(-) > > = > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index d4d6451..0340079 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); > > * @mode: mode > > * > > * Returns: > > - * @modes's hsync rate in kHz, rounded to the nearest integer. Calcula= tes the > > - * value first if it is not yet set. > > + * @modes's hsync rate in kHz, rounded to the nearest integer. > > */ > > int drm_mode_hsync(const struct drm_display_mode *mode) > > { > > unsigned int calc_val; > > = > > - if (mode->hsync) > > - return mode->hsync; > > - > > if (mode->htotal <=3D 0) > > return 0; > > = > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu= /drm/i915/display/intel_display.c > > index 3468466..ec7e943 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_displ= ay_mode *mode, > > = > > mode->clock =3D pipe_config->hw.adjusted_mode.crtc_clock; > > = > > - mode->hsync =3D drm_mode_hsync(mode); > > mode->vrefresh =3D drm_mode_vrefresh(mode); > > drm_mode_set_name(mode); > > } > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > > index 99134d4..7dab7f1 100644 > > --- a/include/drm/drm_modes.h > > +++ b/include/drm/drm_modes.h > > @@ -391,16 +391,6 @@ struct drm_display_mode { > > int vrefresh; > > = > > /** > > - * @hsync: > > - * > > - * Horizontal refresh rate, for debug output in human readable form. = Not > > - * used in a functional way. > > - * > > - * This value is in kHz. > > - */ > > - int hsync; > > - > > - /** > > * @picture_aspect_ratio: > > * > > * Field for setting the HDMI picture aspect ratio of a mode. > > -- = > > 2.7.4 > > = > = > -- = > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD58C83008 for ; Tue, 28 Apr 2020 15:45:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 784732085B for ; Tue, 28 Apr 2020 15:45:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 784732085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AC8A6E846; Tue, 28 Apr 2020 15:45:11 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D1106E840; Tue, 28 Apr 2020 15:45:10 +0000 (UTC) IronPort-SDR: J/QgJ4GZeo/6B37melZREH59U31kWu4mrosLaIh/00dCmbhgPwB+oi+/6YwFB0X9DOwcypcASb q+Qm/8e1JNfg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 08:45:10 -0700 IronPort-SDR: Y2jjpeQRyMamyyeeqnfCuhoebJpgL2SUnnbusXiXSvRFa4VFWEOKkf6mvdtj8n9SuU5rKO1IT3 kYAuCADvdMlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="302740823" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 28 Apr 2020 08:45:05 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 28 Apr 2020 18:45:05 +0300 Date: Tue, 28 Apr 2020 18:45:05 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Michal Orzel , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, chris@chris-wilson.co.uk, jose.souza@intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org Message-ID: <20200428154505.GK6112@intel.com> References: <1587974717-14599-1-git-send-email-michalorzel.eng@gmail.com> <20200428151813.GW3456981@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428151813.GW3456981@phenom.ffwll.local> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] Remove drm_display_mode.hsync X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Apr 28, 2020 at 05:18:13PM +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > > As suggested by the TODO list of DRM subsystem: > > -remove the member hsync of drm_display_mode > > -convert code using hsync member to use drm_mode_hsync() > > = > > Signed-off-by: Michal Orzel > = > I think Ville has a bunch of patches doing this, we might have some > overlap :-/ Adding Ville. > = > Please sync with him and get either of these patches reviewed. Yeah, I have the same thing (+ making the function static). I think my series is sufficiently reviewed to get most of it pushed. Just need to get it past the ci... which apparently means I get to do another rebase. > = > Thanks, Daniel > = > > --- > > drivers/gpu/drm/drm_modes.c | 6 +----- > > drivers/gpu/drm/i915/display/intel_display.c | 1 - > > include/drm/drm_modes.h | 10 ---------- > > 3 files changed, 1 insertion(+), 16 deletions(-) > > = > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index d4d6451..0340079 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); > > * @mode: mode > > * > > * Returns: > > - * @modes's hsync rate in kHz, rounded to the nearest integer. Calcula= tes the > > - * value first if it is not yet set. > > + * @modes's hsync rate in kHz, rounded to the nearest integer. > > */ > > int drm_mode_hsync(const struct drm_display_mode *mode) > > { > > unsigned int calc_val; > > = > > - if (mode->hsync) > > - return mode->hsync; > > - > > if (mode->htotal <=3D 0) > > return 0; > > = > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu= /drm/i915/display/intel_display.c > > index 3468466..ec7e943 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_displ= ay_mode *mode, > > = > > mode->clock =3D pipe_config->hw.adjusted_mode.crtc_clock; > > = > > - mode->hsync =3D drm_mode_hsync(mode); > > mode->vrefresh =3D drm_mode_vrefresh(mode); > > drm_mode_set_name(mode); > > } > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > > index 99134d4..7dab7f1 100644 > > --- a/include/drm/drm_modes.h > > +++ b/include/drm/drm_modes.h > > @@ -391,16 +391,6 @@ struct drm_display_mode { > > int vrefresh; > > = > > /** > > - * @hsync: > > - * > > - * Horizontal refresh rate, for debug output in human readable form. = Not > > - * used in a functional way. > > - * > > - * This value is in kHz. > > - */ > > - int hsync; > > - > > - /** > > * @picture_aspect_ratio: > > * > > * Field for setting the HDMI picture aspect ratio of a mode. > > -- = > > 2.7.4 > > = > = > -- = > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx