From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 231C6C83008 for ; Tue, 28 Apr 2020 17:01:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDEED20730 for ; Tue, 28 Apr 2020 17:01:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qExKSOty"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CeyQtE+M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDEED20730 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2Scm/o5KDa1V3YYdkdT8+Q4bTPGXtR1FeBKFFP68JwU=; b=qExKSOtyQ8yszo i6iGdtk7nmo5+eGNl8U5EyMKQiMvH8EElZc8TKi+KqK3xVa+sQLqgLBUSSDhmiEaDPMwz12h3UoSr B8kWpV2JR9WM5rxYbT3dmZao/ZnGiVCJSoifsnOftStVKwXPxslVgmXP//9wrU4l4UnWMG2atYpPK 5HTxLnADKzs6iz6tHmcvpHdUcP5PgFDY2NeIwhxWYObY0YTT6vynyLm8C6ZOD7oewyF7GuwrxwIoN mQBDWZZ6HF2Z04T9iceSH8gf1xBeV1nwb7aPU7Xj1m7RCXBPIVo7ojFh0L2lWt7sQGXsKVcyipadk V4HCeFBX8jw/IaAbQiFA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTTcC-0008Fu-0p; Tue, 28 Apr 2020 17:01:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTTc9-0008FE-AP for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2020 17:01:46 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 051E620730; Tue, 28 Apr 2020 17:01:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588093305; bh=xcQPhPELoJFmrkYBG9DGhjiWZOwVw5TLM1bfB0MNv0o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CeyQtE+MJq+TQHXeEpQybkBUhgB1VpjAq4ANhMU0tPZMvw6Pzf+I+SVmcZCm5CJ9k cZ7BjROAZ+eHsAghzfoHDkWNDzBN7tLVfjRUtlPotAGFypSeC/kBqQfxe/w9dh5NS5 FjO9iq000CUQqKuybnjyZPwchnyjs93uwhP+AJ6g= Date: Tue, 28 Apr 2020 18:01:39 +0100 From: Will Deacon To: Ard Biesheuvel Subject: Re: [PATCH] arm64: iort: take _DMA methods into account for named components Message-ID: <20200428170138.GF12697@willie-the-truck> References: <20200404073047.17898-1-ardb@kernel.org> <20200420084051.GA12852@red-moon.cambridge.arm.com> <20200420091342.GA6867@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200428_100145_383450_308C7FEB X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Lorenzo Pieralisi , robin.murphy@arm.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 20, 2020 at 11:14:50AM +0200, Ard Biesheuvel wrote: > On Mon, 20 Apr 2020 at 11:13, Lorenzo Pieralisi > wrote: > > > > On Mon, Apr 20, 2020 at 10:58:02AM +0200, Ard Biesheuvel wrote: > > > On Mon, 20 Apr 2020 at 10:41, Lorenzo Pieralisi > > > wrote: > > > > > > > > On Sat, Apr 04, 2020 at 09:30:47AM +0200, Ard Biesheuvel wrote: > > > > > Where IORT nodes for named components can describe simple DMA limits > > > > > expressed as the number of address bits a device can driver, _DMA methods > > > > > in AML can express more complex topologies, involving DMA translation in > > > > > particular. > > > > > > > > > > Currently, we only take this _DMA method into account if it appears on a > > > > > ACPI device node describing a PCIe root complex, but it is perfectly > > > > > acceptable to attach them to named components as well, so let's ensure > > > > > we take them into account in those cases too. > > > > > > > > > > Reported-by: Andrei Warkentin > > > > > Fixes: 7ad4263980826e8b ("ACPI: Make acpi_dma_configure() DMA regions aware") > > > > > Cc: # v4.14+ > > > > > Signed-off-by: Ard Biesheuvel > > > > > --- > > > > > drivers/acpi/arm64/iort.c | 11 ++++------- > > > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > > > Only question is whether there is FW in the field with _DMA methods that > > > > now we would start parsing (and hopefully everything will still work) > > > > but for that the only choice is applying this patch and see, so: > > > > > > > > > > Perhaps it would be better to call acpi_dma_get_range() on dev->parent then? > > > > I think it is fine as it is - maybe we can hold off sending it all > > the way to stable kernels until we are confident it does not cause > > unintended breakage ? > > > > Anyway, thanks for putting it together. > > > > Minor nit: I'd make "arm64: iort:" in the subject "ACPI/IORT:" > > just to keep logs uniform. > > > > OK, I'll respin and resend, with the ACPI folks on cc this time. Thanks. I'm happy to queue this in the arm64 tree with the CC: stable dropped for now, so please keep me on cc for v2. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel