From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F9DC83007 for ; Tue, 28 Apr 2020 18:59:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56B3020575 for ; Tue, 28 Apr 2020 18:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588100379; bh=cAsobCg9jwmouMkaU0/F+93bEXvxaMeqh2tFcVn6pKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=l+o6qOa/vdftkeFNCfpywzuiaiUBeTiX1oqRroRFygWgnMWE+J0LACVldNka8FZkK m5cu4znAUafT5+9BbIZ1z/wwtyHN7diAWnsjT2bDrsEGi2Dv4MNbYVzOEvyQU+cEUL MANnOwXYgVI9MkAK0nfG/JRLUhoM4D8QCin9XS+E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730451AbgD1S7i (ORCPT ); Tue, 28 Apr 2020 14:59:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:41272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729189AbgD1S2Z (ORCPT ); Tue, 28 Apr 2020 14:28:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4DE5220BED; Tue, 28 Apr 2020 18:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098504; bh=cAsobCg9jwmouMkaU0/F+93bEXvxaMeqh2tFcVn6pKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k9mrJk6pGq7IPz6VeCI/Rt+kH858nHTOHnP5H93rbMf+NlvmMlkLer9U5IDas3HAE NjbiQ+hAE1IyrRZz6PrW7sk83jAWJ0JS0JaA0fy4mJblKhl54fRQdExlFJdf3R/AxR v3RuVaF+Gx2XOuzv9QcR4HZq7pSRdxcpd+tMMThM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xiyu Yang , Xin Tan , "David S. Miller" Subject: [PATCH 5.6 062/167] tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv Date: Tue, 28 Apr 2020 20:23:58 +0200 Message-Id: <20200428182232.791482602@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182225.451225420@linuxfoundation.org> References: <20200428182225.451225420@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiyu Yang [ Upstream commit 441870ee4240cf67b5d3ab8e16216a9ff42eb5d6 ] tipc_crypto_rcv() invokes tipc_aead_get(), which returns a reference of the tipc_aead object to "aead" with increased refcnt. When tipc_crypto_rcv() returns, the original local reference of "aead" becomes invalid, so the refcount should be decreased to keep refcount balanced. The issue happens in one error path of tipc_crypto_rcv(). When TIPC message decryption status is EINPROGRESS or EBUSY, the function forgets to decrease the refcnt increased by tipc_aead_get() and causes a refcnt leak. Fix this issue by calling tipc_aead_put() on the error path when TIPC message decryption status is EINPROGRESS or EBUSY. Signed-off-by: Xiyu Yang Signed-off-by: Xin Tan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/tipc/crypto.c | 1 + 1 file changed, 1 insertion(+) --- a/net/tipc/crypto.c +++ b/net/tipc/crypto.c @@ -1712,6 +1712,7 @@ exit: case -EBUSY: this_cpu_inc(stats->stat[STAT_ASYNC]); *skb = NULL; + tipc_aead_put(aead); return rc; default: this_cpu_inc(stats->stat[STAT_NOK]);