From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E45C83008 for ; Tue, 28 Apr 2020 18:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C422208E0 for ; Tue, 28 Apr 2020 18:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098980; bh=Q64Ow6VBZtzyiC+N2RsYCDfDIxKIc+BL1MbI7J3IJXY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WBU4PGAproUvxckgGOInYsWRAan0Dotf5u0Nv8jz+7aNv01FD7USpC55eYZrK/lL3 8MsreycUe+azSw86ZFuXCjkj/vzA2HcPSHhcc2KSSolTcx/gSCwi6AfQy67nqWo1au PYiZgDcFoz7nraFWfJK68f8nrnrisWS3Hq/ERNZ4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730370AbgD1SgT (ORCPT ); Tue, 28 Apr 2020 14:36:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:53592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730358AbgD1SgL (ORCPT ); Tue, 28 Apr 2020 14:36:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CDF12085B; Tue, 28 Apr 2020 18:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098971; bh=Q64Ow6VBZtzyiC+N2RsYCDfDIxKIc+BL1MbI7J3IJXY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d6DyNhVfc2LIQRTM+SOV7V1tYsP6FEj81UezWwgUsfkAflmkpK08HBVTnT4S0wMQa kluXPn/JpvqUmbVT9POGdVNTo3nmoEJoUn7BdkUoD+7wjkEyzMugbLDP9dAL/vdIm5 V3sYfYDlF2kQayTJbCVXy9lBis55JL2ClQ/VUg2c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lars-Peter Clausen , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 4.19 080/131] iio: xilinx-xadc: Fix ADC-B powerdown Date: Tue, 28 Apr 2020 20:24:52 +0200 Message-Id: <20200428182234.994797952@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182224.822179290@linuxfoundation.org> References: <20200428182224.822179290@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars-Peter Clausen commit e44ec7794d88f918805d700240211a9ec05ed89d upstream. The check for shutting down the second ADC is inverted. This causes it to be powered down when it should be enabled. As a result channels that are supposed to be handled by the second ADC return invalid conversion results. Signed-off-by: Lars-Peter Clausen Fixes: bdc8cda1d010 ("iio:adc: Add Xilinx XADC driver") Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/adc/xilinx-xadc-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/iio/adc/xilinx-xadc-core.c +++ b/drivers/iio/adc/xilinx-xadc-core.c @@ -723,13 +723,14 @@ static int xadc_power_adc_b(struct xadc { uint16_t val; + /* Powerdown the ADC-B when it is not needed. */ switch (seq_mode) { case XADC_CONF1_SEQ_SIMULTANEOUS: case XADC_CONF1_SEQ_INDEPENDENT: - val = XADC_CONF2_PD_ADC_B; + val = 0; break; default: - val = 0; + val = XADC_CONF2_PD_ADC_B; break; }