From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0A7FC83004 for ; Tue, 28 Apr 2020 18:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 835C220575 for ; Tue, 28 Apr 2020 18:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588100268; bh=1Fj3PTj5oghOrjkoXDbSvlZzFgLk4RdKysNplhgIQxs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OW1FS7dAv5cw5FnvuWsb3rD2tpNr69IXLVpz5FVMWomk7h1klrxCzmh62uE8JfHZv AMhZP4XJDxhvYQNlOu5RSmVB4pqyKdClFF8X9BMhH+Gu8C906V6AlfAdp5ofi4WCug yUgTHS9vg3O1ujqSHJQ6AiD2l4mlIxc/SnJAbldw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729453AbgD1SaG (ORCPT ); Tue, 28 Apr 2020 14:30:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:44332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729438AbgD1SaC (ORCPT ); Tue, 28 Apr 2020 14:30:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DB9F20730; Tue, 28 Apr 2020 18:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098602; bh=1Fj3PTj5oghOrjkoXDbSvlZzFgLk4RdKysNplhgIQxs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TB7Vm05XfXkcEdHw2DUbD9b0WHeohrlJTfbmOPNHYYGqOB8A7eDdhf3b+Buv3MxPl 6Yk2q4Hl7aW9LLdUw5XNkw9LnlUZd0oHfaYruVGpVB9JXtdZE5eQ3O+PU4rHr1b1Uw 6WX984KzDKc6hlKCJ7x8rndtTV109CGpUe4egtpg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lary Gibaud , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.6 083/167] iio: st_sensors: rely on odr mask to know if odr can be set Date: Tue, 28 Apr 2020 20:24:19 +0200 Message-Id: <20200428182235.492788197@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182225.451225420@linuxfoundation.org> References: <20200428182225.451225420@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lary Gibaud commit e450e07c14abae563ad13b064cbce9fdccc6bc8d upstream. Indeed, relying on addr being not 0 cannot work because some device have their register to set odr at address 0. As a matter of fact, if the odr can be set, then there is a mask. Sensors with ODR register at address 0 are: lsm303dlh, lsm303dlhc, lsm303dlm Fixes: 7d245172675a ("iio: common: st_sensors: check odr address value in st_sensors_set_odr()") Signed-off-by: Lary Gibaud Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/common/st_sensors/st_sensors_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/common/st_sensors/st_sensors_core.c +++ b/drivers/iio/common/st_sensors/st_sensors_core.c @@ -79,7 +79,7 @@ int st_sensors_set_odr(struct iio_dev *i struct st_sensor_odr_avl odr_out = {0, 0}; struct st_sensor_data *sdata = iio_priv(indio_dev); - if (!sdata->sensor_settings->odr.addr) + if (!sdata->sensor_settings->odr.mask) return 0; err = st_sensors_match_odr(sdata->sensor_settings, odr, &odr_out);