From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 112E1C83004 for ; Tue, 28 Apr 2020 18:55:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2DB220575 for ; Tue, 28 Apr 2020 18:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588100151; bh=pPmIFV+1g5lafog4sRGHQB4bxuzsE16raYDXiB2UHXA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=R4YzVXg0NeELG43Wa9Sqve2da+zZQdbC6nUE/d7lnh0AYYym1AiVVmKcBwMaOI0Sp y0q8nrprnMmX6q9R+Ks87HN4U7Lj3NLs8vyCpyqNNJUp49vJGPwCXY2qItIgmkYw7g zH3CsiCCthebnqon9PrvuvHkO57o8qUaT27obqj4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730148AbgD1Szu (ORCPT ); Tue, 28 Apr 2020 14:55:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:47942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728619AbgD1ScC (ORCPT ); Tue, 28 Apr 2020 14:32:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 688DE21835; Tue, 28 Apr 2020 18:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098721; bh=pPmIFV+1g5lafog4sRGHQB4bxuzsE16raYDXiB2UHXA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yAFcM/RS63UB3Q4eBV2Q2TlPF4HT8a0O2ssGte32F3k/pIpePq/LzzkqWtP18pqB+ bjdkilb8dtJnFBHeAlkmuxi8W01pbgHVrfh2ZIt++/XGA/KVw3xmBhnoX2aWmWFDzx GNqm7vr7q6S6vWZr8L8lOE1KJzUPBHSWGXxT9SaI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lin Yi , Takashi Iwai Subject: [PATCH 5.6 103/167] ALSA: usx2y: Fix potential NULL dereference Date: Tue, 28 Apr 2020 20:24:39 +0200 Message-Id: <20200428182238.198596131@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182225.451225420@linuxfoundation.org> References: <20200428182225.451225420@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit 7686e3485253635c529cdd5f416fc640abaf076f upstream. The error handling code in usX2Y_rate_set() may hit a potential NULL dereference when an error occurs before allocating all us->urb[]. Add a proper NULL check for fixing the corner case. Reported-by: Lin Yi Cc: Link: https://lore.kernel.org/r/20200420075529.27203-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/usx2y/usbusx2yaudio.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/usb/usx2y/usbusx2yaudio.c +++ b/sound/usb/usx2y/usbusx2yaudio.c @@ -681,6 +681,8 @@ static int usX2Y_rate_set(struct usX2Yde us->submitted = 2*NOOF_SETRATE_URBS; for (i = 0; i < NOOF_SETRATE_URBS; ++i) { struct urb *urb = us->urb[i]; + if (!urb) + continue; if (urb->status) { if (!err) err = -ENODEV;