* [PATCH] power: reset: qcom-pon: reg write mask depends on pon generation
@ 2020-04-28 7:04 Kejia Hu
2020-04-28 19:18 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Kejia Hu @ 2020-04-28 7:04 UTC (permalink / raw)
To: agross, bjorn.andersson, sre, linux-pm, linux-arm-msm; +Cc: Kejia Hu
Instead of hardcode the mask, it should be depends
on which generation of pon it was.
Signed-off-by: Kejia Hu <kejia.hu@codethink.co.uk>
---
drivers/power/reset/qcom-pon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
index 22a743a0bf28..4a688741a88a 100644
--- a/drivers/power/reset/qcom-pon.c
+++ b/drivers/power/reset/qcom-pon.c
@@ -34,7 +34,8 @@ static int pm8916_reboot_mode_write(struct reboot_mode_driver *reboot,
ret = regmap_update_bits(pon->regmap,
pon->baseaddr + PON_SOFT_RB_SPARE,
- 0xfc, magic << pon->reason_shift);
+ GENMASK(7, pon->reason_shift),
+ magic << pon->reason_shift);
if (ret < 0)
dev_err(pon->dev, "update reboot mode bits failed\n");
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: reset: qcom-pon: reg write mask depends on pon generation
2020-04-28 7:04 [PATCH] power: reset: qcom-pon: reg write mask depends on pon generation Kejia Hu
@ 2020-04-28 19:18 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2020-04-28 19:18 UTC (permalink / raw)
To: Kejia Hu; +Cc: agross, bjorn.andersson, linux-pm, linux-arm-msm
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
Hi,
On Tue, Apr 28, 2020 at 08:04:37AM +0100, Kejia Hu wrote:
> Instead of hardcode the mask, it should be depends
> on which generation of pon it was.
>
> Signed-off-by: Kejia Hu <kejia.hu@codethink.co.uk>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/reset/qcom-pon.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
> index 22a743a0bf28..4a688741a88a 100644
> --- a/drivers/power/reset/qcom-pon.c
> +++ b/drivers/power/reset/qcom-pon.c
> @@ -34,7 +34,8 @@ static int pm8916_reboot_mode_write(struct reboot_mode_driver *reboot,
>
> ret = regmap_update_bits(pon->regmap,
> pon->baseaddr + PON_SOFT_RB_SPARE,
> - 0xfc, magic << pon->reason_shift);
> + GENMASK(7, pon->reason_shift),
> + magic << pon->reason_shift);
> if (ret < 0)
> dev_err(pon->dev, "update reboot mode bits failed\n");
>
> --
> 2.11.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-28 19:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 7:04 [PATCH] power: reset: qcom-pon: reg write mask depends on pon generation Kejia Hu
2020-04-28 19:18 ` Sebastian Reichel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.