All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH v1 15/35] acpi: Support writing an integer
Date: Tue, 28 Apr 2020 20:21:39 -0600	[thread overview]
Message-ID: <20200429022159.254271-13-sjg@chromium.org> (raw)
In-Reply-To: <20200429022159.254271-1-sjg@chromium.org>

ACPI supports storing integers in various ways. Add a function to handle
this.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v1: None

 include/acpi/acpigen.h | 17 ++++++++++++++
 lib/acpi/acpigen.c     | 51 ++++++++++++++++++++++++++++++++++++++++++
 test/dm/acpigen.c      | 46 +++++++++++++++++++++++++++++++++++++
 3 files changed, 114 insertions(+)

diff --git a/include/acpi/acpigen.h b/include/acpi/acpigen.h
index 52e0b75128..a4edcb097b 100644
--- a/include/acpi/acpigen.h
+++ b/include/acpi/acpigen.h
@@ -16,6 +16,12 @@ struct acpi_ctx;
 
 /* ACPI Op/Prefix codes */
 enum {
+	ZERO_OP			= 0x00,
+	ONE_OP			= 0x01,
+	BYTE_PREFIX		= 0x0a,
+	WORD_PREFIX		= 0x0b,
+	DWORD_PREFIX		= 0x0c,
+	QWORD_PREFIX		= 0x0e,
 	PACKAGE_OP		= 0x12,
 };
 
@@ -130,4 +136,15 @@ void acpigen_pop_len(struct acpi_ctx *ctx);
  */
 char *acpigen_write_package(struct acpi_ctx *ctx, int nr_el);
 
+/**
+ * acpigen_write_integer() - Write an integer
+ *
+ * This writes an operation (BYTE_OP, WORD_OP, DWORD_OP, QWORD_OP depending on
+ * the integer size) and an integer value. Note that WORD means 16 bits in ACPI.
+ *
+ * @ctx: ACPI context pointer
+ * @data: Integer to write
+ */
+void acpigen_write_integer(struct acpi_ctx *ctx, u64 data);
+
 #endif
diff --git a/lib/acpi/acpigen.c b/lib/acpi/acpigen.c
index ca9e96597e..01222533f2 100644
--- a/lib/acpi/acpigen.c
+++ b/lib/acpi/acpigen.c
@@ -81,6 +81,57 @@ char *acpigen_write_package(struct acpi_ctx *ctx, int nr_el)
 	return p;
 }
 
+void acpigen_write_byte(struct acpi_ctx *ctx, unsigned int data)
+{
+	acpigen_emit_byte(ctx, BYTE_PREFIX);
+	acpigen_emit_byte(ctx, data & 0xff);
+}
+
+void acpigen_write_word(struct acpi_ctx *ctx, unsigned int data)
+{
+	acpigen_emit_byte(ctx, WORD_PREFIX);
+	acpigen_emit_word(ctx, data);
+}
+
+void acpigen_write_dword(struct acpi_ctx *ctx, unsigned int data)
+{
+	acpigen_emit_byte(ctx, DWORD_PREFIX);
+	acpigen_emit_dword(ctx, data);
+}
+
+void acpigen_write_qword(struct acpi_ctx *ctx, u64 data)
+{
+	acpigen_emit_byte(ctx, QWORD_PREFIX);
+	acpigen_emit_dword(ctx, data & 0xffffffff);
+	acpigen_emit_dword(ctx, (data >> 32) & 0xffffffff);
+}
+
+void acpigen_write_zero(struct acpi_ctx *ctx)
+{
+	acpigen_emit_byte(ctx, ZERO_OP);
+}
+
+void acpigen_write_one(struct acpi_ctx *ctx)
+{
+	acpigen_emit_byte(ctx, ONE_OP);
+}
+
+void acpigen_write_integer(struct acpi_ctx *ctx, u64 data)
+{
+	if (data == 0)
+		acpigen_write_zero(ctx);
+	else if (data == 1)
+		acpigen_write_one(ctx);
+	else if (data <= 0xff)
+		acpigen_write_byte(ctx, (unsigned char)data);
+	else if (data <= 0xffff)
+		acpigen_write_word(ctx, (unsigned int)data);
+	else if (data <= 0xffffffff)
+		acpigen_write_dword(ctx, (unsigned int)data);
+	else
+		acpigen_write_qword(ctx, data);
+}
+
 void acpigen_emit_stream(struct acpi_ctx *ctx, const char *data, int size)
 {
 	int i;
diff --git a/test/dm/acpigen.c b/test/dm/acpigen.c
index be81068759..9350943a12 100644
--- a/test/dm/acpigen.c
+++ b/test/dm/acpigen.c
@@ -22,6 +22,11 @@
 #define TEST_STRING	"frogmore"
 #define TEST_STREAM2	"\xfa\xde"
 
+#define TEST_INT8	0x7d
+#define TEST_INT16	0x2345
+#define TEST_INT32	0x12345678
+#define TEST_INT64	0x4567890123456
+
 static int alloc_context_size(struct acpi_ctx **ctxp, int size)
 {
 	struct acpi_ctx *ctx;
@@ -421,3 +426,44 @@ static int dm_test_acpi_package(struct unit_test_state *uts)
 	return 0;
 }
 DM_TEST(dm_test_acpi_package, 0);
+
+/* Test emitting an integer */
+static int dm_test_acpi_integer(struct unit_test_state *uts)
+{
+	struct acpi_ctx *ctx;
+	u8 *ptr;
+
+	ut_assertok(alloc_context(&ctx));
+
+	ptr = acpigen_get_current(ctx);
+
+	acpigen_write_integer(ctx, 0);
+	acpigen_write_integer(ctx, 1);
+	acpigen_write_integer(ctx, TEST_INT8);
+	acpigen_write_integer(ctx, TEST_INT16);
+	acpigen_write_integer(ctx, TEST_INT32);
+	acpigen_write_integer(ctx, TEST_INT64);
+
+	ut_asserteq(6 + 1 + 2 + 4 + 8, acpigen_get_current(ctx) - ptr);
+
+	ut_asserteq(ZERO_OP, ptr[0]);
+
+	ut_asserteq(ONE_OP, ptr[1]);
+
+	ut_asserteq(BYTE_PREFIX, ptr[2]);
+	ut_asserteq(TEST_INT8, ptr[3]);
+
+	ut_asserteq(WORD_PREFIX, ptr[4]);
+	ut_asserteq(TEST_INT16, get_unaligned((u16 *)(ptr + 5)));
+
+	ut_asserteq(DWORD_PREFIX, ptr[7]);
+	ut_asserteq(TEST_INT32, get_unaligned((u32 *)(ptr + 8)));
+
+	ut_asserteq(QWORD_PREFIX, ptr[12]);
+	ut_asserteq_64(TEST_INT64, get_unaligned((u64 *)(ptr + 13)));
+
+	free_context(&ctx);
+
+	return 0;
+}
+DM_TEST(dm_test_acpi_integer, 0);
-- 
2.26.2.303.gf8c07b1a785-goog

  parent reply	other threads:[~2020-04-29  2:21 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  2:21 [PATCH v1 00/35] dm: Add programmatic generation of ACPI tables (part B) Simon Glass
2020-04-29  2:21 ` [PATCH v1 01/35] dm: core: Add an ACPI name for the root node Simon Glass
2020-04-30 12:44   ` Antwort: " Wolfgang Wallner
2020-04-29  2:21 ` [PATCH v1 02/35] acpi: Add a function to get a device path and scope Simon Glass
2020-04-29  2:21 ` [PATCH v1 03/35] acpi: Add a way to check device status Simon Glass
2020-04-29  2:21 ` [PATCH v1 04/35] irq: Add a method to convert an interrupt to ACPI Simon Glass
2020-04-29  2:21 ` [PATCH v1 05/35] acpi: Support generation of ACPI code Simon Glass
2020-04-29  2:21 ` [PATCH v1 06/35] acpi: Support generation of interrupt descriptor Simon Glass
2020-04-29  2:21 ` [PATCH v1 07/35] gpio: Add a method to convert a GPIO to ACPI Simon Glass
2020-04-29  2:21 ` [PATCH v1 08/35] acpi: Support string output Simon Glass
2020-04-29  2:21 ` [PATCH v1 09/35] acpi: Support generation of GPIO descriptor Simon Glass
2020-04-29  2:21 ` [PATCH v1 10/35] acpi: Support generation of a GPIO/irq for a device Simon Glass
2020-04-29  2:21 ` [PATCH v1 11/35] acpi: Support generation of I2C descriptor Simon Glass
2020-04-29  2:21 ` [PATCH v1 12/35] acpi: Support generation of SPI descriptor Simon Glass
2020-04-29  2:21 ` [PATCH v1 13/35] acpigen: Support writing a length Simon Glass
2020-04-29  2:21 ` [PATCH v1 14/35] acpigen: Support writing a package Simon Glass
2020-04-29  2:21 ` Simon Glass [this message]
2020-04-29  2:21 ` [PATCH v1 16/35] acpi: Support writing a string Simon Glass
2020-04-29  2:21 ` [PATCH v1 17/35] acpi: Support writing a name Simon Glass
2020-04-29  2:21 ` [PATCH v1 18/35] acpi: Support writing a UUID Simon Glass
2020-04-29  2:21 ` [PATCH v1 19/35] acpi: Support writing Device Properties objects via _DSD Simon Glass
2020-04-29  2:21 ` [PATCH v1 20/35] acpi: Support writing a GPIO Simon Glass
2020-04-29  2:21 ` [PATCH v1 21/35] acpi: Support copying properties from device tree to ACPI Simon Glass
2020-04-29  2:21 ` [PATCH v1 22/35] acpi: Add support for various misc ACPI opcodes Simon Glass
2020-04-29  2:21 ` [PATCH v1 23/35] acpi: Add support for writing a Power Resource Simon Glass
2020-04-29  2:21 ` [PATCH v1 24/35] acpi: Add support for writing a GPIO power sequence Simon Glass
2020-04-29  2:21 ` [PATCH v1 25/35] acpi: Add support for a generic " Simon Glass
2020-04-29  2:21 ` [PATCH v1 26/35] acpi: Add support for SSDT generation Simon Glass
2020-04-29  2:21 ` [PATCH v1 27/35] x86: acpi: Move MADT down a bit Simon Glass
2020-04-29  2:21 ` [PATCH v1 28/35] acpi: Record the items added to SSDT Simon Glass
2020-04-29  2:21 ` [PATCH v1 29/35] acpi: Support ordering SSDT data by device Simon Glass
2020-04-29  2:21 ` [PATCH v1 30/35] x86: Allow devices to write an SSDT Simon Glass
2020-04-29  2:21 ` [PATCH v1 31/35] acpi: Add support for DSDT generation Simon Glass
2020-04-29  2:21 ` [PATCH v1 32/35] x86: Allow devices to write to DSDT Simon Glass
2020-04-29  2:21 ` [PATCH v1 33/35] pci: Avoid a crash in device_is_on_pci_bus() Simon Glass
2020-04-29  2:21 ` [PATCH v1 34/35] dm: acpi: Enhance acpi_get_name() Simon Glass
2020-04-29  2:21 ` [PATCH v1 35/35] acpi: Add an acpi split command Simon Glass
2020-04-30 13:52 ` Antwort: [PATCH v1 02/35] acpi: Add a function to get a device path and scope Wolfgang Wallner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429022159.254271-13-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.