From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE352C83003 for ; Wed, 29 Apr 2020 07:21:18 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3D762076B for ; Wed, 29 Apr 2020 07:21:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qfHixOrw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3D762076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6FC1022DD3; Wed, 29 Apr 2020 07:21:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2y8gpYzxOtuB; Wed, 29 Apr 2020 07:21:17 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id A526A22DC7; Wed, 29 Apr 2020 07:21:17 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 84F51C0864; Wed, 29 Apr 2020 07:21:17 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2D041C0172 for ; Wed, 29 Apr 2020 07:21:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 11F4A81BD6 for ; Wed, 29 Apr 2020 07:21:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q6kL_zianK1h for ; Wed, 29 Apr 2020 07:21:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by fraxinus.osuosl.org (Postfix) with ESMTPS id ACBA881E4F for ; Wed, 29 Apr 2020 07:21:15 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id h4so772815wmb.4 for ; Wed, 29 Apr 2020 00:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cCAHFPkV5zKy0lOqNzgFSwfk1faaHM5kTxrOdR4mtV0=; b=qfHixOrwUj7Z+T5hUCKAQQvbwoGTrwpUbqxft4Z0FW7cxbhKzWmTTBcrbmTUBD1BCU UYUNL8rHAalDR3r/O6paaxcxkjvsqp7P1mGeGALESzQUvh8c5kchThOUHol9+MX9ZYce KNZQ6rVy/4tK5R/7/kVurzd47F+eU1zSHEz+Cigo9VwyWeF7gsbfbsLQWz7kZavXHbIk 30SKz/CXf60CiCh/5zaMuDwmvUWBwyjoytcRoYV/zZoV0F5YfA+1AFyVrjD/jHDMlYgv /XN9sVJ/XiKC2VgDHnvYRvYINP7ZhukoeZnh4AN+xJXKZ/fpSKQcSOBBO6lDA9qhTxPC Vqdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cCAHFPkV5zKy0lOqNzgFSwfk1faaHM5kTxrOdR4mtV0=; b=fBO+9IauqHIsMSI1l3LZ5gvDUfgQr9otl3L/AMaSOvFFeg7Csm+7IH1Hg8QFHB1kD4 DTUTKXThX3s9iUF6BGhoCtjfNwYFl5CxxpRmMhY/Eu4eR4dfG5zWJxbc3VZVEeROHT2p 75Nv8ctabmIsfjceTlzDpnZYeyL9lmS1I99YdLIJ4oRvlIgwjLCwlKslapJQFFfYBIaM vGO/aZxRAErCIwXiKb+TkzlN4gau6rvw+AhsuZa8KZak9SJuPt6DhQiowbP4SNkVP5hA BENBJ8X5T2ZtPE6NmN/T20qG+p+0PfH6U9RTJM+uMWcVqK4FAHv2lioP/sVNboffMfY5 dMEg== X-Gm-Message-State: AGi0PuYWQwoqrkZrraMOArN57aZIiFcN//qg6jQcLtlMxAS+ipZrn44V +B7doqzUddkSibsUACBPZNVrhg== X-Google-Smtp-Source: APiQypJs+3J3cKxM/LtgKzAvg7qC3vSLpX2ePy1LG0WB6A/JB3tF2dYB0tGSkd5NOoDj8qQAP2sJSw== X-Received: by 2002:a1c:4ca:: with SMTP id 193mr1629206wme.18.1588144874110; Wed, 29 Apr 2020 00:21:14 -0700 (PDT) Received: from myrica ([2001:171b:226e:c200:c43b:ef78:d083:b355]) by smtp.gmail.com with ESMTPSA id k3sm31836574wru.90.2020.04.29.00.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 00:21:13 -0700 (PDT) Date: Wed, 29 Apr 2020 09:21:04 +0200 From: Jean-Philippe Brucker To: Tuan Phan Subject: Re: [PATCH] perf/smmuv3: Allow sharing MMIO registers with the SMMU driver Message-ID: <20200429072104.GA817954@myrica> References: <20200421155745.19815-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Mark Rutland , Will Deacon , iommu@lists.linux-foundation.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Apr 28, 2020 at 11:10:09AM -0700, Tuan Phan wrote: > I tested this patch on HW, however I need to add one more following change to make it works Thanks for testing. I don't understand why you need the change below though, do you know which other region is conflicting with the SMMU? It should be displayed in the error message and /proc/iomem. Thanks, Jean > @@ -2854,7 +2854,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > } > ioaddr = res->start; > > - smmu->base = devm_ioremap_resource(dev, res); > + smmu->base = devm_ioremap(dev, res->start, resource_size(res)); > if (IS_ERR(smmu->base)) > return PTR_ERR(smmu->base); > > > > } else { > > smmu_pmu->reloc_base = smmu_pmu->reg_base; > > } > > -- > > 2.26.0 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B5B8C83007 for ; Wed, 29 Apr 2020 07:21:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68B0D2076B for ; Wed, 29 Apr 2020 07:21:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DRGMZRZt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qfHixOrw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68B0D2076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cToClxJBQUDfd7I5oygIaA6mxa0vc0ZQhIJzb6W3n3E=; b=DRGMZRZt78bzHZ po5hxlknFRjk3tSSCy+tmvQcPwobbleUCsxHmq0Pw/+SQN5eq/rufEZlOMViAuaX1qYPGVML7ieAV vyhqORSLZSA1CPrlfByTa/CbUi9z1dastHWZJYXwevJp5vhjOHlbkJG0lcnxt8KrF8ay4FWYQ81aL GyJv/WVWWUPCuxLXO2+pGtL/yCsJ3hZN9qoVtsBmRkujBamM8Wn4lUPSzeNtObAjrqf9boDiY6hIh f7GRCgyy4hnMoYPwkNs00nsl9n4uCeOmkeir5wlsOtzBZh3Qx+MmpAVlgzIl+u5nV9+dWbzOn4HjZ p3JB+nQccHr1NCamvqNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTh20-0005X0-8x; Wed, 29 Apr 2020 07:21:20 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTh1x-0005Vy-9O for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 07:21:18 +0000 Received: by mail-wm1-x342.google.com with SMTP id e26so765693wmk.5 for ; Wed, 29 Apr 2020 00:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cCAHFPkV5zKy0lOqNzgFSwfk1faaHM5kTxrOdR4mtV0=; b=qfHixOrwUj7Z+T5hUCKAQQvbwoGTrwpUbqxft4Z0FW7cxbhKzWmTTBcrbmTUBD1BCU UYUNL8rHAalDR3r/O6paaxcxkjvsqp7P1mGeGALESzQUvh8c5kchThOUHol9+MX9ZYce KNZQ6rVy/4tK5R/7/kVurzd47F+eU1zSHEz+Cigo9VwyWeF7gsbfbsLQWz7kZavXHbIk 30SKz/CXf60CiCh/5zaMuDwmvUWBwyjoytcRoYV/zZoV0F5YfA+1AFyVrjD/jHDMlYgv /XN9sVJ/XiKC2VgDHnvYRvYINP7ZhukoeZnh4AN+xJXKZ/fpSKQcSOBBO6lDA9qhTxPC Vqdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cCAHFPkV5zKy0lOqNzgFSwfk1faaHM5kTxrOdR4mtV0=; b=q8oC0N9zKNnfGCA86HDRRIFxxNn+afnhvYbZuDKtTNyK1tezb+X0FMP3jyr6WhESIl a+lW3tFwVjaFV1O6QsTR7Y9qCQEJWBeA1B0QHPXWEZteSAz8CVQCbfVRTw/AaMOkeCam hwk/IeWKxqfvKIHF3trPvz5djxbEbG9C012GPKXPA6e/huN+6qt7o594z0kzCRmZ9+zO H+baR8dSsC8eP+cHBmvtTuhG1n6UI1tp5O2wp2JGp7nKgnce0d909kuEBOe/+9bTGke8 Q6dr+9TPI5d1ru2W6DfmH1728XUWb+zpfh0E01qMRg/pslylN6Urc5PSg/B+O6RyjMqm Wmlw== X-Gm-Message-State: AGi0PuZzc9kcZgpuTTXRzXMb5vFr82D2wMCHFgYyLnTBfHSYOvLFf2Dr CyeQY+HR4xO2K4ENPigQ6i868A== X-Google-Smtp-Source: APiQypJs+3J3cKxM/LtgKzAvg7qC3vSLpX2ePy1LG0WB6A/JB3tF2dYB0tGSkd5NOoDj8qQAP2sJSw== X-Received: by 2002:a1c:4ca:: with SMTP id 193mr1629206wme.18.1588144874110; Wed, 29 Apr 2020 00:21:14 -0700 (PDT) Received: from myrica ([2001:171b:226e:c200:c43b:ef78:d083:b355]) by smtp.gmail.com with ESMTPSA id k3sm31836574wru.90.2020.04.29.00.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 00:21:13 -0700 (PDT) Date: Wed, 29 Apr 2020 09:21:04 +0200 From: Jean-Philippe Brucker To: Tuan Phan Subject: Re: [PATCH] perf/smmuv3: Allow sharing MMIO registers with the SMMU driver Message-ID: <20200429072104.GA817954@myrica> References: <20200421155745.19815-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_002117_357810_F35448E7 X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , lorenzo.pieralisi@arm.com, Will Deacon , iommu@lists.linux-foundation.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 28, 2020 at 11:10:09AM -0700, Tuan Phan wrote: > I tested this patch on HW, however I need to add one more following change to make it works Thanks for testing. I don't understand why you need the change below though, do you know which other region is conflicting with the SMMU? It should be displayed in the error message and /proc/iomem. Thanks, Jean > @@ -2854,7 +2854,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > } > ioaddr = res->start; > > - smmu->base = devm_ioremap_resource(dev, res); > + smmu->base = devm_ioremap(dev, res->start, resource_size(res)); > if (IS_ERR(smmu->base)) > return PTR_ERR(smmu->base); > > > > } else { > > smmu_pmu->reloc_base = smmu_pmu->reg_base; > > } > > -- > > 2.26.0 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel