[OE-core][PATCH] nfs-utils: fix configure error on some hosts

[OE-core][PATCH] nfs-utils: fix configure error on some hosts

[Chen Qi]

nfs-utils' configure.ac hardcodes the rpcgen's searching path. However,
on some hosts, rpcgen is missing but SDK provides one. We should avoid
the hardcoding so that nfs-utils could be built correctly under SDK.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 ...gure.ac-avoid-hardcoding-rpcgen-path.patch | 31 +++++++++++++++++++
 .../nfs-utils/nfs-utils_2.4.3.bb              |  1 +
 2 files changed, 32 insertions(+)
 create mode 100644 meta/recipes-connectivity/nfs-utils/nfs-utils/0001-configure.ac-avoid-hardcoding-rpcgen-path.patch

diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-configure.ac-avoid-hardcoding-rpcgen-path.patch b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-configure.ac-avoid-hardcoding-rpcgen-path.patch
new file mode 100644
index 0000000000..5602e5be57
--- /dev/null
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-configure.ac-avoid-hardcoding-rpcgen-path.patch
@@ -0,0 +1,31 @@
+From b9049fbf051e559941298afd57ec43d6f6a5490d Mon Sep 17 00:00:00 2001
+From: Chen Qi <Qi.Chen@windriver.com>
+Date: Wed, 29 Apr 2020 08:56:05 +0000
+Subject: [PATCH] configure.ac: avoid hardcoding rpcgen path
+
+Upstream-Status: Pending
+
+Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
+---
+ configure.ac | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index f9efdb7..8e8aeaa 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -152,8 +152,9 @@ AC_ARG_WITH(rpcgen,
+ 	rpcgen_cflags=-Werror=strict-prototypes
+ 	RPCGEN_PATH=
+ 	if test "$rpcgen_path" = "yes"; then
+-	    for p in /usr/local/bin/rpcgen /usr/bin/rpcgen /bin/rpcgen
+-	    do if test -f $p ; then RPCGEN_PATH=$p ; break; fi ; done
++	    #for p in /usr/local/bin/rpcgen /usr/bin/rpcgen /bin/rpcgen
++	    #do if test -f $p ; then RPCGEN_PATH=$p ; break; fi ; done
++	    RPCGEN_PATH=`which rpcgen`
+ 		if test -z "$RPCGEN_PATH"; then
+ 			AC_MSG_ERROR([Please install rpcgen or use --with-rpcgen])
+ 		fi
+-- 
+2.24.1
+
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb
index 9bdb6f4ae4..05877d57f1 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb
@@ -31,6 +31,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x
            file://0001-cacheio-use-intmax_t-for-formatted-IO.patch \
            file://0001-Makefile.am-fix-undefined-function-for-libnsm.a.patch \
            file://clang-warnings.patch \
+           file://0001-configure.ac-avoid-hardcoding-rpcgen-path.patch \
            "
 SRC_URI[md5sum] = "06020c76f531ed97f3145514901e0e7c"
 SRC_URI[sha256sum] = "af65fce5dd8370cff9ead67baac5a6cd69c376dcadfef264dc2c78c904f26599"
-- 
2.17.1

Re: [OE-core][PATCH] nfs-utils: fix configure error on some hosts

[Khem Raj]

On 4/29/20 2:00 AM, Chen Qi wrote:
> nfs-utils' configure.ac hardcodes the rpcgen's searching path. However,
> on some hosts, rpcgen is missing but SDK provides one. We should avoid
> the hardcoding so that nfs-utils could be built correctly under SDK.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   ...gure.ac-avoid-hardcoding-rpcgen-path.patch | 31 +++++++++++++++++++
>   .../nfs-utils/nfs-utils_2.4.3.bb              |  1 +
>   2 files changed, 32 insertions(+)
>   create mode 100644 meta/recipes-connectivity/nfs-utils/nfs-utils/0001-configure.ac-avoid-hardcoding-rpcgen-path.patch
> 
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-configure.ac-avoid-hardcoding-rpcgen-path.patch b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-configure.ac-avoid-hardcoding-rpcgen-path.patch
> new file mode 100644
> index 0000000000..5602e5be57
> --- /dev/null
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-configure.ac-avoid-hardcoding-rpcgen-path.patch
> @@ -0,0 +1,31 @@
> +From b9049fbf051e559941298afd57ec43d6f6a5490d Mon Sep 17 00:00:00 2001
> +From: Chen Qi <Qi.Chen@windriver.com>
> +Date: Wed, 29 Apr 2020 08:56:05 +0000
> +Subject: [PATCH] configure.ac: avoid hardcoding rpcgen path
> +
> +Upstream-Status: Pending
> +
> +Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> +---
> + configure.ac | 5 +++--
> + 1 file changed, 3 insertions(+), 2 deletions(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index f9efdb7..8e8aeaa 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -152,8 +152,9 @@ AC_ARG_WITH(rpcgen,
> + 	rpcgen_cflags=-Werror=strict-prototypes
> + 	RPCGEN_PATH=
> + 	if test "$rpcgen_path" = "yes"; then
> +-	    for p in /usr/local/bin/rpcgen /usr/bin/rpcgen /bin/rpcgen
> +-	    do if test -f $p ; then RPCGEN_PATH=$p ; break; fi ; done
> ++	    #for p in /usr/local/bin/rpcgen /usr/bin/rpcgen /bin/rpcgen
> ++	    #do if test -f $p ; then RPCGEN_PATH=$p ; break; fi ; done
> ++	    RPCGEN_PATH=`which rpcgen`

Perhaps pass it via configure argument, since which can find random 
version too.

> + 		if test -z "$RPCGEN_PATH"; then
> + 			AC_MSG_ERROR([Please install rpcgen or use --with-rpcgen])
> + 		fi
> +--
> +2.24.1
> +
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb
> index 9bdb6f4ae4..05877d57f1 100644
> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb
> @@ -31,6 +31,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x
>              file://0001-cacheio-use-intmax_t-for-formatted-IO.patch \
>              file://0001-Makefile.am-fix-undefined-function-for-libnsm.a.patch \
>              file://clang-warnings.patch \
> +           file://0001-configure.ac-avoid-hardcoding-rpcgen-path.patch \
>              "
>   SRC_URI[md5sum] = "06020c76f531ed97f3145514901e0e7c"
>   SRC_URI[sha256sum] = "af65fce5dd8370cff9ead67baac5a6cd69c376dcadfef264dc2c78c904f26599"
> 
> 
> 
>