Re: [RFC 06/17] drm: i915: fix sg_table nents vs. orig_nents misuse

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4383 bytes --]

Hi Marek,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on drm-exynos/exynos-drm-next]
[also build test WARNING on next-20200428]
[cannot apply to drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master v5.7-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Marek-Szyprowski/DRM-fix-struct-sg_table-nents-vs-orig_nents-misuse/20200429-040352
base:   https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
config: x86_64-randconfig-g003-20200428 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/asm-generic/bug.h:5:0,
                    from arch/x86/include/asm/bug.h:83,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:15,
                    from drivers/gpu/drm/i915/i915_gem_gtt.c:7:
   drivers/gpu/drm/i915/i915_gem_gtt.c: In function 'i915_gem_gtt_prepare_pages':
   drivers/gpu/drm/i915/i915_gem_gtt.c:35:7: error: 'page' undeclared (first use in this function)
      if (page->nents)
          ^
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                       ^~~~
>> drivers/gpu/drm/i915/i915_gem_gtt.c:35:3: note: in expansion of macro 'if'
      if (page->nents)
      ^~
   drivers/gpu/drm/i915/i915_gem_gtt.c:35:7: note: each undeclared identifier is reported only once for each function it appears in
      if (page->nents)
          ^
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                       ^~~~
>> drivers/gpu/drm/i915/i915_gem_gtt.c:35:3: note: in expansion of macro 'if'
      if (page->nents)
      ^~

vim +/if +35 drivers/gpu/drm/i915/i915_gem_gtt.c

   > 7	#include <linux/slab.h> /* fault-inject.h is not standalone! */
     8	
     9	#include <linux/fault-inject.h>
    10	#include <linux/log2.h>
    11	#include <linux/random.h>
    12	#include <linux/seq_file.h>
    13	#include <linux/stop_machine.h>
    14	
    15	#include <asm/set_memory.h>
    16	#include <asm/smp.h>
    17	
    18	#include "display/intel_frontbuffer.h"
    19	#include "gt/intel_gt.h"
    20	#include "gt/intel_gt_requests.h"
    21	
    22	#include "i915_drv.h"
    23	#include "i915_scatterlist.h"
    24	#include "i915_trace.h"
    25	#include "i915_vgpu.h"
    26	
    27	int i915_gem_gtt_prepare_pages(struct drm_i915_gem_object *obj,
    28				       struct sg_table *pages)
    29	{
    30		do {
    31			pages->nents = dma_map_sg_attrs(&obj->base.dev->pdev->dev,
    32							pages->sgl, pages->orig_nents,
    33							PCI_DMA_BIDIRECTIONAL,
    34							DMA_ATTR_NO_WARN);
  > 35			if (page->nents)
    36				return 0;
    37	
    38			/*
    39			 * If the DMA remap fails, one cause can be that we have
    40			 * too many objects pinned in a small remapping table,
    41			 * such as swiotlb. Incrementally purge all other objects and
    42			 * try again - if there are no more pages to remove from
    43			 * the DMA remapper, i915_gem_shrink will return 0.
    44			 */
    45			GEM_BUG_ON(obj->mm.pages == pages);
    46		} while (i915_gem_shrink(to_i915(obj->base.dev),
    47					 obj->base.size >> PAGE_SHIFT, NULL,
    48					 I915_SHRINK_BOUND |
    49					 I915_SHRINK_UNBOUND));
    50	
    51		return -ENOSPC;
    52	}
    53	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37022 bytes --]