From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12EEC83007 for ; Wed, 29 Apr 2020 11:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBD0B2087E for ; Wed, 29 Apr 2020 11:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="mzigDqR6"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="LixaC0mQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbgD2Lq7 (ORCPT ); Wed, 29 Apr 2020 07:46:59 -0400 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:37589 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgD2Lq6 (ORCPT ); Wed, 29 Apr 2020 07:46:58 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 4E60771A; Wed, 29 Apr 2020 07:46:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 29 Apr 2020 07:46:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=GNg8N4MpEqbpY0+HdKjq545IT9a sX3IFSheqvawzyns=; b=mzigDqR66/wPW6d/Bl2C6VS0hPS23t0ag/Vl+wjE8za zjZiu50YzDnQlwZAprMvwgpAHXCdaBOHOn3zDwQWELdd6fPoptIOUHFXivmwP9h3 0rlslxuMoJZG4WWEUzZIHYP7W2XedQ5kpJoRjXP7Z16m3B5tNl4wOMmo5H42uxFf zQIbVxYciIIzeTKTMLDmJ64xmAitW9VZjguBOB7xksDVr9L3Ph684Kl3+rBDir6Y tgHSJ6hvI2MqOf6URFJsy2/RmpfgYS/nYX1OYDJ+99Px3erzP/RfEatYs52t4g8i +t95Xu/YSIZunEzmnlxshZoLjrmfzaMX5o5UXfCIocQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GNg8N4 MpEqbpY0+HdKjq545IT9asX3IFSheqvawzyns=; b=LixaC0mQ3xBTYJ9RoIE53l vwV8UAJeauGMHhNsM9t7hC6sdDGMKqidJIaTmQuOIjENWrIellzoEtXhd7g3Rxkc C/f1orJ37Pm486aNRxv+aCuGpVL85Vy1bsNHXE59mVdEkNiJkxeUdF6I9hNeAEPC oLcnPJbcQDvA4L8QUoUoUqIJglmwi19EhbgHteDpMy3e75QwBuhiC3Jctb/O5Qgz RA9hLcTT0ZcPhWsv0tBO4VIHYl1x14/DPhj8UO2+x5lXT/Th1jSVxc+oZpreYjS4 fbiySOseihBiuBARr3iFYRZaGR4MLhSY7qk2XLvyjHgF//yXtunHN+IWacnC1VyA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieefgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucfkphepledtrd ekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id E96CC3065EEB; Wed, 29 Apr 2020 07:46:54 -0400 (EDT) Date: Wed, 29 Apr 2020 13:46:53 +0200 From: Maxime Ripard To: Robert Foss Cc: Sakari Ailus , Andy Shevchenko , Marco Felsch , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Dongchun Zhu , Fabio Estevam , Tomasz Figa Subject: Re: [PATCH v5 v5 2/3] media: ov8856: Add devicetree support Message-ID: <20200429114653.ifzi4z2qzpys4i4q@gilmour.lan> References: <20200428180718.1609826-1-robert.foss@linaro.org> <20200428180718.1609826-2-robert.foss@linaro.org> <20200429090012.vhhwatojkncjquwd@gilmour.lan> <20200429111307.GA867@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4e2ce4wi52h6jxye" Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4e2ce4wi52h6jxye Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 29, 2020 at 01:39:12PM +0200, Robert Foss wrote: > On Wed, 29 Apr 2020 at 13:13, Sakari Ailus wrote: > > > > Hi Robert, Maxime, > > > > On Wed, Apr 29, 2020 at 12:19:38PM +0200, Robert Foss wrote: > > > On Wed, 29 Apr 2020 at 11:00, Maxime Ripard wrote: > > > > > > > > Hi, > > > > > > > > On Tue, Apr 28, 2020 at 08:07:17PM +0200, Robert Foss wrote: > > > > > Add match table, enable ov8856_probe() to support > > > > > both ACPI and DT modes. > > > > > > > > > > ACPI and DT modes are primarily distinguished from > > > > > each other by relying on devm_XXX_get_optional() > > > > > will return NULL instead of a reference for the > > > > > desired managed resource. > > > > > > > > > > Signed-off-by: Robert Foss > > > > > --- > > > > > > > > > > - Changes since v4: > > > > > * Maxime & Sakari: Switch to clock-frequency > > > > > > > > > > - Changes since v3: > > > > > * Remove redundant {}-brackets > > > > > * Compare xvclk_rate to 5% tolerance > > > > > * Andy: Use dev_fwnode() > > > > > * Andy: Use %pe instead of %ld + PTR_ERR() > > > > > * Andy: Invert reset_gpio logic > > > > > * Andy: Remove dev_dbg() from failing reset_gpio setup > > > > > * Andy: Use dev_err for logging for failures > > > > > * Andy: Remove dev_warn from EDEFER/regulator error path > > > > > * Andy & Sakari: Replaced GPIOD_OUT_XXX with 0/1 > > > > > * Maxime & Sakari: Verify clock frequency from DT > > > > > * Sakari: Verify the 'xvclk_rate' is set correctly for ACPI/DT = devices > > > > > * Sakari: Remove duplicate ov8856->dev assignment > > > > > > > > > > - Changes since v2: > > > > > * Added "struct device *dev" member to struct ov8856 > > > > > * Andy: Switch to optional version of devm_gpiod_get > > > > > * Andy: Switch to optional version of devm_clk_get > > > > > * Fabio: Add reset sleep period > > > > > * Sakari: Unify defines for 19.2Mhz > > > > > * Sakari: Remove 24Mhz clock, since it isn't needed for support= ed modes > > > > > * Sakari: Replace dev_info() with dev_dbg() > > > > > * Sakari: Switch induction variable type to unsigned > > > > > * Sakari: Don't wait for reset_gpio when in ACPI mode > > > > > * Sakari: Pull reset GPIO high on power on failure > > > > > * Sakari: Add power on/off to resume/suspend > > > > > * Sakari: Fix indentation > > > > > * Sakari: Power off during ov8856_remove() > > > > > * Sakari: Don't sleep during power-on in ACPI mode > > > > > * Sakari: Switch to getting xvclk from clk_get_rate > > > > > > > > > > - Changes since v1: > > > > > * Andy & Sakari: Make XVCLK optional since to not break ACPI > > > > > * Fabio: Change n_shutdown_gpio name to reset_gpio > > > > > * Fabio: Invert reset_gpio due to GPIO_ACTIVE_HIGH -> GPIO_ACTI= VE_LOW change > > > > > * Fabio: Remove empty line > > > > > * Fabio: Remove real error from devm_gpiod_get() failures > > > > > * Sakari: ARRAY_SIZE() directly instead of through OV8856_NUM_S= UPPLIES > > > > > * Sakari: Use XVCLK rate as provided by DT > > > > > > > > > > drivers/media/i2c/ov8856.c | 139 +++++++++++++++++++++++++++++++= ++---- > > > > > 1 file changed, 126 insertions(+), 13 deletions(-) > > > > > > > > > > diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov885= 6.c > > > > > index 8655842af275..48b02b8d205f 100644 > > > > > --- a/drivers/media/i2c/ov8856.c > > > > > +++ b/drivers/media/i2c/ov8856.c > > > > > @@ -3,10 +3,13 @@ > > > > > > > > > > #include > > > > > #include > > > > > +#include > > > > > #include > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > @@ -18,7 +21,7 @@ > > > > > #define OV8856_LINK_FREQ_360MHZ 360000000ULL > > > > > #define OV8856_LINK_FREQ_180MHZ 180000000ULL > > > > > #define OV8856_SCLK 144000000ULL > > > > > -#define OV8856_MCLK 19200000 > > > > > +#define OV8856_XVCLK_19_2 19200000 > > > > > #define OV8856_DATA_LANES 4 > > > > > #define OV8856_RGB_DEPTH 10 > > > > > > > > > > @@ -64,6 +67,12 @@ > > > > > > > > > > #define to_ov8856(_sd) container_of(_sd, s= truct ov8856, sd) > > > > > > > > > > +static const char * const ov8856_supply_names[] =3D { > > > > > + "dovdd", /* Digital I/O power */ > > > > > + "avdd", /* Analog power */ > > > > > + "dvdd", /* Digital core power */ > > > > > +}; > > > > > + > > > > > enum { > > > > > OV8856_LINK_FREQ_720MBPS, > > > > > OV8856_LINK_FREQ_360MBPS, > > > > > @@ -566,6 +575,11 @@ struct ov8856 { > > > > > struct media_pad pad; > > > > > struct v4l2_ctrl_handler ctrl_handler; > > > > > > > > > > + struct device *dev; > > > > > + struct clk *xvclk; > > > > > + struct gpio_desc *reset_gpio; > > > > > + struct regulator_bulk_data supplies[ARRAY_SIZE(ov8856_suppl= y_names)]; > > > > > + > > > > > /* V4L2 Controls */ > > > > > struct v4l2_ctrl *link_freq; > > > > > struct v4l2_ctrl *pixel_rate; > > > > > @@ -908,6 +922,52 @@ static int ov8856_set_stream(struct v4l2_sub= dev *sd, int enable) > > > > > return ret; > > > > > } > > > > > > > > > > +static int __ov8856_power_on(struct ov8856 *ov8856) > > > > > +{ > > > > > + struct i2c_client *client =3D v4l2_get_subdevdata(&ov8856->= sd); > > > > > + int ret; > > > > > + > > > > > + ret =3D clk_prepare_enable(ov8856->xvclk); > > > > > + if (ret < 0) { > > > > > + dev_err(&client->dev, "failed to enable xvclk\n"); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + if (is_acpi_node(dev_fwnode(ov8856->dev))) > > > > > + return 0; > > > > > + > > > > > + if (ov8856->reset_gpio) { > > > > > + gpiod_set_value_cansleep(ov8856->reset_gpio, 1); > > > > > + usleep_range(1000, 2000); > > > > > + } > > > > > + > > > > > + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov8856_supply_name= s), > > > > > + ov8856->supplies); > > > > > + if (ret < 0) { > > > > > + dev_err(&client->dev, "failed to enable regulators\= n"); > > > > > + goto disable_clk; > > > > > + } > > > > > + > > > > > + gpiod_set_value_cansleep(ov8856->reset_gpio, 0); > > > > > + usleep_range(1500, 1800); > > > > > + > > > > > + return 0; > > > > > + > > > > > +disable_clk: > > > > > + gpiod_set_value_cansleep(ov8856->reset_gpio, 1); > > > > > + clk_disable_unprepare(ov8856->xvclk); > > > > > + > > > > > + return ret; > > > > > +} > > > > > + > > > > > +static void __ov8856_power_off(struct ov8856 *ov8856) > > > > > +{ > > > > > + gpiod_set_value_cansleep(ov8856->reset_gpio, 1); > > > > > + regulator_bulk_disable(ARRAY_SIZE(ov8856_supply_names), > > > > > + ov8856->supplies); > > > > > + clk_disable_unprepare(ov8856->xvclk); > > > > > +} > > > > > + > > > > > static int __maybe_unused ov8856_suspend(struct device *dev) > > > > > { > > > > > struct i2c_client *client =3D to_i2c_client(dev); > > > > > @@ -918,6 +978,7 @@ static int __maybe_unused ov8856_suspend(stru= ct device *dev) > > > > > if (ov8856->streaming) > > > > > ov8856_stop_streaming(ov8856); > > > > > > > > > > + __ov8856_power_off(ov8856); > > > > > mutex_unlock(&ov8856->mutex); > > > > > > > > > > return 0; > > > > > @@ -931,6 +992,8 @@ static int __maybe_unused ov8856_resume(struc= t device *dev) > > > > > int ret; > > > > > > > > > > mutex_lock(&ov8856->mutex); > > > > > + > > > > > + __ov8856_power_on(ov8856); > > > > > if (ov8856->streaming) { > > > > > ret =3D ov8856_start_streaming(ov8856); > > > > > if (ret) { > > > > > @@ -1092,29 +1155,58 @@ static int ov8856_identify_module(struct = ov8856 *ov8856) > > > > > return 0; > > > > > } > > > > > > > > > > -static int ov8856_check_hwcfg(struct device *dev) > > > > > +static int ov8856_get_hwcfg(struct ov8856 *ov8856) > > > > > { > > > > > + struct device *dev =3D ov8856->dev; > > > > > struct fwnode_handle *ep; > > > > > struct fwnode_handle *fwnode =3D dev_fwnode(dev); > > > > > struct v4l2_fwnode_endpoint bus_cfg =3D { > > > > > .bus_type =3D V4L2_MBUS_CSI2_DPHY > > > > > }; > > > > > - u32 mclk; > > > > > + u32 xvclk_rate; > > > > > int ret; > > > > > unsigned int i, j; > > > > > > > > > > if (!fwnode) > > > > > return -ENXIO; > > > > > > > > > > - ret =3D fwnode_property_read_u32(fwnode, "clock-frequency",= &mclk); > > > > > + ret =3D fwnode_property_read_u32(fwnode, "clock-frequency", > > > > > + &xvclk_rate); > > > > > if (ret) > > > > > return ret; > > > > > > > > > > - if (mclk !=3D OV8856_MCLK) { > > > > > - dev_err(dev, "external clock %d is not supported", = mclk); > > > > > + if (!is_acpi_node(fwnode)) { > > > > > + ov8856->xvclk =3D devm_clk_get(dev, "xvclk"); > > > > > + if (IS_ERR(ov8856->xvclk)) { > > > > > + dev_err(dev, "could not get xvclk clock (%p= e)\n", > > > > > + ov8856->xvclk); > > > > > + return PTR_ERR(ov8856->xvclk); > > > > > + } > > > > > + > > > > > + clk_set_rate(ov8856->xvclk, xvclk_rate); > > > > > + xvclk_rate =3D clk_get_rate(ov8856->xvclk); > > > > > + } > > > > > + > > > > > + /* external clock must be 19.2MHz, allow 5% tolerance */ > > > > > > > > Where is that 5% tolerance coming from? Experimentations, datasheet= s, something > > > > that looks good enough? Either way, this should be in the comment. > > > > > > I don't have access to the full datasheet unfortunately. A 24Mhz rate > > > is as far as I understand it supported and required for higher > > > bandwidth count modes. > > > It was suggested to me that adding a tolerance is the best practice, > > > the ov5645 driver uses a 1% tolerance, which may be more appropriate. > > > > The frequency should really be exact. Sometimes what happens is, howeve= r, > > that a register list based driver does not have the register lists for a > > frequency that is available on a given system. That's why some drivers = have > > allowed some difference to the intended frequency. > > > > That 5 % seems like a random value, just like any other number that dif= fers > > from the exact frequency would be. > > > > I'd issue a warning if the frequency differs from what was intended, but > > still proceed with probe. This way we can make sure the difference is n= oted > > while boards that cannot provide the exact frequency supported by the > > driver can still function. >=20 > Issuing a warning sounds like a good solution to me. What do you think Ma= xime? Sounds good to me too :) Maxime --4e2ce4wi52h6jxye Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXqlpLQAKCRDj7w1vZxhR xfy5AP9WB6qj36xGc19gDUzaiYtAzYINqK4aVmuNMeieKOESdAD/X643GOOZCaKS +tW21zB5c9ZbIZnEBKZ9vft+BXIJjQw= =khOj -----END PGP SIGNATURE----- --4e2ce4wi52h6jxye-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B60C83003 for ; Wed, 29 Apr 2020 11:47:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 050A82073E for ; Wed, 29 Apr 2020 11:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ugdSIIEy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="mzigDqR6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="LixaC0mQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 050A82073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YHeZrscoREIQ47opjVVVpflCPX8JDqGQmy/lXQrzP/Y=; b=ugdSIIEyBd9R5a6jbe8RgABGL g8H+d2d0++gQbaQq0eQR0s7SYXYdZm8TYa2KT/pOBnfo0q/vAbNvLnVjd29cj6Eoo3D6gcQRO56bz agYHhtkpzRnRB4vJFB9hfGmqY7OahBlM2xH74BEDT+pl8UI8vdI0z1msDy5uj0fqFJnN/zgSM3Cb2 N9/e+W8luOPR7EzGPOyzbRQSFf9dwAJfkfY3TrmJLYcls2QvDfilrSzhjlpYIYza3loYbYBR89zqr nm3Wsz7saThKNPAHqiXwrXcyMsPLuK2iiDJ5b22DETwr1v/+bOaB9HJPJfrdFmgSnb9uoDI055e0Z Ah7XrapYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTlB9-0006KS-Oz; Wed, 29 Apr 2020 11:47:03 +0000 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTlB4-0006JJ-Co for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 11:47:01 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 4E60771A; Wed, 29 Apr 2020 07:46:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 29 Apr 2020 07:46:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=GNg8N4MpEqbpY0+HdKjq545IT9a sX3IFSheqvawzyns=; b=mzigDqR66/wPW6d/Bl2C6VS0hPS23t0ag/Vl+wjE8za zjZiu50YzDnQlwZAprMvwgpAHXCdaBOHOn3zDwQWELdd6fPoptIOUHFXivmwP9h3 0rlslxuMoJZG4WWEUzZIHYP7W2XedQ5kpJoRjXP7Z16m3B5tNl4wOMmo5H42uxFf zQIbVxYciIIzeTKTMLDmJ64xmAitW9VZjguBOB7xksDVr9L3Ph684Kl3+rBDir6Y tgHSJ6hvI2MqOf6URFJsy2/RmpfgYS/nYX1OYDJ+99Px3erzP/RfEatYs52t4g8i +t95Xu/YSIZunEzmnlxshZoLjrmfzaMX5o5UXfCIocQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GNg8N4 MpEqbpY0+HdKjq545IT9asX3IFSheqvawzyns=; b=LixaC0mQ3xBTYJ9RoIE53l vwV8UAJeauGMHhNsM9t7hC6sdDGMKqidJIaTmQuOIjENWrIellzoEtXhd7g3Rxkc C/f1orJ37Pm486aNRxv+aCuGpVL85Vy1bsNHXE59mVdEkNiJkxeUdF6I9hNeAEPC oLcnPJbcQDvA4L8QUoUoUqIJglmwi19EhbgHteDpMy3e75QwBuhiC3Jctb/O5Qgz RA9hLcTT0ZcPhWsv0tBO4VIHYl1x14/DPhj8UO2+x5lXT/Th1jSVxc+oZpreYjS4 fbiySOseihBiuBARr3iFYRZaGR4MLhSY7qk2XLvyjHgF//yXtunHN+IWacnC1VyA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieefgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucfkphepledtrd ekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id E96CC3065EEB; Wed, 29 Apr 2020 07:46:54 -0400 (EDT) Date: Wed, 29 Apr 2020 13:46:53 +0200 From: Maxime Ripard To: Robert Foss Subject: Re: [PATCH v5 v5 2/3] media: ov8856: Add devicetree support Message-ID: <20200429114653.ifzi4z2qzpys4i4q@gilmour.lan> References: <20200428180718.1609826-1-robert.foss@linaro.org> <20200428180718.1609826-2-robert.foss@linaro.org> <20200429090012.vhhwatojkncjquwd@gilmour.lan> <20200429111307.GA867@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_044659_807945_E4A5C46F X-CRM114-Status: GOOD ( 31.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tomasz Figa , Marco Felsch , linux-kernel , Sakari Ailus , Dongchun Zhu , Andy Shevchenko , Fabio Estevam , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-media Content-Type: multipart/mixed; boundary="===============1920743208417749558==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1920743208417749558== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4e2ce4wi52h6jxye" Content-Disposition: inline --4e2ce4wi52h6jxye Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 29, 2020 at 01:39:12PM +0200, Robert Foss wrote: > On Wed, 29 Apr 2020 at 13:13, Sakari Ailus wrote: > > > > Hi Robert, Maxime, > > > > On Wed, Apr 29, 2020 at 12:19:38PM +0200, Robert Foss wrote: > > > On Wed, 29 Apr 2020 at 11:00, Maxime Ripard wrote: > > > > > > > > Hi, > > > > > > > > On Tue, Apr 28, 2020 at 08:07:17PM +0200, Robert Foss wrote: > > > > > Add match table, enable ov8856_probe() to support > > > > > both ACPI and DT modes. > > > > > > > > > > ACPI and DT modes are primarily distinguished from > > > > > each other by relying on devm_XXX_get_optional() > > > > > will return NULL instead of a reference for the > > > > > desired managed resource. > > > > > > > > > > Signed-off-by: Robert Foss > > > > > --- > > > > > > > > > > - Changes since v4: > > > > > * Maxime & Sakari: Switch to clock-frequency > > > > > > > > > > - Changes since v3: > > > > > * Remove redundant {}-brackets > > > > > * Compare xvclk_rate to 5% tolerance > > > > > * Andy: Use dev_fwnode() > > > > > * Andy: Use %pe instead of %ld + PTR_ERR() > > > > > * Andy: Invert reset_gpio logic > > > > > * Andy: Remove dev_dbg() from failing reset_gpio setup > > > > > * Andy: Use dev_err for logging for failures > > > > > * Andy: Remove dev_warn from EDEFER/regulator error path > > > > > * Andy & Sakari: Replaced GPIOD_OUT_XXX with 0/1 > > > > > * Maxime & Sakari: Verify clock frequency from DT > > > > > * Sakari: Verify the 'xvclk_rate' is set correctly for ACPI/DT = devices > > > > > * Sakari: Remove duplicate ov8856->dev assignment > > > > > > > > > > - Changes since v2: > > > > > * Added "struct device *dev" member to struct ov8856 > > > > > * Andy: Switch to optional version of devm_gpiod_get > > > > > * Andy: Switch to optional version of devm_clk_get > > > > > * Fabio: Add reset sleep period > > > > > * Sakari: Unify defines for 19.2Mhz > > > > > * Sakari: Remove 24Mhz clock, since it isn't needed for support= ed modes > > > > > * Sakari: Replace dev_info() with dev_dbg() > > > > > * Sakari: Switch induction variable type to unsigned > > > > > * Sakari: Don't wait for reset_gpio when in ACPI mode > > > > > * Sakari: Pull reset GPIO high on power on failure > > > > > * Sakari: Add power on/off to resume/suspend > > > > > * Sakari: Fix indentation > > > > > * Sakari: Power off during ov8856_remove() > > > > > * Sakari: Don't sleep during power-on in ACPI mode > > > > > * Sakari: Switch to getting xvclk from clk_get_rate > > > > > > > > > > - Changes since v1: > > > > > * Andy & Sakari: Make XVCLK optional since to not break ACPI > > > > > * Fabio: Change n_shutdown_gpio name to reset_gpio > > > > > * Fabio: Invert reset_gpio due to GPIO_ACTIVE_HIGH -> GPIO_ACTI= VE_LOW change > > > > > * Fabio: Remove empty line > > > > > * Fabio: Remove real error from devm_gpiod_get() failures > > > > > * Sakari: ARRAY_SIZE() directly instead of through OV8856_NUM_S= UPPLIES > > > > > * Sakari: Use XVCLK rate as provided by DT > > > > > > > > > > drivers/media/i2c/ov8856.c | 139 +++++++++++++++++++++++++++++++= ++---- > > > > > 1 file changed, 126 insertions(+), 13 deletions(-) > > > > > > > > > > diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov885= 6.c > > > > > index 8655842af275..48b02b8d205f 100644 > > > > > --- a/drivers/media/i2c/ov8856.c > > > > > +++ b/drivers/media/i2c/ov8856.c > > > > > @@ -3,10 +3,13 @@ > > > > > > > > > > #include > > > > > #include > > > > > +#include > > > > > #include > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > @@ -18,7 +21,7 @@ > > > > > #define OV8856_LINK_FREQ_360MHZ 360000000ULL > > > > > #define OV8856_LINK_FREQ_180MHZ 180000000ULL > > > > > #define OV8856_SCLK 144000000ULL > > > > > -#define OV8856_MCLK 19200000 > > > > > +#define OV8856_XVCLK_19_2 19200000 > > > > > #define OV8856_DATA_LANES 4 > > > > > #define OV8856_RGB_DEPTH 10 > > > > > > > > > > @@ -64,6 +67,12 @@ > > > > > > > > > > #define to_ov8856(_sd) container_of(_sd, s= truct ov8856, sd) > > > > > > > > > > +static const char * const ov8856_supply_names[] =3D { > > > > > + "dovdd", /* Digital I/O power */ > > > > > + "avdd", /* Analog power */ > > > > > + "dvdd", /* Digital core power */ > > > > > +}; > > > > > + > > > > > enum { > > > > > OV8856_LINK_FREQ_720MBPS, > > > > > OV8856_LINK_FREQ_360MBPS, > > > > > @@ -566,6 +575,11 @@ struct ov8856 { > > > > > struct media_pad pad; > > > > > struct v4l2_ctrl_handler ctrl_handler; > > > > > > > > > > + struct device *dev; > > > > > + struct clk *xvclk; > > > > > + struct gpio_desc *reset_gpio; > > > > > + struct regulator_bulk_data supplies[ARRAY_SIZE(ov8856_suppl= y_names)]; > > > > > + > > > > > /* V4L2 Controls */ > > > > > struct v4l2_ctrl *link_freq; > > > > > struct v4l2_ctrl *pixel_rate; > > > > > @@ -908,6 +922,52 @@ static int ov8856_set_stream(struct v4l2_sub= dev *sd, int enable) > > > > > return ret; > > > > > } > > > > > > > > > > +static int __ov8856_power_on(struct ov8856 *ov8856) > > > > > +{ > > > > > + struct i2c_client *client =3D v4l2_get_subdevdata(&ov8856->= sd); > > > > > + int ret; > > > > > + > > > > > + ret =3D clk_prepare_enable(ov8856->xvclk); > > > > > + if (ret < 0) { > > > > > + dev_err(&client->dev, "failed to enable xvclk\n"); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + if (is_acpi_node(dev_fwnode(ov8856->dev))) > > > > > + return 0; > > > > > + > > > > > + if (ov8856->reset_gpio) { > > > > > + gpiod_set_value_cansleep(ov8856->reset_gpio, 1); > > > > > + usleep_range(1000, 2000); > > > > > + } > > > > > + > > > > > + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov8856_supply_name= s), > > > > > + ov8856->supplies); > > > > > + if (ret < 0) { > > > > > + dev_err(&client->dev, "failed to enable regulators\= n"); > > > > > + goto disable_clk; > > > > > + } > > > > > + > > > > > + gpiod_set_value_cansleep(ov8856->reset_gpio, 0); > > > > > + usleep_range(1500, 1800); > > > > > + > > > > > + return 0; > > > > > + > > > > > +disable_clk: > > > > > + gpiod_set_value_cansleep(ov8856->reset_gpio, 1); > > > > > + clk_disable_unprepare(ov8856->xvclk); > > > > > + > > > > > + return ret; > > > > > +} > > > > > + > > > > > +static void __ov8856_power_off(struct ov8856 *ov8856) > > > > > +{ > > > > > + gpiod_set_value_cansleep(ov8856->reset_gpio, 1); > > > > > + regulator_bulk_disable(ARRAY_SIZE(ov8856_supply_names), > > > > > + ov8856->supplies); > > > > > + clk_disable_unprepare(ov8856->xvclk); > > > > > +} > > > > > + > > > > > static int __maybe_unused ov8856_suspend(struct device *dev) > > > > > { > > > > > struct i2c_client *client =3D to_i2c_client(dev); > > > > > @@ -918,6 +978,7 @@ static int __maybe_unused ov8856_suspend(stru= ct device *dev) > > > > > if (ov8856->streaming) > > > > > ov8856_stop_streaming(ov8856); > > > > > > > > > > + __ov8856_power_off(ov8856); > > > > > mutex_unlock(&ov8856->mutex); > > > > > > > > > > return 0; > > > > > @@ -931,6 +992,8 @@ static int __maybe_unused ov8856_resume(struc= t device *dev) > > > > > int ret; > > > > > > > > > > mutex_lock(&ov8856->mutex); > > > > > + > > > > > + __ov8856_power_on(ov8856); > > > > > if (ov8856->streaming) { > > > > > ret =3D ov8856_start_streaming(ov8856); > > > > > if (ret) { > > > > > @@ -1092,29 +1155,58 @@ static int ov8856_identify_module(struct = ov8856 *ov8856) > > > > > return 0; > > > > > } > > > > > > > > > > -static int ov8856_check_hwcfg(struct device *dev) > > > > > +static int ov8856_get_hwcfg(struct ov8856 *ov8856) > > > > > { > > > > > + struct device *dev =3D ov8856->dev; > > > > > struct fwnode_handle *ep; > > > > > struct fwnode_handle *fwnode =3D dev_fwnode(dev); > > > > > struct v4l2_fwnode_endpoint bus_cfg =3D { > > > > > .bus_type =3D V4L2_MBUS_CSI2_DPHY > > > > > }; > > > > > - u32 mclk; > > > > > + u32 xvclk_rate; > > > > > int ret; > > > > > unsigned int i, j; > > > > > > > > > > if (!fwnode) > > > > > return -ENXIO; > > > > > > > > > > - ret =3D fwnode_property_read_u32(fwnode, "clock-frequency",= &mclk); > > > > > + ret =3D fwnode_property_read_u32(fwnode, "clock-frequency", > > > > > + &xvclk_rate); > > > > > if (ret) > > > > > return ret; > > > > > > > > > > - if (mclk !=3D OV8856_MCLK) { > > > > > - dev_err(dev, "external clock %d is not supported", = mclk); > > > > > + if (!is_acpi_node(fwnode)) { > > > > > + ov8856->xvclk =3D devm_clk_get(dev, "xvclk"); > > > > > + if (IS_ERR(ov8856->xvclk)) { > > > > > + dev_err(dev, "could not get xvclk clock (%p= e)\n", > > > > > + ov8856->xvclk); > > > > > + return PTR_ERR(ov8856->xvclk); > > > > > + } > > > > > + > > > > > + clk_set_rate(ov8856->xvclk, xvclk_rate); > > > > > + xvclk_rate =3D clk_get_rate(ov8856->xvclk); > > > > > + } > > > > > + > > > > > + /* external clock must be 19.2MHz, allow 5% tolerance */ > > > > > > > > Where is that 5% tolerance coming from? Experimentations, datasheet= s, something > > > > that looks good enough? Either way, this should be in the comment. > > > > > > I don't have access to the full datasheet unfortunately. A 24Mhz rate > > > is as far as I understand it supported and required for higher > > > bandwidth count modes. > > > It was suggested to me that adding a tolerance is the best practice, > > > the ov5645 driver uses a 1% tolerance, which may be more appropriate. > > > > The frequency should really be exact. Sometimes what happens is, howeve= r, > > that a register list based driver does not have the register lists for a > > frequency that is available on a given system. That's why some drivers = have > > allowed some difference to the intended frequency. > > > > That 5 % seems like a random value, just like any other number that dif= fers > > from the exact frequency would be. > > > > I'd issue a warning if the frequency differs from what was intended, but > > still proceed with probe. This way we can make sure the difference is n= oted > > while boards that cannot provide the exact frequency supported by the > > driver can still function. >=20 > Issuing a warning sounds like a good solution to me. What do you think Ma= xime? Sounds good to me too :) Maxime --4e2ce4wi52h6jxye Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXqlpLQAKCRDj7w1vZxhR xfy5AP9WB6qj36xGc19gDUzaiYtAzYINqK4aVmuNMeieKOESdAD/X643GOOZCaKS +tW21zB5c9ZbIZnEBKZ9vft+BXIJjQw= =khOj -----END PGP SIGNATURE----- --4e2ce4wi52h6jxye-- --===============1920743208417749558== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1920743208417749558==--