All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH RESEND] perf tools: Fix function name in comment
Date: Wed, 29 Apr 2020 11:34:37 -0300	[thread overview]
Message-ID: <20200429143437.GA29329@kernel.org> (raw)
In-Reply-To: <1588141992-48382-1-git-send-email-zhangshaokun@hisilicon.com>

Em Wed, Apr 29, 2020 at 02:33:12PM +0800, Shaokun Zhang escreveu:
> get_cpuid_str() is used in tools/perf/arch/xxx/util/header.c,
> fix the name in comment.
> 
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> CC: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>  tools/perf/pmu-events/pmu-events.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h
> index 53e76d5d5b37..c8f306b572f4 100644
> --- a/tools/perf/pmu-events/pmu-events.h
> +++ b/tools/perf/pmu-events/pmu-events.h
> @@ -26,7 +26,7 @@ struct pmu_event {
>   * Map a CPU to its table of PMU events. The CPU is identified by the
>   * cpuid field, which is an arch-specific identifier for the CPU.
>   * The identifier specified in tools/perf/pmu-events/arch/xxx/mapfile
> - * must match the get_cpustr() in tools/perf/arch/xxx/util/header.c)
> + * must match the get_cpuid_str() in tools/perf/arch/xxx/util/header.c)
>   *
>   * The  cpuid can contain any character other than the comma.
>   */

Thanks, applied.

- Arnaldo

  reply	other threads:[~2020-04-29 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  6:33 [PATCH RESEND] perf tools: Fix function name in comment Shaokun Zhang
2020-04-29 14:34 ` Arnaldo Carvalho de Melo [this message]
2020-05-08 13:05 ` [tip: perf/core] perf pmu: Fix function name in comment, its get_cpuid_str(), not get_cpustr() tip-bot2 for Shaokun Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429143437.GA29329@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.