All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sanity: Require gcc 6 or later
@ 2020-04-29 22:01 Richard Purdie
  2020-04-29 23:41 ` [OE-core] " Denys Dmytriyenko
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2020-04-29 22:01 UTC (permalink / raw)
  To: openembedded-core

New versions of rpm have issues with the libgomp support in gcc 5.x
so raise the minimum to 6 or later. This mainly affects Ubuntu 16.04.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/sanity.bbclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 9e871017389..292c5591dd3 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -527,7 +527,7 @@ def check_wsl(d):
             bb.warn("You are running bitbake under WSLv2, this works properly but you should optimize your VHDX file eventually to avoid running out of storage space")
     return None
 
-# Require at least gcc version 5.0.
+# Require at least gcc version 6.0.
 #
 # This can be fixed on CentOS-7 with devtoolset-6+
 # https://www.softwarecollections.org/en/scls/rhscl/devtoolset-6/
@@ -541,8 +541,8 @@ def check_gcc_version(sanity_data):
     
     build_cc, version = oe.utils.get_host_compiler_version(sanity_data)
     if build_cc.strip() == "gcc":
-        if LooseVersion(version) < LooseVersion("5.0"):
-            return "Your version of gcc is older than 5.0 and will break builds. Please install a newer version of gcc (you could use the project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
+        if LooseVersion(version) < LooseVersion("6.0"):
+            return "Your version of gcc is older than 6.0 and will break builds. Please install a newer version of gcc (you could use the project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
     return None
 
 # Tar version 1.24 and onwards handle overwriting symlinks correctly
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] sanity: Require gcc 6 or later
  2020-04-29 22:01 [PATCH] sanity: Require gcc 6 or later Richard Purdie
@ 2020-04-29 23:41 ` Denys Dmytriyenko
  2020-04-30  0:02   ` Khem Raj
  2020-04-30  0:03   ` Steve Sakoman
  0 siblings, 2 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2020-04-29 23:41 UTC (permalink / raw)
  To: openembedded-core

On Wed, Apr 29, 2020 at 11:01:56PM +0100, Richard Purdie wrote:
> New versions of rpm have issues with the libgomp support in gcc 5.x
> so raise the minimum to 6 or later. This mainly affects Ubuntu 16.04.

So, this is for master, rigth? No plans to backport it to dunfell (hence, no 
rpm backport either), correct? Trying to make sure Yocto LTS will still work  
on Ubuntu 16.04 LTS...

-- 
Denys


> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes/sanity.bbclass | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 9e871017389..292c5591dd3 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -527,7 +527,7 @@ def check_wsl(d):
>              bb.warn("You are running bitbake under WSLv2, this works properly but you should optimize your VHDX file eventually to avoid running out of storage space")
>      return None
>  
> -# Require at least gcc version 5.0.
> +# Require at least gcc version 6.0.
>  #
>  # This can be fixed on CentOS-7 with devtoolset-6+
>  # https://www.softwarecollections.org/en/scls/rhscl/devtoolset-6/
> @@ -541,8 +541,8 @@ def check_gcc_version(sanity_data):
>      
>      build_cc, version = oe.utils.get_host_compiler_version(sanity_data)
>      if build_cc.strip() == "gcc":
> -        if LooseVersion(version) < LooseVersion("5.0"):
> -            return "Your version of gcc is older than 5.0 and will break builds. Please install a newer version of gcc (you could use the project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
> +        if LooseVersion(version) < LooseVersion("6.0"):
> +            return "Your version of gcc is older than 6.0 and will break builds. Please install a newer version of gcc (you could use the project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
>      return None
>  
>  # Tar version 1.24 and onwards handle overwriting symlinks correctly
> -- 
> 2.25.1
> 

> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] sanity: Require gcc 6 or later
  2020-04-29 23:41 ` [OE-core] " Denys Dmytriyenko
@ 2020-04-30  0:02   ` Khem Raj
  2020-04-30  0:03   ` Steve Sakoman
  1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2020-04-30  0:02 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Wed, Apr 29, 2020 at 4:41 PM Denys Dmytriyenko <denis@denix.org> wrote:
>
> On Wed, Apr 29, 2020 at 11:01:56PM +0100, Richard Purdie wrote:
> > New versions of rpm have issues with the libgomp support in gcc 5.x
> > so raise the minimum to 6 or later. This mainly affects Ubuntu 16.04.
>
> So, this is for master, rigth? No plans to backport it to dunfell (hence, no
> rpm backport either), correct? Trying to make sure Yocto LTS will still work
> on Ubuntu 16.04 LTS...

I think yes, its not coming to dunfell, ubuntu 16.04 is still in
maintenance and will be for next year too
see https://ubuntu.com/about/release-cycle


>
> --
> Denys
>
>
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/classes/sanity.bbclass | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> > index 9e871017389..292c5591dd3 100644
> > --- a/meta/classes/sanity.bbclass
> > +++ b/meta/classes/sanity.bbclass
> > @@ -527,7 +527,7 @@ def check_wsl(d):
> >              bb.warn("You are running bitbake under WSLv2, this works properly but you should optimize your VHDX file eventually to avoid running out of storage space")
> >      return None
> >
> > -# Require at least gcc version 5.0.
> > +# Require at least gcc version 6.0.
> >  #
> >  # This can be fixed on CentOS-7 with devtoolset-6+
> >  # https://www.softwarecollections.org/en/scls/rhscl/devtoolset-6/
> > @@ -541,8 +541,8 @@ def check_gcc_version(sanity_data):
> >
> >      build_cc, version = oe.utils.get_host_compiler_version(sanity_data)
> >      if build_cc.strip() == "gcc":
> > -        if LooseVersion(version) < LooseVersion("5.0"):
> > -            return "Your version of gcc is older than 5.0 and will break builds. Please install a newer version of gcc (you could use the project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
> > +        if LooseVersion(version) < LooseVersion("6.0"):
> > +            return "Your version of gcc is older than 6.0 and will break builds. Please install a newer version of gcc (you could use the project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
> >      return None
> >
> >  # Tar version 1.24 and onwards handle overwriting symlinks correctly
> > --
> > 2.25.1
> >
>
> >
>
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] sanity: Require gcc 6 or later
  2020-04-29 23:41 ` [OE-core] " Denys Dmytriyenko
  2020-04-30  0:02   ` Khem Raj
@ 2020-04-30  0:03   ` Steve Sakoman
  2020-04-30  6:10     ` Alexander Kanavin
  1 sibling, 1 reply; 6+ messages in thread
From: Steve Sakoman @ 2020-04-30  0:03 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Wed, Apr 29, 2020 at 1:41 PM Denys Dmytriyenko <denis@denix.org> wrote:

> So, this is for master, rigth? No plans to backport it to dunfell (hence, no
> rpm backport either), correct? Trying to make sure Yocto LTS will still work
> on Ubuntu 16.04 LTS...

I have the same goal, so no plans to backport to dunfell!

Steve

> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/classes/sanity.bbclass | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> > index 9e871017389..292c5591dd3 100644
> > --- a/meta/classes/sanity.bbclass
> > +++ b/meta/classes/sanity.bbclass
> > @@ -527,7 +527,7 @@ def check_wsl(d):
> >              bb.warn("You are running bitbake under WSLv2, this works properly but you should optimize your VHDX file eventually to avoid running out of storage space")
> >      return None
> >
> > -# Require at least gcc version 5.0.
> > +# Require at least gcc version 6.0.
> >  #
> >  # This can be fixed on CentOS-7 with devtoolset-6+
> >  # https://www.softwarecollections.org/en/scls/rhscl/devtoolset-6/
> > @@ -541,8 +541,8 @@ def check_gcc_version(sanity_data):
> >
> >      build_cc, version = oe.utils.get_host_compiler_version(sanity_data)
> >      if build_cc.strip() == "gcc":
> > -        if LooseVersion(version) < LooseVersion("5.0"):
> > -            return "Your version of gcc is older than 5.0 and will break builds. Please install a newer version of gcc (you could use the project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
> > +        if LooseVersion(version) < LooseVersion("6.0"):
> > +            return "Your version of gcc is older than 6.0 and will break builds. Please install a newer version of gcc (you could use the project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
> >      return None
> >
> >  # Tar version 1.24 and onwards handle overwriting symlinks correctly
> > --
> > 2.25.1
> >
>
> >
>
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] sanity: Require gcc 6 or later
  2020-04-30  0:03   ` Steve Sakoman
@ 2020-04-30  6:10     ` Alexander Kanavin
  2020-04-30 15:40       ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2020-04-30  6:10 UTC (permalink / raw)
  To: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2486 bytes --]

Ubuntu 16.04 will continue to be supported even with this change, you just
need to set up builtools-extended-tarball to provide a recent compiler,
which is a couple of easy commands suggested by bitbake.

Alex

On Thu 30. Apr 2020 at 2.04, Steve Sakoman <sakoman@gmail.com> wrote:

> On Wed, Apr 29, 2020 at 1:41 PM Denys Dmytriyenko <denis@denix.org> wrote:
>
> > So, this is for master, rigth? No plans to backport it to dunfell
> (hence, no
> > rpm backport either), correct? Trying to make sure Yocto LTS will still
> work
> > on Ubuntu 16.04 LTS...
>
> I have the same goal, so no plans to backport to dunfell!
>
> Steve
>
> > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > ---
> > >  meta/classes/sanity.bbclass | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> > > index 9e871017389..292c5591dd3 100644
> > > --- a/meta/classes/sanity.bbclass
> > > +++ b/meta/classes/sanity.bbclass
> > > @@ -527,7 +527,7 @@ def check_wsl(d):
> > >              bb.warn("You are running bitbake under WSLv2, this works
> properly but you should optimize your VHDX file eventually to avoid running
> out of storage space")
> > >      return None
> > >
> > > -# Require at least gcc version 5.0.
> > > +# Require at least gcc version 6.0.
> > >  #
> > >  # This can be fixed on CentOS-7 with devtoolset-6+
> > >  # https://www.softwarecollections.org/en/scls/rhscl/devtoolset-6/
> > > @@ -541,8 +541,8 @@ def check_gcc_version(sanity_data):
> > >
> > >      build_cc, version =
> oe.utils.get_host_compiler_version(sanity_data)
> > >      if build_cc.strip() == "gcc":
> > > -        if LooseVersion(version) < LooseVersion("5.0"):
> > > -            return "Your version of gcc is older than 5.0 and will
> break builds. Please install a newer version of gcc (you could use the
> project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
> > > +        if LooseVersion(version) < LooseVersion("6.0"):
> > > +            return "Your version of gcc is older than 6.0 and will
> break builds. Please install a newer version of gcc (you could use the
> project's buildtools-extended-tarball or use scripts/install-buildtools).\n"
> > >      return None
> > >
> > >  # Tar version 1.24 and onwards handle overwriting symlinks correctly
> > > --
> > > 2.25.1
> > >
> >
> > >
> >
> >
> 
>

[-- Attachment #2: Type: text/html, Size: 3457 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] sanity: Require gcc 6 or later
  2020-04-30  6:10     ` Alexander Kanavin
@ 2020-04-30 15:40       ` Khem Raj
  0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2020-04-30 15:40 UTC (permalink / raw)
  To: openembedded-core



On 4/29/20 11:10 PM, Alexander Kanavin wrote:
> Ubuntu 16.04 will continue to be supported even with this change, you 
> just need to set up builtools-extended-tarball to provide a recent 
> compiler, which is a couple of easy commands suggested by bitbake.
> 

Thats understood, and as we do not use buildtools-extended-tarball on 
every disto this is not default. Secondly, for a release it would differ 
from what we have released with.

> Alex
> 
> On Thu 30. Apr 2020 at 2.04, Steve Sakoman <sakoman@gmail.com 
> <mailto:sakoman@gmail.com>> wrote:
> 
>     On Wed, Apr 29, 2020 at 1:41 PM Denys Dmytriyenko <denis@denix.org
>     <mailto:denis@denix.org>> wrote:
> 
>      > So, this is for master, rigth? No plans to backport it to dunfell
>     (hence, no
>      > rpm backport either), correct? Trying to make sure Yocto LTS will
>     still work
>      > on Ubuntu 16.04 LTS...
> 
>     I have the same goal, so no plans to backport to dunfell!
> 
>     Steve
> 
>      > > Signed-off-by: Richard Purdie
>     <richard.purdie@linuxfoundation.org
>     <mailto:richard.purdie@linuxfoundation.org>>
>      > > ---
>      > >  meta/classes/sanity.bbclass | 6 +++---
>      > >  1 file changed, 3 insertions(+), 3 deletions(-)
>      > >
>      > > diff --git a/meta/classes/sanity.bbclass
>     b/meta/classes/sanity.bbclass
>      > > index 9e871017389..292c5591dd3 100644
>      > > --- a/meta/classes/sanity.bbclass
>      > > +++ b/meta/classes/sanity.bbclass
>      > > @@ -527,7 +527,7 @@ def check_wsl(d):
>      > >              bb.warn("You are running bitbake under WSLv2, this
>     works properly but you should optimize your VHDX file eventually to
>     avoid running out of storage space")
>      > >      return None
>      > >
>      > > -# Require at least gcc version 5.0.
>      > > +# Require at least gcc version 6.0.
>      > >  #
>      > >  # This can be fixed on CentOS-7 with devtoolset-6+
>      > >  # https://www.softwarecollections.org/en/scls/rhscl/devtoolset-6/
>      > > @@ -541,8 +541,8 @@ def check_gcc_version(sanity_data):
>      > >
>      > >      build_cc, version =
>     oe.utils.get_host_compiler_version(sanity_data)
>      > >      if build_cc.strip() == "gcc":
>      > > -        if LooseVersion(version) < LooseVersion("5.0"):
>      > > -            return "Your version of gcc is older than 5.0 and
>     will break builds. Please install a newer version of gcc (you could
>     use the project's buildtools-extended-tarball or use
>     scripts/install-buildtools).\n"
>      > > +        if LooseVersion(version) < LooseVersion("6.0"):
>      > > +            return "Your version of gcc is older than 6.0 and
>     will break builds. Please install a newer version of gcc (you could
>     use the project's buildtools-extended-tarball or use
>     scripts/install-buildtools).\n"
>      > >      return None
>      > >
>      > >  # Tar version 1.24 and onwards handle overwriting symlinks
>     correctly
>      > > --
>      > > 2.25.1
>      > >
>      >
>      > >
>      >
>      >
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-04-30 15:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 22:01 [PATCH] sanity: Require gcc 6 or later Richard Purdie
2020-04-29 23:41 ` [OE-core] " Denys Dmytriyenko
2020-04-30  0:02   ` Khem Raj
2020-04-30  0:03   ` Steve Sakoman
2020-04-30  6:10     ` Alexander Kanavin
2020-04-30 15:40       ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.