All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] crypto: drbg: DRBG should select SHA512
Date: Thu, 30 Apr 2020 14:43:24 +1000	[thread overview]
Message-ID: <20200430044324.GA13460@gondor.apana.org.au> (raw)
In-Reply-To: <1587735647-17718-2-git-send-email-clabbe@baylibre.com>

On Fri, Apr 24, 2020 at 01:40:45PM +0000, Corentin Labbe wrote:
> Since DRBG could use SHA384/SHA512, it should select it.
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  crypto/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index c24a47406f8f..6d27fc6a7bf5 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -1810,10 +1810,12 @@ config CRYPTO_DRBG_HMAC
>  	default y
>  	select CRYPTO_HMAC
>  	select CRYPTO_SHA256
> +	select CRYPTO_SHA512
>  
>  config CRYPTO_DRBG_HASH
>  	bool "Enable Hash DRBG"
>  	select CRYPTO_SHA256
> +	select CRYPTO_SHA512
>  	help
>  	  Enable the Hash DRBG variant as defined in NIST SP800-90A.

The default hash drbg is sha256, the others are only optional.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2020-04-30  4:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 13:40 [PATCH v3 0/3] crypto: fix some DRBG Kconfig deps Corentin Labbe
2020-04-24 13:40 ` [PATCH v3 1/3] crypto: drbg: DRBG should select SHA512 Corentin Labbe
2020-04-30  4:43   ` Herbert Xu [this message]
2020-04-24 13:40 ` [PATCH v3 2/3] crypto: CRYPTO_CTR no longer need CRYPTO_SEQIV Corentin Labbe
2020-06-04 16:15   ` Eric Biggers
2020-04-24 13:40 ` [PATCH v3 3/3] crypto: drbg: DRBG_CTR should select CTR Corentin Labbe
2020-04-30  5:32 ` [PATCH v3 0/3] crypto: fix some DRBG Kconfig deps Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430044324.GA13460@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=clabbe@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.