All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yan Zhao <yan.y.zhao@intel.com>
To: pbonzini@redhat.com, alex.williamson@redhat.com
Cc: Yan Zhao <yan.y.zhao@intel.com>,
	xin.zeng@intel.com, philmd@redhat.com, qemu-devel@nongnu.org
Subject: [PATCH v5 3/3] hw/vfio: let read-only flag take effect for mmap'd regions
Date: Thu, 30 Apr 2020 01:24:04 -0400	[thread overview]
Message-ID: <20200430052404.29290-1-yan.y.zhao@intel.com> (raw)
In-Reply-To: <20200430051558.28991-1-yan.y.zhao@intel.com>

along side setting host page table to be read-only, the memory regions
are also required to be read-only, so that when guest writes to the
read-only & mmap'd regions, vmexits would happen and region write handlers
are called.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
Signed-off-by: Xin Zeng <xin.zeng@intel.com>
---
 hw/vfio/common.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 2a4fedfeaa..bf510e66c0 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -980,6 +980,10 @@ int vfio_region_mmap(VFIORegion *region)
                                           name, region->mmaps[i].size,
                                           region->mmaps[i].mmap);
         g_free(name);
+
+        if (!(region->flags & VFIO_REGION_INFO_FLAG_WRITE)) {
+            memory_region_set_readonly(&region->mmaps[i].mem, true);
+        }
         memory_region_add_subregion(region->mem, region->mmaps[i].offset,
                                     &region->mmaps[i].mem);
 
-- 
2.17.1



      parent reply	other threads:[~2020-04-30  5:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30  5:15 [PATCH v5 0/3] drop writes to read-only ram device & vfio regions Yan Zhao
2020-04-30  5:19 ` [PATCH v5 1/3] memory: drop guest writes to read-only ram device regions Yan Zhao
2020-04-30  7:07   ` Philippe Mathieu-Daudé
2020-04-30  7:02     ` Yan Zhao
2020-04-30  5:23 ` [PATCH v5 2/3] hw/vfio: drop guest writes to ro regions Yan Zhao
2020-04-30  7:02   ` Philippe Mathieu-Daudé
2020-04-30  7:01     ` Yan Zhao
2020-04-30  5:24 ` Yan Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430052404.29290-1-yan.y.zhao@intel.com \
    --to=yan.y.zhao@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xin.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.