From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] syscalls/pidfd_open01.c: Add check for close-on-exec flag
Date: Thu, 30 Apr 2020 16:57:41 +0800 [thread overview]
Message-ID: <20200430085742.1663-1-yangx.jy@cn.fujitsu.com> (raw)
pidfd_open(2) will set close-on-exec flag on the file descriptor as it
manpage states, so check close-on-exec flag by fcntl(2).
Also avoid compiler warning by replacing (long) TST_RET with (int) pidfd:
------------------------------------------------------
In file included from pidfd_open01.c:9:
pidfd_open01.c: In function ?run?:
../../../../include/tst_test.h:76:41: warning: format ?%i? expects argument of type ?int?, but argument 5 has type ?long int? [-Wformat=]
76 | tst_brk_(__FILE__, __LINE__, (ttype), (arg_fmt), ##__VA_ARGS__);\
| ^~~~~~~~~
../../../../include/tst_safe_macros.h:224:5: note: in expansion of macro ?tst_brk?
224 | tst_brk(TBROK | TERRNO, \
| ^~~~~~~
pidfd_open01.c:20:9: note: in expansion of macro ?SAFE_FCNTL?
20 | flag = SAFE_FCNTL(TST_RET, F_GETFD);
------------------------------------------------------
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
.../kernel/syscalls/pidfd_open/pidfd_open01.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/testcases/kernel/syscalls/pidfd_open/pidfd_open01.c b/testcases/kernel/syscalls/pidfd_open/pidfd_open01.c
index 93bb86687..293e93b63 100644
--- a/testcases/kernel/syscalls/pidfd_open/pidfd_open01.c
+++ b/testcases/kernel/syscalls/pidfd_open/pidfd_open01.c
@@ -6,17 +6,27 @@
* Basic pidfd_open() test, fetches the PID of the current process and tries to
* get its file descriptor.
*/
+
+#include <sys/types.h>
+#include <unistd.h>
+#include <fcntl.h>
#include "tst_test.h"
#include "lapi/pidfd_open.h"
static void run(void)
{
- TEST(pidfd_open(getpid(), 0));
+ int pidfd = 0, flag = 0;
+
+ pidfd = pidfd_open(getpid(), 0);
+ if (pidfd == -1)
+ tst_brk(TFAIL | TERRNO, "pidfd_open(getpid(), 0) failed");
+
+ flag = SAFE_FCNTL(pidfd, F_GETFD);
- if (TST_RET == -1)
- tst_brk(TFAIL | TTERRNO, "pidfd_open(getpid(), 0) failed");
+ SAFE_CLOSE(pidfd);
- SAFE_CLOSE(TST_RET);
+ if (!(flag & FD_CLOEXEC))
+ tst_brk(TFAIL, "pidfd_open(getpid(), 0) didn't set close-on-exec flag");
tst_res(TPASS, "pidfd_open(getpid(), 0) passed");
}
--
2.21.0
next reply other threads:[~2020-04-30 8:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 8:57 Xiao Yang [this message]
2020-04-30 8:57 ` [LTP] [PATCH 2/2] syscalls/pidfd_open*.c: Drop .min_kver flag Xiao Yang
2020-05-04 5:11 ` Viresh Kumar
2020-05-04 12:49 ` Xiao Yang
2020-05-05 3:35 ` Viresh Kumar
2020-05-05 9:30 ` Xiao Yang
2020-05-05 9:51 ` Viresh Kumar
2020-05-12 14:32 ` Xiao Yang
2020-06-12 14:30 ` Cyril Hrubis
2020-05-04 5:09 ` [LTP] [PATCH 1/2] syscalls/pidfd_open01.c: Add check for close-on-exec flag Viresh Kumar
2020-05-04 8:30 ` =?unknown-8bit?b?5p2o5pmT?=
2020-05-04 11:32 ` Xiao Yang
2020-05-04 11:31 ` Xiao Yang
2020-05-05 3:28 ` Viresh Kumar
2020-05-05 8:44 ` Xiao Yang
2020-05-12 14:25 ` Xiao Yang
2020-06-12 14:24 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430085742.1663-1-yangx.jy@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.