From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 098C8C47253 for ; Thu, 30 Apr 2020 13:53:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3560208CA for ; Thu, 30 Apr 2020 13:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588254806; bh=Nh7gMGFbFDqRDU6KRwGLRELYcn+AP104P30Mc9SedG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WhyuyVvGpu3eQquV9BMhlA6L/XBuZdSmEAWhxd/0vFFlLK6kkfwJ0mtL1ZRJa1dUh eRP1tbC4ok+rqpQhLFqWdKemGHKBgls5Mmp6w2uM49w1jlvCh/14lYpgWrGnJKgc/W loJilWox5/LkTd4MGGjayIFkDl0vJqt7DtCHbawQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728711AbgD3NxZ (ORCPT ); Thu, 30 Apr 2020 09:53:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:34194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728515AbgD3Nws (ORCPT ); Thu, 30 Apr 2020 09:52:48 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E13120774; Thu, 30 Apr 2020 13:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588254768; bh=Nh7gMGFbFDqRDU6KRwGLRELYcn+AP104P30Mc9SedG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RvO9UvuDGMcoyF0KS2Kom5+J5febnliTci1KT8OAnVY5caoIIONKQ0I8EphE9Rcv2 X0jea446UspxsN0agHJzlz1Ybmg/OhsICgNhT2hvs7SahFZOv0MByVB3Q89QguOD/P IWnszwdCMI7MrmDfCiyk/EiQNcapCzs5QensRxqk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xiyu Yang , Xin Tan , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 26/57] wimax/i2400m: Fix potential urb refcnt leak Date: Thu, 30 Apr 2020 09:51:47 -0400 Message-Id: <20200430135218.20372-26-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200430135218.20372-1-sashal@kernel.org> References: <20200430135218.20372-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiyu Yang [ Upstream commit 7717cbec172c3554d470023b4020d5781961187e ] i2400mu_bus_bm_wait_for_ack() invokes usb_get_urb(), which increases the refcount of the "notif_urb". When i2400mu_bus_bm_wait_for_ack() returns, local variable "notif_urb" becomes invalid, so the refcount should be decreased to keep refcount balanced. The issue happens in all paths of i2400mu_bus_bm_wait_for_ack(), which forget to decrease the refcnt increased by usb_get_urb(), causing a refcnt leak. Fix this issue by calling usb_put_urb() before the i2400mu_bus_bm_wait_for_ack() returns. Signed-off-by: Xiyu Yang Signed-off-by: Xin Tan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/wimax/i2400m/usb-fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wimax/i2400m/usb-fw.c b/drivers/net/wimax/i2400m/usb-fw.c index 529ebca1e9e13..1f7709d24f352 100644 --- a/drivers/net/wimax/i2400m/usb-fw.c +++ b/drivers/net/wimax/i2400m/usb-fw.c @@ -354,6 +354,7 @@ out: usb_autopm_put_interface(i2400mu->usb_iface); d_fnend(8, dev, "(i2400m %p ack %p size %zu) = %ld\n", i2400m, ack, ack_size, (long) result); + usb_put_urb(¬if_urb); return result; error_exceeded: -- 2.20.1