From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FAD8C28CBC for ; Thu, 30 Apr 2020 13:55:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03D7820774 for ; Thu, 30 Apr 2020 13:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588254916; bh=AeYpg1pvPhiLs0ff5THO4KwygH7FaW29PWfyxahwdVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GotshIhlJDLV7DTLy1cQPPQVY+pyz/FT/qI4yuSLxlR7HPnWw2dP7eKaDBiRzwDYT mQ90Kx63Kk1sHOfTA2uEtqz3zeixZIzpbZLSSpxl9V2CUtUyzeMc8HLAf/fCgasuuY AGbeRNBW2zpAdi/yWztfQ6OZtC+DloWaP7kRVF14= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729145AbgD3NzN (ORCPT ); Thu, 30 Apr 2020 09:55:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:36900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728971AbgD3Ny1 (ORCPT ); Thu, 30 Apr 2020 09:54:27 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5972920870; Thu, 30 Apr 2020 13:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588254867; bh=AeYpg1pvPhiLs0ff5THO4KwygH7FaW29PWfyxahwdVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZnkOg7y0VSTzgfYEubTyKEmRgwIR3BMQJi8TDvBprCK0iHpiZBkfmnI+mNhVQgKeM WR3pwbFOrwLlQSSxumlFCmgXw/01m5F2PYUaMXc4AF8+chOs94a7vZENRmuiXs47By yQIZtjlnPBtnYqo8RnCafkz9THC8BAJ4xTRkVXhw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ian Rogers , KP Singh , Peter Zijlstra , Sasha Levin Subject: [PATCH AUTOSEL 4.14 22/27] perf/core: fix parent pid/tid in task exit events Date: Thu, 30 Apr 2020 09:53:57 -0400 Message-Id: <20200430135402.20994-22-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200430135402.20994-1-sashal@kernel.org> References: <20200430135402.20994-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ian Rogers [ Upstream commit f3bed55e850926614b9898fe982f66d2541a36a5 ] Current logic yields the child task as the parent. Before: $ perf record bash -c "perf list > /dev/null" $ perf script -D |grep 'FORK\|EXIT' 4387036190981094 0x5a70 [0x30]: PERF_RECORD_FORK(10472:10472):(10470:10470) 4387036606207580 0xf050 [0x30]: PERF_RECORD_EXIT(10472:10472):(10472:10472) 4387036607103839 0x17150 [0x30]: PERF_RECORD_EXIT(10470:10470):(10470:10470) ^ Note the repeated values here -------------------/ After: 383281514043 0x9d8 [0x30]: PERF_RECORD_FORK(2268:2268):(2266:2266) 383442003996 0x2180 [0x30]: PERF_RECORD_EXIT(2268:2268):(2266:2266) 383451297778 0xb70 [0x30]: PERF_RECORD_EXIT(2266:2266):(2265:2265) Fixes: 94d5d1b2d891 ("perf_counter: Report the cloning task as parent on perf_counter_fork()") Reported-by: KP Singh Signed-off-by: Ian Rogers Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20200417182842.12522-1-irogers@google.com Signed-off-by: Sasha Levin --- kernel/events/core.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 845c8a1a9d30a..adcc935c8a115 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6607,10 +6607,17 @@ static void perf_event_task_output(struct perf_event *event, goto out; task_event->event_id.pid = perf_event_pid(event, task); - task_event->event_id.ppid = perf_event_pid(event, current); - task_event->event_id.tid = perf_event_tid(event, task); - task_event->event_id.ptid = perf_event_tid(event, current); + + if (task_event->event_id.header.type == PERF_RECORD_EXIT) { + task_event->event_id.ppid = perf_event_pid(event, + task->real_parent); + task_event->event_id.ptid = perf_event_pid(event, + task->real_parent); + } else { /* PERF_RECORD_FORK */ + task_event->event_id.ppid = perf_event_pid(event, current); + task_event->event_id.ptid = perf_event_tid(event, current); + } task_event->event_id.time = perf_event_clock(event); -- 2.20.1