From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E113AC8300A for ; Thu, 30 Apr 2020 12:31:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC0BA20775 for ; Thu, 30 Apr 2020 12:31:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SoScivrI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC0BA20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU8Lr-0008BO-OQ for qemu-devel@archiver.kernel.org; Thu, 30 Apr 2020 08:31:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38236) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU8IS-00039I-8x for qemu-devel@nongnu.org; Thu, 30 Apr 2020 08:28:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU8IK-0003MG-FI for qemu-devel@nongnu.org; Thu, 30 Apr 2020 08:28:08 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:46847 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jU84H-0004uW-Ku for qemu-devel@nongnu.org; Thu, 30 Apr 2020 08:13:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588248808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Chv0AwMhW1AuJ//bqHTRQBqJgT5HopfC9QzLPQZxhzM=; b=SoScivrIwaMtcHziEIFhydg9ra1lFgOaPW8oQqIOdQHYyLdQm+rQU1a8GuDmuVkaqFrOYm q5kLJEGFM+UeCNudzBdoQ9hUqzQ62q5up+Cghd8m3WsrjwibpbTaC0XjCvi9FefAYmh5/M GN183Me5mQlB835pA0qJeek2/Xs+lTw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-v-y76MmAOveWNBE26M7rvw-1; Thu, 30 Apr 2020 08:13:26 -0400 X-MC-Unique: v-y76MmAOveWNBE26M7rvw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BCE1245F; Thu, 30 Apr 2020 12:13:25 +0000 (UTC) Received: from localhost (unknown [10.40.208.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EA795D9C5; Thu, 30 Apr 2020 12:13:11 +0000 (UTC) Date: Thu, 30 Apr 2020 14:13:09 +0200 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v3 07/15] acpi: move aml builder code for rtc device Message-ID: <20200430141309.79df6726@redhat.com> In-Reply-To: <20200429140003.7336-8-kraxel@redhat.com> References: <20200429140003.7336-1-kraxel@redhat.com> <20200429140003.7336-8-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/30 01:31:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Laurent Vivier , Thomas Huth , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Max Reitz , =?UTF-8?B?TWFyYy1BbmRy?= =?UTF-8?B?w6k=?= Lureau , Paolo Bonzini , John Snow , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 29 Apr 2020 15:59:55 +0200 Gerd Hoffmann wrote: > Also use a single io range instead of two, > following what real hardware does. I'd make a separate patch for this comment. Also qemu maps only the first range (0x70) if I'm not mistaken, so we perhaps should drop the second (0x72) instead of merging it into the first [...] > -static Aml *build_rtc_device_aml(void) > -{ > - Aml *dev; > - Aml *crs; > - > - dev = aml_device("RTC"); > - aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00"))); > - crs = aml_resource_template(); > - aml_append(crs, aml_io(AML_DECODE16, 0x0070, 0x0070, 0x10, 0x02)); > - aml_append(crs, aml_irq_no_flags(8)); > - aml_append(crs, aml_io(AML_DECODE16, 0x0072, 0x0072, 0x02, 0x06)); [...] > +static void rtc_build_aml(ISADevice *isadev, Aml *scope) > +{ > + Aml *dev; > + Aml *crs; > + > + crs = aml_resource_template(); > + aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE, > + 0x10, 0x08)); [...]