From: "Denys Dmytriyenko" <denis@denix.org>
To: openembedded-core@lists.openembedded.org
Cc: "Bartłomiej Burdukiewicz" <bartlomiej.burdukiewicz@gmail.com>
Subject: Re: [OE-core][PATCH 1/2] libva: add PACKAGECONFIG and additonal rules for glx.
Date: Thu, 30 Apr 2020 18:23:36 -0400 [thread overview]
Message-ID: <20200430222336.GX11927@denix.org> (raw)
In-Reply-To: <20200429202745.3891440-1-bartlomiej.burdukiewicz@gmail.com>
On Wed, Apr 29, 2020 at 10:27:44PM +0200, Bartłomiej Burdukiewicz wrote:
> * glx PACKAGECONFIG by default is selected when x11 and opengl
> flag is present in DISTRO_FEATURES.
>
> * virtual/mesa is only required when glx driver is selected to
> build.
Thank you so much!
It was very unfortunate that hard dependency on mesa and
REQUIRED_DISTRO_FEATURES="opengl" was slapped all over oe-core
(not just this recipe) - rather one-sided approach... :)
Very glad to see overall situation improving here. Thanks again!
> Signed-off-by: Bartłomiej Burdukiewicz <bartlomiej.burdukiewicz@gmail.com>
> ---
> meta/recipes-graphics/libva/libva_2.6.1.bb | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-graphics/libva/libva_2.6.1.bb b/meta/recipes-graphics/libva/libva_2.6.1.bb
> index 92cea83bc1..8c495bad70 100644
> --- a/meta/recipes-graphics/libva/libva_2.6.1.bb
> +++ b/meta/recipes-graphics/libva/libva_2.6.1.bb
> @@ -23,15 +23,21 @@ SRC_URI[sha256sum] = "6c57eb642d828af2411aa38f55dc10111e8c98976dbab8fd62e4862940
>
> UPSTREAM_CHECK_URI = "https://github.com/intel/libva/releases"
>
> -DEPENDS = "libdrm virtual/mesa"
> +DEPENDS = "libdrm"
>
> inherit meson pkgconfig features_check
>
> REQUIRED_DISTRO_FEATURES = "opengl"
>
> -PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland x11', d)}"
> -PACKAGECONFIG[x11] = "-Dwith_x11=yes, -Dwith_x11=no,virtual/libx11 libxext libxfixes"
> -PACKAGECONFIG[wayland] = "-Dwith_wayland=yes, -Dwith_wayland=no,wayland-native wayland"
> +PACKAGECONFIG ??= " \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'glx', '', d)} \
> + ${@bb.utils.filter('DISTRO_FEATURES', 'x11 wayland', d)} \
> +"
> +
> +PACKAGECONFIG[x11] = "-Dwith_x11=yes,-Dwith_x11=no,virtual/libx11 libxext libxfixes"
> +PACKAGECONFIG[glx] = "-Dwith_glx=yes,-Dwith_glx=no,virtual/mesa"
> +
> +PACKAGECONFIG[wayland] = "-Dwith_wayland=yes,-Dwith_wayland=no,wayland-native wayland"
>
> PACKAGES =+ "${PN}-x11 ${PN}-glx ${PN}-wayland"
>
> --
> 2.26.2
>
>
prev parent reply other threads:[~2020-04-30 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 20:27 [OE-core][PATCH 1/2] libva: add PACKAGECONFIG and additonal rules for glx Bartłomiej Burdukiewicz
2020-04-29 20:27 ` [OE-core][PATCH 2/2] libva: removed opengl from REQUIRED_DISTRO_FEATURES Bartłomiej Burdukiewicz
2020-04-30 22:23 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430222336.GX11927@denix.org \
--to=denis@denix.org \
--cc=bartlomiej.burdukiewicz@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.