All of lore.kernel.org
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
	Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	Klaus Jensen <k.jensen@samsung.com>
Subject: Re: [PATCH blktests v3] Fix unintentional skipping of tests
Date: Fri, 1 May 2020 07:32:14 +0200	[thread overview]
Message-ID: <20200501053214.in52agk6cmclgcwg@apples.localdomain> (raw)
In-Reply-To: <20200430190227.GA1232639@vader>

On Apr 30 12:02, Omar Sandoval wrote:
> On Wed, Apr 22, 2020 at 09:44:36AM +0200, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> > 
> > cd11d001fe86 ("Support skipping tests from test{,_device}()") breaks a
> > good handful of tests.
> > 
> > For example, block/005 uses _test_dev_is_rotational to check if the
> > device is rotational and uses the result to size up the fio run. As a
> > side-effect, _test_dev_is_rotational also sets SKIP_REASON, which (since
> > commit cd11d001fe86) causes the test to print out a "[not run]" even
> > through the test actually ran successfully.
> > 
> > Fix this by renaming the existing helpers to _require_foo (e.g. a
> > _require_test_dev_is_rotational) and add the non-_require variant where
> > needed.
> > 
> > Fixes: cd11d001fe86 ("Support skipping tests from test{,_device}()")
> > Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> 
> Thanks! I'll apply this assuming it looks good after a full test run. A
> couple of comments below, but I fixed those up.
> 

Good stuff :)

Thanks, Omar!

      reply	other threads:[~2020-05-01  5:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  7:44 [PATCH blktests v3] Fix unintentional skipping of tests Klaus Jensen
2020-04-23  2:00 ` Shinichiro Kawasaki
2020-04-30 19:02 ` Omar Sandoval
2020-05-01  5:32   ` Klaus Jensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200501053214.in52agk6cmclgcwg@apples.localdomain \
    --to=its@irrelevant.dk \
    --cc=k.jensen@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=osandov@osandov.com \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.