From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61494C4724C for ; Fri, 1 May 2020 11:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47AD720787 for ; Fri, 1 May 2020 11:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728700AbgEALWC (ORCPT ); Fri, 1 May 2020 07:22:02 -0400 Received: from 8bytes.org ([81.169.241.247]:40862 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728485AbgEALWB (ORCPT ); Fri, 1 May 2020 07:22:01 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 5836A3A4; Fri, 1 May 2020 13:22:00 +0200 (CEST) Date: Fri, 1 May 2020 13:21:57 +0200 From: Joerg Roedel To: Suravee Suthikulpanit Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jon.grimm@amd.com Subject: Re: [PATCH] iommu/amd: Fix legacy interrupt remapping for x2APIC-enabled system Message-ID: <20200501112157.GA18423@8bytes.org> References: <1587562202-14183-1-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587562202-14183-1-git-send-email-suravee.suthikulpanit@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2020 at 08:30:02AM -0500, Suravee Suthikulpanit wrote: > Currently, system fails to boot because the legacy interrupt remapping > mode does not enable 128-bit IRTE (GA), which is required for x2APIC > support. > > Fix by using AMD_IOMMU_GUEST_IR_LEGACY_GA mode when booting with > kernel option amd_iommu_intr=legacy instead. The initialization > logic will check GASup and automatically fallback to using > AMD_IOMMU_GUEST_IR_LEGACY if GA mode is not supported. > > Fixes: 3928aa3f5775 ("iommu/amd: Detect and enable guest vAPIC support") > Signed-off-by: Suravee Suthikulpanit > --- > drivers/iommu/amd_iommu_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied for v5.7, thanks Suravee. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D641EC4724C for ; Fri, 1 May 2020 11:22:06 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7D8F20787 for ; Fri, 1 May 2020 11:22:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7D8F20787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 6938288C93; Fri, 1 May 2020 11:22:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id folzZRy086NN; Fri, 1 May 2020 11:22:05 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 39BA388C75; Fri, 1 May 2020 11:22:05 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1FA78C088D; Fri, 1 May 2020 11:22:05 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 436D1C016F for ; Fri, 1 May 2020 11:22:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 385608AB9A for ; Fri, 1 May 2020 11:22:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1C1vJIR-hbGJ for ; Fri, 1 May 2020 11:22:03 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by hemlock.osuosl.org (Postfix) with ESMTPS id D1647893F6 for ; Fri, 1 May 2020 11:22:02 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 5836A3A4; Fri, 1 May 2020 13:22:00 +0200 (CEST) Date: Fri, 1 May 2020 13:21:57 +0200 From: Joerg Roedel To: Suravee Suthikulpanit Subject: Re: [PATCH] iommu/amd: Fix legacy interrupt remapping for x2APIC-enabled system Message-ID: <20200501112157.GA18423@8bytes.org> References: <1587562202-14183-1-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1587562202-14183-1-git-send-email-suravee.suthikulpanit@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, jon.grimm@amd.com, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Apr 22, 2020 at 08:30:02AM -0500, Suravee Suthikulpanit wrote: > Currently, system fails to boot because the legacy interrupt remapping > mode does not enable 128-bit IRTE (GA), which is required for x2APIC > support. > > Fix by using AMD_IOMMU_GUEST_IR_LEGACY_GA mode when booting with > kernel option amd_iommu_intr=legacy instead. The initialization > logic will check GASup and automatically fallback to using > AMD_IOMMU_GUEST_IR_LEGACY if GA mode is not supported. > > Fixes: 3928aa3f5775 ("iommu/amd: Detect and enable guest vAPIC support") > Signed-off-by: Suravee Suthikulpanit > --- > drivers/iommu/amd_iommu_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied for v5.7, thanks Suravee. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu