From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27AC6C47253 for ; Fri, 1 May 2020 16:48:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED0FA206D6 for ; Fri, 1 May 2020 16:48:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oQoEcFot" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED0FA206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z1ctWnGs+dn1SYmPXWPNJfkGaE4CmmiXR8PciPgS0SE=; b=oQoEcFotapFDQf wF2I6cPjH9gTg8woZDUydtBvaCRWRZlvk/nwLUi3knooHPF8AJGeLWtVSaoqfjqlQHEJEo1FzmRPt ZtUmgPmmHVkLJPQ9sHi646kxQmbICicC/a3vQtRLLmBTOizZgjv4dnvVq2+9FvYpXiLFWCP6tLpXJ 9/BcfOm53NiD+clSq/oMWVElf+RQ/j2saarv2OyBrxUJkuy1gxZ8Wi/VHecxX0VGo5/a+mZ+txx5F IIkwsk4RCzPG80LRiF5h9RXmql2z/k4lEwXPdMNeTFB6co0R8Anz8P2MsSTe2RvYjt705+QisXiZT GkYgzaoWwM2H4jFQ6UUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUYpr-0004Du-I6; Fri, 01 May 2020 16:48:23 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUYpp-0004Da-2W for linux-nvme@lists.infradead.org; Fri, 01 May 2020 16:48:22 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3715D68BFE; Fri, 1 May 2020 18:48:18 +0200 (CEST) Date: Fri, 1 May 2020 18:48:18 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 15/15] nvmet-rdma: add metadata/T10-PI support Message-ID: <20200501164818.GA19607@lst.de> References: <20200428131135.211521-1-maxg@mellanox.com> <20200428131135.211521-16-maxg@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428131135.211521-16-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200501_094821_263052_10A5A4E8 X-CRM114-Status: UNSURE ( 9.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, jsmart2021@gmail.com, sagi@grimberg.me, martin.petersen@oracle.com, shlomin@mellanox.com, israelr@mellanox.com, vladimirk@mellanox.com, linux-nvme@lists.infradead.org, idanb@mellanox.com, oren@mellanox.com, kbusch@kernel.org, nitzanc@mellanox.com, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > +static u16 nvmet_rdma_check_pi_status(struct ib_mr *sig_mr) > +{ > + struct ib_mr_status mr_status; > + int ret; > + u16 status = 0; > + > + if (!IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY)) > + return 0; I'd expect this in the callers.. > +static void nvmet_rdma_set_sig_domain(struct blk_integrity *bi, > + struct nvme_command *cmd, struct ib_sig_domain *domain, > + u16 control) > +{ > + domain->sig_type = IB_SIG_TYPE_T10_DIF; > + domain->sig.dif.bg_type = IB_T10DIF_CRC; > +#ifdef CONFIG_BLK_DEV_INTEGRITY > + domain->sig.dif.pi_interval = 1 << bi->interval_exp; > +#endif With the genhd.h tweak I sent in response to the host code, we shouldn't need this. > + if (!IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY)) > + return; Same comment as above. > + if (nvmet_rdma_need_data_out(rsp)) { > + if (rsp->req.md_len) Can we have a helper for metadata len that also uses IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY) to let the compiler garbage collect the whole code if it is compiled out? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme