All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Haiyan Song <haiyanx.song@intel.com>,
	Jin Yao <yao.jin@linux.intel.com>,
	Song Liu <songliubraving@fb.com>,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	John Garry <john.garry@huawei.com>, Leo Yan <leo.yan@linaro.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Paul Clarke <pc@us.ibm.com>,
	linux-kernel@vger.kernel.org, kajoljain <kjain@linux.ibm.com>,
	linux-perf-users@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v4 03/12] perf metrics: fix parse errors in skylake metrics
Date: Fri,  1 May 2020 10:33:24 -0700	[thread overview]
Message-ID: <20200501173333.227162-4-irogers@google.com> (raw)
In-Reply-To: <20200501173333.227162-1-irogers@google.com>

Remove over escaping with \\.

Fixes: fd5500989c8f (perf vendor events intel: Update metrics from TMAM 3.5)
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
index b4f91137f40c..390bdab1be9d 100644
--- a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
+++ b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
@@ -328,13 +328,13 @@
     },
     {
         "BriefDescription": "Average latency of data read request to external memory (in nanoseconds). Accounts for demand loads and L1/L2 prefetches",
-        "MetricExpr": "1000000000 * ( cha@event\\=0x36\\\\\\,umask\\=0x21@ / cha@event\\=0x35\\\\\\,umask\\=0x21@ ) / ( cha_0@event\\=0x0@ / duration_time )",
+        "MetricExpr": "1000000000 * ( cha@event\\=0x36\\,umask\\=0x21@ / cha@event\\=0x35\\,umask\\=0x21@ ) / ( cha_0@event\\=0x0@ / duration_time )",
         "MetricGroup": "Memory_Lat",
         "MetricName": "DRAM_Read_Latency"
     },
     {
         "BriefDescription": "Average number of parallel data read requests to external memory. Accounts for demand loads and L1/L2 prefetches",
-        "MetricExpr": "cha@event\\=0x36\\\\\\,umask\\=0x21@ / cha@event\\=0x36\\\\\\,umask\\=0x21\\\\\\,thresh\\=1@",
+        "MetricExpr": "cha@event\\=0x36\\,umask\\=0x21@ / cha@event\\=0x36\\,umask\\=0x21\\,thresh\\=1@",
         "MetricGroup": "Memory_BW",
         "MetricName": "DRAM_Parallel_Reads"
     },
-- 
2.26.2.526.g744177e7f7-goog


  parent reply	other threads:[~2020-05-01 17:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 17:33 [PATCH v4 00/12] perf metric fixes and test Ian Rogers
2020-05-01 17:33 ` [PATCH v4 01/12] perf expr: unlimited escaped characters in a symbol Ian Rogers
2020-05-04  6:48   ` kajoljain
2020-05-01 17:33 ` [PATCH v4 02/12] perf metrics: fix parse errors in cascade lake metrics Ian Rogers
2020-05-01 17:33 ` Ian Rogers [this message]
2020-05-01 17:33 ` [PATCH v4 04/12] perf expr: allow ',' to be an other token Ian Rogers
2020-05-01 17:33 ` [PATCH v4 05/12] perf expr: increase max other Ian Rogers
2020-05-01 17:33 ` [PATCH v4 06/12] perf expr: parse numbers as doubles Ian Rogers
2020-05-04  6:50   ` kajoljain
2020-05-01 17:33 ` [PATCH v4 07/12] perf expr: debug lex if debugging yacc Ian Rogers
2020-05-01 17:33 ` [PATCH v4 08/12] perf metrics: fix parse errors in power8 metrics Ian Rogers
2020-05-01 17:33 ` [PATCH v4 09/12] perf metrics: fix parse errors in power9 metrics Ian Rogers
2020-05-01 17:33 ` [PATCH v4 10/12] perf expr: print a debug message for division by zero Ian Rogers
2020-05-01 17:33 ` [PATCH v4 11/12] perf parse-events: expand add PMU error/verbose messages Ian Rogers
2020-05-01 17:33 ` [PATCH v4 12/12] perf test: improve pmu event metric testing Ian Rogers
     [not found]   ` <20200503145553.GA1865281@krava>
     [not found]     ` <CAP-5=fXrwcz+MMF0Dqd_UnoXoTo1iO7T3-ENX0fzytPmJWmtoA@mail.gmail.com>
2020-05-03 17:06       ` Jiri Olsa
2020-05-03 17:06         ` Jiri Olsa
2020-05-03 17:31         ` Ian Rogers
2020-05-03 17:31           ` Ian Rogers
2020-05-03 22:16           ` Jiri Olsa
2020-05-03 22:16             ` Jiri Olsa
2020-05-07  8:44 ` [PATCH v4 00/12] perf metric fixes and test Jiri Olsa
2020-05-07 16:00   ` Arnaldo Carvalho de Melo
2020-05-11 15:32   ` Arnaldo Carvalho de Melo
2020-05-11 16:12     ` Ian Rogers
2020-05-11 16:12       ` Ian Rogers
2020-05-13  6:32       ` Ian Rogers
2020-05-13  6:32         ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200501173333.227162-4-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=haiyanx.song@intel.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=kjain@linux.ibm.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pc@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=songliubraving@fb.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.