All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Seebs" <seebs@seebs.net>
To: "Jacob Kroon" <jacob.kroon@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [pseudo][PATCH] pseudo_ipc.h: Fix enum typedef
Date: Sun, 3 May 2020 00:28:52 -0500	[thread overview]
Message-ID: <20200503002852.1273f3a1@seebsdell> (raw)
In-Reply-To: <20200503042712.1878496-1-jacob.kroon@gmail.com>

On Sun,  3 May 2020 06:27:12 +0200
"Jacob Kroon" <jacob.kroon@gmail.com> wrote:

> 'pseudo_access_t' is a type, so use typedef.
> 
> Fixes building pseudo with gcc 10 where -fno-common is the default.

Wow! That's amazing, and yes, that's a bug, and the fix looks right to
me. I don't know how that got missed all these years. (But don't rely
on this evaluation too heavily just yet, I haven't actually looked at
the code more carefully, but this seems obvious.)

-s

  parent reply	other threads:[~2020-05-03  5:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-03  4:27 [pseudo][PATCH] pseudo_ipc.h: Fix enum typedef Jacob Kroon
2020-05-03  4:32 ` ✗ patchtest: failure for " Patchwork
2020-05-03  5:04   ` Jacob Kroon
2020-05-03  5:28 ` Seebs [this message]
2020-05-03 15:49   ` [OE-core] [pseudo][PATCH] " Jacob Kroon
2020-05-03 16:26     ` Seebs
2020-05-08  6:09       ` Jacob Kroon
2020-05-08 14:04         ` Seebs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200503002852.1273f3a1@seebsdell \
    --to=seebs@seebs.net \
    --cc=jacob.kroon@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.