From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D9AC3A5A9 for ; Mon, 4 May 2020 05:16:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8A5820746 for ; Mon, 4 May 2020 05:16:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588569388; bh=NDLbS7H6KX8JKKif2MK4betfRmG+k4ZuMRllise3FH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wwlyidPwMXj0hyVhHPmU7CUys6O1z6P9ataUiu/HK69IDf4MKufMwmxR4F0t4obCW g6KeMATIcGQ711gHVDBOdNChTeF2o2cn3mbcs6oMHGhkdYveL8Cmv7FfsRGABSnvli 6X2vG6ATgSzxWKUueTEjzupwbR3J7swvmPAjLdTc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726884AbgEDFQ2 (ORCPT ); Mon, 4 May 2020 01:16:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:56036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726411AbgEDFQ2 (ORCPT ); Mon, 4 May 2020 01:16:28 -0400 Received: from localhost (unknown [171.76.84.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 14099206C0; Mon, 4 May 2020 05:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588569387; bh=NDLbS7H6KX8JKKif2MK4betfRmG+k4ZuMRllise3FH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LK29ZRn37F496akRaG3GcO+JOrxhO4ifvkyc5p8z9aryf4UhKyF+AThH5xKRPGT49 JYYrGGeesrtjQwRtI9m/4zOrMGJ11uFjbZdrd0pUmVDP5037K61cLpFCuYyME+Ne21 3EKAg5il2Xg3hUuTZb/FKfFmfRCy0okr1oTZG+yU= Date: Mon, 4 May 2020 10:46:23 +0530 From: Vinod Koul To: =?utf-8?B?UmFmYcWC?= Hibner Cc: Appana Durga Kedareswara rao , Radhey Shyam Pandey , Harini Katakam , Dan Williams , Michal Simek , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , "moderated list:ARM/ZYNQ ARCHITECTURE" , open list Subject: Re: [PATCH] dma: zynqmp_dma: Initialize descriptor list after freeing during reset Message-ID: <20200504051623.GE1375924@vkoul-mobl> References: <20200428143225.3357-1-rafal.hibner@secom.com.pl> <20200502123242.GB1375924@vkoul-mobl> <1330934e-342e-1e16-6451-d8952463119c@secom.com.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1330934e-342e-1e16-6451-d8952463119c@secom.com.pl> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 02-05-20, 15:00, Rafał Hibner wrote: > Hello Vinod, > > On 02.05.2020 14:32, Vinod Koul wrote: > > Would it not be better to use list_del_init() where we delete it rather > > than do the init here? > > > > It is not a problem of list element itself not being initialized. > The problem is that during fault conditions (zynqmp_dma_reset) all > elements are moved to free list. List head however is not reinitialized. > > In normal flow elements are removed by list_del and resubmitted to > free list with zynqmp_dma_free_descriptor. > > static void zynqmp_dma_chan_desc_cleanup(struct zynqmp_dma_chan *chan) > { >     ... >     list_for_each_entry_safe(desc, next, &chan->done_list, node) { >         ... >         list_del(&desc->node); >         ... >         zynqmp_dma_free_descriptor(chan, desc); >     } > } > > The zynqmp_dma_free_descriptor does not delete elements from the > list by itself. > I am not he author of this driver so I fixed it by > doing non intrusive changes. > > Anyways, I do not see how using list_del_init would fix the bug. Looking at this, i think it would make sense to do list_splice_init() before we send the list to be freed. Radhey/Appana are cced, they should test this. -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F4AC3A5A9 for ; Mon, 4 May 2020 05:16:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB578206C0 for ; Mon, 4 May 2020 05:16:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qiZ4LN+3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LK29ZRn3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB578206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yssvN5dR5+XhZvAMlqsD6eIOzFA2JDe1oisP5ghkWMI=; b=qiZ4LN+3JMUqQp 7OPIIRSze3UvovVLBZmh0+Xvxjd6mrt7P2p74aubSK8KU1a29GFG415Q+jWhZfvp28eMJGLICVEOM AYTBBvNju6odpqkhEegB21jMXO7Qpk/JmVLedMxaayIM9dk0GTaTnDgxgrncnMiTpW7Y+AE+CcCsp S0qVvULbagDAPWU0GVd1hjcrMtgkIslUOvHLftSPmk80m2+iJKwx7u/nbi6KRZp2RWBWeIHHXOiXN amUuaFQBb0h1WBZRhQKH4M5jIew5y6Uct4o22dWJhM4y2j2BxqhqgP9eoVKN+KGvCuW0rY6V6DlP/ ICJFicJSgFz++Aj7JpoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVTSw-0003kS-Ft; Mon, 04 May 2020 05:16:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVTSu-0003k4-AI for linux-arm-kernel@lists.infradead.org; Mon, 04 May 2020 05:16:29 +0000 Received: from localhost (unknown [171.76.84.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 14099206C0; Mon, 4 May 2020 05:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588569387; bh=NDLbS7H6KX8JKKif2MK4betfRmG+k4ZuMRllise3FH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LK29ZRn37F496akRaG3GcO+JOrxhO4ifvkyc5p8z9aryf4UhKyF+AThH5xKRPGT49 JYYrGGeesrtjQwRtI9m/4zOrMGJ11uFjbZdrd0pUmVDP5037K61cLpFCuYyME+Ne21 3EKAg5il2Xg3hUuTZb/FKfFmfRCy0okr1oTZG+yU= Date: Mon, 4 May 2020 10:46:23 +0530 From: Vinod Koul To: =?utf-8?B?UmFmYcWC?= Hibner Subject: Re: [PATCH] dma: zynqmp_dma: Initialize descriptor list after freeing during reset Message-ID: <20200504051623.GE1375924@vkoul-mobl> References: <20200428143225.3357-1-rafal.hibner@secom.com.pl> <20200502123242.GB1375924@vkoul-mobl> <1330934e-342e-1e16-6451-d8952463119c@secom.com.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1330934e-342e-1e16-6451-d8952463119c@secom.com.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200503_221628_377188_157BDC92 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Radhey Shyam Pandey , Michal Simek , open list , Appana Durga Kedareswara rao , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , Harini Katakam , Dan Williams , "moderated list:ARM/ZYNQ ARCHITECTURE" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDItMDUtMjAsIDE1OjAwLCBSYWZhxYIgSGlibmVyIHdyb3RlOgo+IEhlbGxvIFZpbm9kLAo+ IAo+IE9uIDAyLjA1LjIwMjAgMTQ6MzIsIFZpbm9kIEtvdWwgd3JvdGU6Cj4gPiBXb3VsZCBpdCBu b3QgYmUgYmV0dGVyIHRvIHVzZSBsaXN0X2RlbF9pbml0KCkgd2hlcmUgd2UgZGVsZXRlIGl0IHJh dGhlcgo+ID4gdGhhbiBkbyB0aGUgaW5pdCBoZXJlPwo+ID4KPiAKPiBJdCBpcyBub3QgYSBwcm9i bGVtIG9mIGxpc3QgZWxlbWVudCBpdHNlbGYgbm90IGJlaW5nIGluaXRpYWxpemVkLgo+IFRoZSBw cm9ibGVtIGlzIHRoYXQgZHVyaW5nIGZhdWx0IGNvbmRpdGlvbnMgKHp5bnFtcF9kbWFfcmVzZXQp IGFsbAo+IGVsZW1lbnRzIGFyZSBtb3ZlZCB0byBmcmVlIGxpc3QuIExpc3QgaGVhZCBob3dldmVy IGlzIG5vdCByZWluaXRpYWxpemVkLgo+IAo+IEluIG5vcm1hbCBmbG93IGVsZW1lbnRzIGFyZSBy ZW1vdmVkIGJ5IGxpc3RfZGVsIGFuZCByZXN1Ym1pdHRlZCB0bwo+IGZyZWUgbGlzdCB3aXRoIHp5 bnFtcF9kbWFfZnJlZV9kZXNjcmlwdG9yLgo+IAo+IHN0YXRpYyB2b2lkIHp5bnFtcF9kbWFfY2hh bl9kZXNjX2NsZWFudXAoc3RydWN0IHp5bnFtcF9kbWFfY2hhbiAqY2hhbikKPiB7Cj4gwqDCoMKg IC4uLgo+IMKgwqDCoCBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUoZGVzYywgbmV4dCwgJmNoYW4t PmRvbmVfbGlzdCwgbm9kZSkgewo+IMKgwqDCoMKgwqDCoMKgIC4uLgo+IMKgwqDCoMKgwqDCoMKg IGxpc3RfZGVsKCZkZXNjLT5ub2RlKTsKPiDCoMKgwqDCoMKgwqDCoCAuLi4KPiDCoMKgwqDCoMKg wqDCoCB6eW5xbXBfZG1hX2ZyZWVfZGVzY3JpcHRvcihjaGFuLCBkZXNjKTsKPiDCoMKgwqAgfQo+ IH0KPiAKPiBUaGUgenlucW1wX2RtYV9mcmVlX2Rlc2NyaXB0b3IgZG9lcyBub3QgZGVsZXRlIGVs ZW1lbnRzIGZyb20gdGhlCj4gbGlzdCBieSBpdHNlbGYuCj4gSSBhbSBub3QgaGUgYXV0aG9yIG9m IHRoaXMgZHJpdmVyIHNvIEkgZml4ZWQgaXQgYnkKPiBkb2luZyBub24gaW50cnVzaXZlIGNoYW5n ZXMuCj4gCj4gQW55d2F5cywgSSBkbyBub3Qgc2VlIGhvdyB1c2luZyBsaXN0X2RlbF9pbml0IHdv dWxkIGZpeCB0aGUgYnVnLgoKTG9va2luZyBhdCB0aGlzLCBpIHRoaW5rIGl0IHdvdWxkIG1ha2Ug c2Vuc2UgdG8gZG8gbGlzdF9zcGxpY2VfaW5pdCgpCmJlZm9yZSB3ZSBzZW5kIHRoZSBsaXN0IHRv IGJlIGZyZWVkLgoKUmFkaGV5L0FwcGFuYSBhcmUgY2NlZCwgdGhleSBzaG91bGQgdGVzdCB0aGlz LgoKLS0gCn5WaW5vZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=