All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	Shannon Zhao <shannon.zhaosl@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
	Linuxarm <linuxarm@huawei.com>,
	Eric Auger <eric.auger@redhat.com>,
	qemu-arm <qemu-arm@nongnu.org>, Xu Wei <xuwei5@hisilicon.com>,
	prime.zeng@hisilicon.com, Igor Mammedov <imammedo@redhat.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH v4 0/7] ARM virt: Add NVDIMM support
Date: Mon, 4 May 2020 07:10:55 -0400	[thread overview]
Message-ID: <20200504071046-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA_VGtbjpVTb1VE1XCT43JODjkW8o1zSsVmzO3fg1+fr+w@mail.gmail.com>

On Mon, May 04, 2020 at 11:06:48AM +0100, Peter Maydell wrote:
> On Mon, 4 May 2020 at 10:57, Michael S. Tsirkin <mst@redhat.com> wrote:
> 
> > > ./scripts/checkpatch.pl --mailback base..
> 
> > > 2/7 Checking commit 5554e78b18ea (nvdimm: Use configurable ACPI IO base and size)
> > > ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-tables-test-allowed-diff.h and hw/acpi/nvdimm.c found
> >
> > This beats me. Where did we get
> > tests/qtest/bios-tables-test-allowed-diff.h from?
> > It's a different patch, isn't it?
> 
> Ah, this is a bug in the checkfilename() function -- it uses
> some globals $acpi_testexpected and $acpi_nontestexpected, but
> there is no code to reset these when checkpatch starts checking
> a new patch. So if you only check one patch in a checkpatch run
> (eg by just passing it a single patch file) then it will work, but if
> a single checkpatch execution is checking several commits
> (eg in the way patchew runs it to check the whole series of
> git commits at once, or if you pass it several patch files) then
> it will give wrong results for the second and later patches.
> I think the variables need to be reset at the top of 'sub process()'.
> 
> thanks
> -- PMM

Good point. Will fix.



  reply	other threads:[~2020-05-04 11:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 12:59 [PATCH v4 0/7] ARM virt: Add NVDIMM support Shameer Kolothum
2020-04-21 12:59 ` [PATCH v4 1/7] hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length Shameer Kolothum
2020-04-21 12:59 ` [PATCH v4 2/7] nvdimm: Use configurable ACPI IO base and size Shameer Kolothum
2020-04-21 12:59 ` [PATCH v4 3/7] hw/arm/virt: Add nvdimm hot-plug infrastructure Shameer Kolothum
2020-04-21 12:59 ` [PATCH v4 4/7] hw/arm/virt: Add nvdimm hotplug support Shameer Kolothum
2020-04-21 12:59 ` [PATCH v4 5/7] tests: Update ACPI tables list for upcoming arm/virt test changes Shameer Kolothum
2020-04-21 12:59 ` [PATCH v4 6/7] bios-tables-test: test pc-dimm and nvdimm coldplug for arm/virt Shameer Kolothum
2020-04-21 12:59 ` [PATCH v4 7/7] tests/acpi: add expected tables for bios-tables-test Shameer Kolothum
2020-04-21 15:12 ` [PATCH v4 0/7] ARM virt: Add NVDIMM support no-reply
2020-05-04  9:57   ` Michael S. Tsirkin
2020-05-04 10:06     ` Peter Maydell
2020-05-04 11:10       ` Michael S. Tsirkin [this message]
2020-05-04  5:13 ` Michael S. Tsirkin
2020-05-04  9:29   ` Peter Maydell
2020-05-04  9:44     ` Auger Eric
2020-05-04  9:46     ` Michael S. Tsirkin
2020-05-04  9:57       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200504071046-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=linuxarm@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=prime.zeng@hisilicon.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=shannon.zhaosl@gmail.com \
    --cc=xiaoguangrong.eric@gmail.com \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.