All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrik Gfeller <patrik.gfeller@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Francescodario Cuzzocrea 
	<francescodario.cuzzocrea@mail.polimi.it>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	"mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [GIT PULL] Ressurect the atomisp staging driver
Date: Mon, 4 May 2020 10:16:28 +0200	[thread overview]
Message-ID: <20200504101628.0f632bf2@ASUS> (raw)
In-Reply-To: <20200503180751.0b1e29c4@ASUS>

On Sun, 3 May 2020 18:07:51 +0200
Patrik Gfeller <patrik.gfeller@gmail.com> wrote:

> On Sun, 3 May 2020 18:03:54 +0200
> Francescodario Cuzzocrea <francescodario.cuzzocrea@mail.polimi.it> wrote:
> 
> > Il giorno dom 3 mag 2020 alle ore 17:32 Mauro Carvalho Chehab <    
>  [...]  
> > 
> > Thanks a lot !!
> >   
>  [...]  
> > According to my understarding mine which is baytrail should be  ISP2400  
> 
> I have ISP2401 (rev B) ... I'll give it a try :-) - thanks Mauro!

I was not able yet to compile the kernel 4.4 successfully yet. I get quite
some warnings that are treated as errors. I assume that I can "resolve"
this by removing the respective compiler flag (-Werror).

drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_cmd.c:36:10: fatal error: linux/kct.h: No such file or directory
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_internal.h:61: error: "IS_CHT" redefined [-Werror]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_internal.h:63: error: "IS_MOFD" redefined [-Werror]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_internal.h:65: error: "IS_BYT" redefined [-Werror]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_internal.h:61: error: "IS_CHT" redefined [-Werror]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_internal.h:63: error: "IS_MOFD" redefined [-Werror]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_internal.h:65: error: "IS_BYT" redefined [-Werror]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_compat_ioctl32.c:86:5: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_ioctl.c:590:5: error: this ‘else’ clause does not guard... [-Werror=misleading-indentation]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_ioctl.c:604:9: error: ‘struct v4l2_dbg_chip_ident’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
include/media/v4l2-subdev.h:821:51: error: ‘const struct v4l2_subdev_core_ops’ has no member named ‘g_chip_ident’
include/media/v4l2-subdev.h:822:15: error: ‘const struct v4l2_subdev_core_ops’ has no member named ‘g_chip_ident’
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_internal.h:61: error: "IS_CHT" redefined [-Werror]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_internal.h:63: error: "IS_MOFD" redefined [-Werror]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_internal.h:65: error: "IS_BYT" redefined [-Werror]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_ioctl.c:1916:3: error: implicit declaration of function ‘pci_write_config_word’; did you mean ‘gmin_get_config_var’? [-Werror=implicit-function-declaration]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_ioctl.c:1942:3: error: implicit declaration of function ‘INIT_COMPLETION’; did you mean ‘CONFIG_COMPACTION’? [-Werror=implicit-function-declaration]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_ioctl.c:2182:3: error: implicit declaration of function ‘pci_write_config_dword’; did you mean ‘gmin_get_config_var’? [-Werror=implicit-function-declaration]
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_ioctl.c:3063:3: error: ‘const struct v4l2_ioctl_ops’ has no member named ‘vidioc_g_chip_ident’; did you mean ‘vidioc_g_enc_index’?
drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_ioctl.c:3063:25: error: initialization of ‘int (*)(struct file *, void *, struct v4l2_fmtdesc *)’ from incompatible pointer type ‘int (*)(struct file *, void *, struct v4l2_dbg_chip_ident *)’ [-Werror=incompatible-pointer-types]
cc1: all warnings being treated as errors

But there are a few things that will take more time for me to investigate:

drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_cmd.c:36:10: fatal error: linux/kct.h: No such file or directory
include/media/v4l2-subdev.h:821:51: error: ‘const struct v4l2_subdev_core_ops’ has no member named ‘g_chip_ident’
include/media/v4l2-subdev.h:822:15: error: ‘const struct v4l2_subdev_core_ops’ has no member named ‘g_chip_ident’

I'll keep you updated.

> 
> > 
> > https://github.com/intel-aero/meta-intel-aero/blob/4ebb7cc829f57306b9895f20af8fd17987089392/recipes-kernel/linux/linux-yocto/shisp_2401a0_v21.bin  
>  [...]  
> > 
> > Dario  
> 

with kind regards,
Patrik


  reply	other threads:[~2020-05-04  8:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 19:57 [GIT PULL] Ressurect the atomisp staging driver Mauro Carvalho Chehab
2020-05-02  6:03 ` Greg KH
2020-05-20  7:48   ` Mauro Carvalho Chehab
2020-05-03  9:19 ` Francescodario Cuzzocrea
2020-05-03 10:07   ` Mauro Carvalho Chehab
2020-05-03 15:32   ` Mauro Carvalho Chehab
     [not found]     ` <CADnVkj96W0QfthukTKQ0a-i2fH1buooH3BEgfy22J9H9=_PcKA@mail.gmail.com>
2020-05-03 16:07       ` Patrik Gfeller
2020-05-04  8:16         ` Patrik Gfeller [this message]
2020-05-04  8:49           ` Mauro Carvalho Chehab
2020-05-04 10:45             ` Patrik Gfeller
2020-05-04 12:08               ` Mauro Carvalho Chehab
2020-05-04 13:44                 ` Patrik Gfeller
2020-05-15  8:32                   ` Mauro Carvalho Chehab
2020-05-15  9:10                     ` Hans de Goede
2020-05-15  9:42                       ` Mauro Carvalho Chehab
2020-05-19  7:39                         ` Mauro Carvalho Chehab
2020-05-19 17:36                           ` Mauro Carvalho Chehab
2020-05-22 10:46                             ` Hans de Goede
2020-05-22 11:42                               ` Mauro Carvalho Chehab
2020-05-23  8:00                                 ` Mauro Carvalho Chehab
2020-05-27 16:23                                   ` Hans de Goede
2020-05-27 17:36                                     ` Mauro Carvalho Chehab
2020-05-15  9:37                   ` Ressurect the atomisp staging driver - current progress Mauro Carvalho Chehab
2020-05-06 15:10                 ` [GIT PULL] Ressurect the atomisp staging driver Mauro Carvalho Chehab
2020-05-03  9:23 ` bosconovic
2020-05-16 13:23 [GIT,PULL] " Finn Rayment
     [not found] ` <20200516115459.4a24063b@coco.lan>
2020-05-16 19:53   ` Finn Rayment
2020-05-19 17:37     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200504101628.0f632bf2@ASUS \
    --to=patrik.gfeller@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=francescodario.cuzzocrea@mail.polimi.it \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.