From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4679FC3A5A9 for ; Mon, 4 May 2020 18:00:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28A232073E for ; Mon, 4 May 2020 18:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588615219; bh=2z9EdxzLZ9ktR46duVLhKtSLNiCl+AWVU+fs/Tm9xrU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LdWqVAu0gKvdZNFK/GKEY3JCkyBD+5xntryYG3YFDC6CQtpR2dG/ORuo5NbXDu4cZ YFPYbvuGum8XGg+6A1Nhw+zYVT9y+tGxJgqeneNcbkyefACCor/mkjHEbTQM8UCuRl thSUuy97OD8K2IHFQCzKR+gMUxLs9sdZBEpRxBvI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730968AbgEDSAR (ORCPT ); Mon, 4 May 2020 14:00:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:54572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730932AbgEDSAH (ORCPT ); Mon, 4 May 2020 14:00:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B9E820707; Mon, 4 May 2020 18:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588615207; bh=2z9EdxzLZ9ktR46duVLhKtSLNiCl+AWVU+fs/Tm9xrU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lamBRNxwaRQlwOCxWdnT3AyFyaefasCl26E3Yv6qtMoxTzeqlFo0kfkVewkqW3aCZ IBeEDA3e0finaHfUQhREV/GdFbgTcIdH1AkT5tDflH79Rsc8aYkc3o82gc+HWpxEGa d+5WxZybB8R0SNTN1Gen2hHG5TNrZxOItqFJj0Ho= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Theodore Tso , Dan Carpenter , stable@kernel.org, Guenter Roeck Subject: [PATCH 4.14 01/26] ext4: fix special inode number checks in __ext4_iget() Date: Mon, 4 May 2020 19:57:15 +0200 Message-Id: <20200504165442.749638833@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504165442.494398840@linuxfoundation.org> References: <20200504165442.494398840@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Theodore Ts'o commit 191ce17876c9367819c4b0a25b503c0f6d9054d8 upstream. The check for special (reserved) inode number checks in __ext4_iget() was broken by commit 8a363970d1dc: ("ext4: avoid declaring fs inconsistent due to invalid file handles"). This was caused by a botched reversal of the sense of the flag now known as EXT4_IGET_SPECIAL (when it was previously named EXT4_IGET_NORMAL). Fix the logic appropriately. Fixes: 8a363970d1dc ("ext4: avoid declaring fs inconsistent...") Signed-off-by: Theodore Ts'o Reported-by: Dan Carpenter Cc: stable@kernel.org Cc: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- fs/ext4/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4715,7 +4715,7 @@ struct inode *__ext4_iget(struct super_b gid_t i_gid; projid_t i_projid; - if (((flags & EXT4_IGET_NORMAL) && + if ((!(flags & EXT4_IGET_SPECIAL) && (ino < EXT4_FIRST_INO(sb) && ino != EXT4_ROOT_INO)) || (ino < EXT4_ROOT_INO) || (ino > le32_to_cpu(EXT4_SB(sb)->s_es->s_inodes_count))) {